Skip to content

Android fix dso 15687 [Android-Viewer]: Default Started streams appears off in settings - #9689

Merged
maloel merged 4 commits into
realsenseai:developmentfrom
gwen2018:android_fix_dso_15687
Sep 2, 2021
Merged

Android fix dso 15687 [Android-Viewer]: Default Started streams appears off in settings#9689
maloel merged 4 commits into
realsenseai:developmentfrom
gwen2018:android_fix_dso_15687

Conversation

@gwen2018

Copy link
Copy Markdown
Contributor

Fix [Android-Viewer]: Default Started streams appears off in settings

Changes:
1) added getActiveStreams api in sensor and pipeline on android
2) populate default stream profiles in camera viewer settings
3) turn off all settings to reset to default streams

Tracked on: DSO-15687

@gwen2018 gwen2018 changed the title Android fix dso 15687 Android fix dso 15687 [Android-Viewer]: Default Started streams appears off in settings Aug 25, 2021
HashMap<String, List<String>> expandableListDetail = new HashMap<String, List<String>>();

expandableListDetail.put("Configuration:(default-disable all)",settings_group);
expandableListDetail.put("Configuration:(turn off all to reset to default streams)",settings_group);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean?
If the user want to disable all streams he will turn off all streams and than the default streams will be on?
How can he disable all streams in that case?
It's confusing.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On android, when device is connected, the app starts the default streams automatically. User can change the stream profiles in settings, and reset to default streams by turning off all the stream settings. Currently, when the device is streaming under default profiles, the stream detail is not displayed under settings. This PR fixed it.

The device always streams either user chosen profiles or the default profiles. In current app, there is no usage to disable all streams (the messages disable all but actually it reset to default streams, I changed the message to make it clear). I'm not sure if we want to change that usage.

If we do, will need to introduce a new usage with all streams off, i.e., the camera may have no live streams. the user interface may need change too to make it clear start/stop the camera. I'd leave that in a separate PR and ask for more inputs for the usage/UI change.

@Nir-Az Nir-Az Sep 2, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh OK, I didn't knew that was the case today.

Thanks for the informative explanation.

@Nir-Az Nir-Az left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@maloel
maloel merged commit 92893b5 into realsenseai:development Sep 2, 2021
@gwen2018
gwen2018 deleted the android_fix_dso_15687 branch February 4, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants