Ucal fixes - #9882
Merged
Merged
Conversation
added 7 commits
October 20, 2021 16:38
Change-Id: If097075eaca121384c1402fb5472463b6802f6d5
… enhancements. LRS-323 Change-Id: I779cf59b0a7866a91eb1339cd67a22b821da1815
Change-Id: I21926ff7abf4b5c84a115b9b3d36083a17001361
Change-Id: I93a771edfe5f7b98e022104916ac45bdeea67e6f
Change-Id: Ie63198250ade72738baa9ba34f2865b5fc72e643
Change-Id: I99d3bb2b09b72888d28ba35b0fc6f0a462337c46
Change-Id: Ieb960bb265a02af3a354c33c9234cc52ef212c78
Change-Id: I64a437f46c91095352fe71f827e6b4f7018626f2
remibettan
reviewed
Oct 21, 2021
remibettan
left a comment
Contributor
There was a problem hiding this comment.
minor comment - relevant for several files
| float step = 50.f / limit; // frames gathering is 50% of the process, the rest is the internal data extraction and algo processing | ||
|
|
||
| rs2::frame_queue queue(limit*2,true); | ||
| rs2::frame_queue queue2(limit * 2, true); |
Contributor
There was a problem hiding this comment.
Could you think of some other name than queue, queue2 and queu3, so that it would explain the aim of it?
Contributor
Author
There was a problem hiding this comment.
Those are marked opaque on purpose to allow incremental development
Contributor
|
Approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ucal amendments
Tracked on: DSO-17774, DSO-17775, LRS-323