feat: Skip macros in C++ during parsing - #116
Merged
Merged
Conversation
added 2 commits
July 17, 2024 16:45
We can use TreeSitters includedRanges feature to only parse the specified ranges. This allows us to exclude certain macros like the AFX_EXT_CLASS macro which was causing issues previously.
LeonMatthesKDAB
marked this pull request as ready for review
July 18, 2024 07:31
Users can now specify a list of macros to exclude from the C++ parser through the options dialog. By default the list is pre-filled with: - AFX_EXT_CLASS - [A-Z_]*EXPORT[A-Z_]* - Q_OBJECT
LeonMatthesKDAB
force-pushed
the
30-macro-parsing
branch
from
July 18, 2024 07:45
67d1ad6 to
1ded7cd
Compare
narnaud
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can use TreeSitters "included ranges" to specify which parts of the document to include when parsing.
In our case we actually use this to exclude certain ranges, which are C++ pre-processor macros that would otherwise screw up our parsing.
Fix #30