Skip to content

add some more api to jsondocument - #76

Merged
mgiroday merged 1 commit into
KDAB:mainfrom
mgiroday:add-some-more-api-to-jsondocument
Aug 23, 2024
Merged

add some more api to jsondocument#76
mgiroday merged 1 commit into
KDAB:mainfrom
mgiroday:add-some-more-api-to-jsondocument

Conversation

@mgiroday

@mgiroday mgiroday commented Jun 28, 2024

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/core/settings.h Outdated
Comment thread src/core/jsonutilities.h Outdated
Comment thread src/core/jsonutilities.h Outdated
Comment thread src/core/jsonutilities.h Outdated
Comment thread src/core/jsonutilities.h Outdated
Comment thread src/core/jsonutilities.h Outdated
Comment thread src/core/jsonutilities.cpp Outdated
Comment thread src/core/jsonutilities.cpp Outdated
Comment thread src/core/jsonutilities.cpp Outdated
Comment thread src/core/jsonutilities.cpp Outdated
Comment thread src/core/jsonutilities.cpp Outdated
Comment thread src/core/jsonutilities.cpp Outdated
Comment thread src/core/jsonutilities.cpp Outdated
Comment thread src/core/jsondocument.cpp
Comment thread src/core/jsondocument.cpp Outdated
Comment thread src/core/settings.cpp
Comment thread tests/tst_jsondocument.cpp Outdated

@narnaud narnaud left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the general direction of the patch, thank you.

@mgiroday
mgiroday force-pushed the add-some-more-api-to-jsondocument branch 2 times, most recently from 7e5b9dd to 670c2c2 Compare August 13, 2024 10:40

@narnaud narnaud left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way better, small nitpicking and good to go.

Comment thread src/core/jsondocument.h Outdated
Comment thread src/core/jsondocument.cpp Outdated
Comment thread src/core/settings.cpp Outdated
Comment thread src/core/settings.cpp Outdated
Comment thread src/core/settings.h Outdated
Comment thread tests/tst_jsondocument.cpp Outdated
@mgiroday
mgiroday force-pushed the add-some-more-api-to-jsondocument branch from 670c2c2 to 9f89915 Compare August 21, 2024 10:41
@mgiroday
mgiroday force-pushed the add-some-more-api-to-jsondocument branch from 9f89915 to 463ab4a Compare August 23, 2024 04:54
@mgiroday
mgiroday merged commit 2559458 into KDAB:main Aug 23, 2024
@mgiroday
mgiroday deleted the add-some-more-api-to-jsondocument branch August 23, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants