Uh oh!
There was an error while loading. Please reload this page.
ExceptionThrower: adjust rate limit detection - #959
Merged
Conversation
naderman
commented
Mar 11, 2021
Contributor
Can we get this merged? It's a pretty clear bug and would be helpful to have this on the 2.x branch too. |
acrobat
approved these changes
Mar 11, 2021
acrobatforce-pushed
the
f/api-rate-limit-detection
branch
from
March 11, 2021 20:06
30473e9 to
1a650c1Compareacrobat
commented
Mar 11, 2021
Collaborator
Sorry for the delay! Thanks @glaubinix! |
acrobat
commented
Mar 11, 2021
Collaborator
This was referenced Mar 12, 2021
glaubinix
commented
Mar 12, 2021
ContributorAuthor
No worries. Thank you! |
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub returns 0 values for API limit headers on GraphQL endpoints in cases where no authentication is provided or the authentication is invalid. Running the following code currently triggers an
ApiLimitExceedExceptionbecause of that. Even though the GitHub API returns a 401 status code with the messageThis endpoint requires you to be authenticated.