Uh oh!
There was an error while loading. Please reload this page.
Improve BaseControllerV2 messenger type - #556
Merged
Merged
Conversation
The new base controller now accepts the messenger type as a generic parameter, rather than hard-coding it to be `RestrictedControllerMessenger<N, any, any, string, string>`. This allows controllers to use the messenger directly without sacrificing any type safety.
Gudahttforce-pushed
the
improve-base-controller-v2-messenger-type
branch
from
August 11, 2021 15:23
869aa30 to
c0d7dbcCompareGudahtt
commented
Aug 11, 2021
MemberAuthor
This was motivated by this discussion: #555 (comment) |
Merged
amitabh94 pushed a commit
to amitabh94/core
that referenced
this pull request
Jun 16, 2026
* 22.0.0 * release(22.0.0): update CHANGELOG --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: rarquevaux <r.arquevaux@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new base controller now accepts the messenger type as a generic parameter, rather than hard-coding it to be
RestrictedControllerMessenger<N, any, any, string, string>. This allows controllers to use the messenger directly without sacrificing any type safety.Note: this is a breaking change, because anyone extending
BaseControllerV2will now be required to supply an additional generic parameter.