Skip to content

Support multiline commands - #61

Merged
Christof Marti (chrmarti) merged 20 commits into
microsoft:masterfrom
mburleigh:SupportContinuationCharacter
Feb 3, 2020
Merged

Christof Marti (chrmarti) merged 20 commits into
microsoft:masterfrom
mburleigh:SupportContinuationCharacter

Conversation

@mburleigh

Copy link
Copy Markdown
Contributor

Working with JMESPath queries and Kusto queries (in the Resource Graph extension) results in some long commands.

This PR makes it possible to split long commands across several lines, add comments, and execute a selected substring of a longer command.

@mburleigh

Copy link
Copy Markdown
Contributor Author

Christof Marti (@chrmarti) / Chris Dias (@chrisdias) - I can't see the build error; can you take a look and let me know what's wrong?

@mburleigh

Copy link
Copy Markdown
Contributor Author

Christof Marti (@chrmarti) / Chris Dias (@chrisdias) - I set up an Azure DevOps build pipeline using the azure-pipelines.yml at the root of the project and the branch for this PR (in my fork) builds without any errors.

I you can let me know what the error is I'd love to fix it and get this merged.

@mburleigh

Copy link
Copy Markdown
Contributor Author

Christof Marti (@chrmarti) / Chris Dias (@chrisdias) - it's been a while since I checked on this PR. I can't see the build error but if you let me know what it is I'd love to get it fixed. If y'all don't think this PR is worthwhile just let me know and I can close it.

@chrmarti Christof Marti (chrmarti) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a few comments, please take a look. (Sorry for the delay.)

Comment thread src/extension.ts Outdated
Comment thread src/extension.ts Outdated
Comment thread src/extension.ts Outdated
Comment thread src/extension.ts Outdated
Comment thread src/extension.ts Outdated
Comment thread src/extension.ts Outdated
@mburleigh

Copy link
Copy Markdown
Contributor Author

Christof Marti (@chrmarti) - I see all the issues as being resolved; please let me know if there are still some changes I need to make.

@chrmarti

Copy link
Copy Markdown
Contributor

Matthew Burleigh (@mburleigh) Thanks, I should get to it this milestone.

@chrmarti

Copy link
Copy Markdown
Contributor

Looks good. I've added 'line' to the settings id to make it render nicely in the settings editor:
image

Thanks!

@chrmarti
Christof Marti (chrmarti) merged commit d843593 into microsoft:master Feb 3, 2020
@chrmarti

Copy link
Copy Markdown
Contributor

Matthew Burleigh (@mburleigh) I have published this feature with version 0.5.0 of the extension. As usual you will be mentioned in the VS Code (1.42) release notes for this PR. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants