From 45f124f7e74a661cdf520b3883b1edac5de32a62 Mon Sep 17 00:00:00 2001 From: James Lamb Date: Tue, 1 Jul 2025 09:39:47 -0500 Subject: [PATCH 1/2] add docs on CI workflow inputs --- .github/workflows/build.yaml | 6 ++++++ .github/workflows/pr.yaml | 1 - .github/workflows/test.yaml | 6 ++++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 7730e5b64d..9c487f2bdf 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -9,15 +9,21 @@ on: workflow_dispatch: inputs: branch: + description: | + branch: git branch the workflow run targets. + Required even when 'sha' is provided because it is also used for organizing artifacts. required: true type: string date: + description: "date: Date (YYYY-MM-DD) this run is for. Used to organize artifacts produced by nightly builds" required: true type: string sha: + description: "sha: full git commit SHA to check out" required: true type: string build_type: + description: "build_type: one of [branch, nightly, pull-request]" type: string default: nightly diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index 34fc4ed0b3..55d936b204 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -135,7 +135,6 @@ jobs: uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-post-build-checks.yaml@branch-25.08 with: build_type: pull-request - enable_check_symbols: true symbol_exclusions: (void (thrust::|cub::)) conda-python-build: needs: conda-cpp-build diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index fa7a1ae3a7..eef886410d 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -4,15 +4,21 @@ on: workflow_dispatch: inputs: branch: + description: | + branch: git branch the workflow run targets. + Required even when 'sha' is provided because it is also used for organizing artifacts. required: true type: string date: + description: "date: Date (YYYY-MM-DD) this run is for. Used to organize artifacts produced by nightly builds" required: true type: string sha: + description: "sha: full git commit SHA to check out" required: true type: string build_type: + description: "build_type: one of [branch, nightly, pull-request]" type: string default: nightly From f83b9900c580fd7c009e5afdeaf22f2c447d7a90 Mon Sep 17 00:00:00 2001 From: James Lamb Date: Tue, 1 Jul 2025 09:46:50 -0500 Subject: [PATCH 2/2] remove one more enable_check_symbols --- .github/workflows/test.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index eef886410d..7eaf54f7e5 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -31,7 +31,6 @@ jobs: branch: ${{ inputs.branch }} date: ${{ inputs.date }} sha: ${{ inputs.sha }} - enable_check_symbols: true symbol_exclusions: (void (thrust::|cub::)) conda-cpp-tests: secrets: inherit