Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

Commit 23aa6c5

Browse files
committed
fix: The provided Android NDK is vnull while the recommended one is v21.0.6113669 error in some cases
1 parent 8e47184 commit 23aa6c5

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

‎snapshot/android/snapshot-generator.js‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,11 @@ SnapshotGenerator.prototype.buildCSource = function (androidArch, blobInputDir,
400400
}
401401

402402
SnapshotGenerator.prototype.getRecommendedNdkWarning=function(localNdkRevision,recommendedAndroidNdkRevision){
403-
return`The provided Android NDK is v${localNdkRevision} while the recommended one is v${recommendedAndroidNdkRevision}`;
403+
if(localNdkRevision){
404+
return`The provided Android NDK is v${localNdkRevision} while the required one is v${recommendedAndroidNdkRevision}`;
405+
}else{
406+
return`The provided Android NDK version is different than the required one - v${recommendedAndroidNdkRevision}`;
407+
}
404408
}
405409

406410
SnapshotGenerator.prototype.runMksnapshotTool=function(tool,mksnapshotParams,inputFile,snapshotInDocker,snapshotToolsPath,buildCSource){

0 commit comments

Comments
 (0)