build: fail build if tests fail

This will allow all tests for a given sub-project to finish, but will
abort the rest of the build.
Previously the build would finish successfully even if there were test
failures.
Issue: #144
Signed-off-by: Tony Germano <tony@germano.name>

Author: tonygermano

client/ant-build.xml

@@ -359,7 +359,7 @@
  <mkdirdir="${code-coverage-reports}" />
 
  <jacoco:coveragedestfile="${code-coverage-reports}/jacoco.exec"xmlns:jacoco="antlib:org.jacoco.ant"exclclassloader="sun.reflect.DelegatingClassLoader:javassist.Loader" >
- <junithaltonfailure="false"fork="true"forkmode="once">
+ <junithaltonfailure="false"failureproperty="test.failed"errorproperty="test.failed"fork="true"forkmode="once">
  <jvmargvalue="-Xms128m" />
  <jvmargvalue="-Xmx2048m" />
 <!-- https://stackoverflow.com/questions/54205486 -->
@@ -376,6 +376,8 @@
  </batchtest>
  </junit>
  </jacoco:coverage>
+
+ <failif="test.failed"message="Unit tests failed. Check reports for details."/>
 	</target>
 
 	<targetname="remove-classes"depends="init">

command/build.xml

@@ -98,7 +98,7 @@
  <mkdirdir="${code-coverage-reports}" />
 
  <jacoco:coveragedestfile="${code-coverage-reports}/jacoco.exec"xmlns:jacoco="antlib:org.jacoco.ant"exclclassloader="sun.reflect.DelegatingClassLoader:javassist.Loader" >
- <junithaltonfailure="false"fork="true"forkmode="once">
+ <junithaltonfailure="false"failureproperty="test.failed"errorproperty="test.failed"fork="true"forkmode="once">
  <jvmargvalue="-Xms128m" />
  <jvmargvalue="-Xmx2048m" />
 <!-- https://stackoverflow.com/questions/54205486 -->
@@ -115,5 +115,7 @@
  </batchtest>
  </junit>
  </jacoco:coverage>
+
+ <failif="test.failed"message="Unit tests failed. Check reports for details."/>
 	</target>
 </project>

donkey/build.xml

@@ -97,7 +97,7 @@
  <mkdirdir="${code-coverage-reports}" />
 
  <jacoco:coveragedestfile="${code-coverage-reports}/jacoco.exec"xmlns:jacoco="antlib:org.jacoco.ant"exclclassloader="sun.reflect.DelegatingClassLoader:javassist.Loader" >
- <junithaltonfailure="false"fork="true"forkmode="once">
+ <junithaltonfailure="false"failureproperty="test.failed"errorproperty="test.failed"fork="true"forkmode="once">
  <jvmargvalue="-Xms128m" />
  <jvmargvalue="-Xmx2048m" />
 <!-- https://stackoverflow.com/questions/54205486 -->
@@ -114,6 +114,8 @@
  </batchtest>
  </junit>
  </jacoco:coverage>
+
+ <failif="test.failed"message="Unit tests failed. Check reports for details."/>
 	</target>
 
 <targetname="remove-classes"depends="init">

server/build.xml

@@ -1317,7 +1317,7 @@
  <mkdirdir="${junit-html}" />
 
  <jacoco:coveragedestfile="${code-coverage-reports}/jacoco.exec"xmlns:jacoco="antlib:org.jacoco.ant"exclclassloader="sun.reflect.DelegatingClassLoader:javassist.Loader" >
- <junithaltonfailure="false"fork="true"forkmode="once">
+ <junithaltonfailure="false"failureproperty="test.failed"errorproperty="test.failed"fork="true"forkmode="once">
  <jvmargvalue="-Xms128m" />
  <jvmargvalue="-Xmx2048m" />
 <!-- https://stackoverflow.com/questions/54205486 -->
@@ -1356,6 +1356,8 @@
  </fileset>
  <reportformat="frames"todir="${junit-html}" />
  </junitreport>
+
+ <failif="test.failed"message="Unit tests failed. Check reports for details."/>
 	</target>
 
 <targetname="remove-classes"depends="init">