fix: migrate legacy dir.logs log4j property

Fixes a crash on boot caused by dir.logs set in log4j2.properties, which
is not supported in log4j2. Cannot use normal migration infra since
log4j is initialized early in the boot processs (before classpath is
fully set up).
Issue: #267
Signed-off-by: Mitch Gaffigan <mgaffigan@users.noreply.github.com>

Author: Copilot

server/src/com/mirth/connect/server/launcher/MirthLauncher.java

@@ -15,6 +15,7 @@
 importjava.io.IOException;
 importjava.net.URL;
 importjava.net.URLClassLoader;
+importjava.nio.charset.StandardCharsets;
 importjava.util.ArrayList;
 importjava.util.Collection;
 importjava.util.List;
@@ -40,11 +41,13 @@ public class MirthLauncher {
 privatestaticfinalStringEXTENSIONS_DIR = "./extensions";
 privatestaticfinalStringSERVER_LAUNCHER_LIB_DIR = "./server-launcher-lib";
 privatestaticfinalStringMIRTH_PROPERTIES_FILE = "./conf/mirth.properties";
+privatestaticfinalStringLOG4J_PROPERTIES_FILE = "./conf/log4j2.properties";
 privatestaticfinalStringPROPERTY_APP_DATA_DIR = "dir.appdata";
 privatestaticfinalStringPROPERTY_INCLUDE_CUSTOM_LIB = "server.includecustomlib";
 privatestaticfinalString[] LOG4J_JAR_FILES = { "./server-lib/log4j/log4j-core-2.25.3.jar",
 "./server-lib/log4j/log4j-api-2.25.3.jar",
 "./server-lib/log4j/log4j-1.2-api-2.25.3.jar" };
+privatestaticfinalStringINVALID_LOG4J_PROPERTY = "dir.logs";
 
 privatestaticStringappDataDir = null;
 
@@ -53,6 +56,8 @@ public class MirthLauncher {
 publicstaticvoidmain(String[] args) {
 JarFilemirthClientCoreJarFile = null;
 try {
+sanitizeLog4jConfiguration(newFile(LOG4J_PROPERTIES_FILE));
+
 List<URL> classpathUrls = newArrayList<>();
 // Always add log4j
 for (Stringlog4jJar : LOG4J_JAR_FILES) {
@@ -128,6 +133,28 @@ public static void main(String[] args) {
  }
  }
 
+privatestaticvoidsanitizeLog4jConfiguration(FilepropertiesFile) {
+if (!propertiesFile.exists() || !propertiesFile.isFile()) {
+return;
+ }
+
+try {
+List<String> lines = FileUtils.readLines(propertiesFile, StandardCharsets.UTF_8);
+if (lines.removeIf(MirthLauncher::isInvalidLog4jPropertyLine)) {
+FileUtils.writeLines(propertiesFile, StandardCharsets.UTF_8.name(), lines, System.lineSeparator(), false);
+ }
+ } catch (IOExceptione) {
+System.err.println("Failed to sanitize Log4j configuration: " + propertiesFile.getAbsolutePath());
+e.printStackTrace();
+ }
+ }
+
+privatestaticbooleanisInvalidLog4jPropertyLine(Stringline) {
+StringtrimmedLine = line.trim();
+intequalsIndex = trimmedLine.indexOf('=');
+returnequalsIndex >= 0 && trimmedLine.substring(0, equalsIndex).trim().equals(INVALID_LOG4J_PROPERTY);
+ }
+
 // if we have an uninstall file, uninstall the listed extensions
 privatestaticvoiduninstallPendingExtensions() throwsException {
 FileextensionsDir = newFile(EXTENSIONS_DIR);

server/test/com/mirth/connect/server/launcher/MirthLauncherTest.java

@@ -0,0 +1,34 @@
+packagecom.mirth.connect.server.launcher;
+
+importstaticorg.junit.Assert.assertFalse;
+importstaticorg.junit.Assert.assertTrue;
+
+importjava.io.File;
+importjava.lang.reflect.Method;
+importjava.nio.charset.StandardCharsets;
+importjava.nio.file.Files;
+
+importorg.junit.Test;
+
+publicclassMirthLauncherTest {
+
+@Test
+publicvoidtestSanitizeLog4jRemovesDirLogs() throwsException {
+Filefile = File.createTempFile("log4j2", ".properties");
+file.deleteOnExit();
+Files.writeString(file.toPath(), String.join(System.lineSeparator(),
+"rootLogger = ERROR,stdout,fout",
+"dir.logs = logs",
+"property.log.dir = logs",
+"appender.rolling.fileName = ${log.dir}/mirth.log"), StandardCharsets.UTF_8);
+
+Methodmethod = MirthLauncher.class.getDeclaredMethod("sanitizeLog4jConfiguration", File.class);
+method.setAccessible(true);
+method.invoke(null, file);
+
+StringfileContents = Files.readString(file.toPath(), StandardCharsets.UTF_8);
+assertFalse(fileContents.contains("dir.logs"));
+assertTrue(fileContents.contains("property.log.dir = logs"));
+assertTrue(fileContents.contains("appender.rolling.fileName = ${log.dir}/mirth.log"));
+ }
+}