From 1342d9e8455d448daa8b182e9ecfaa49f29a81d2 Mon Sep 17 00:00:00 2001 From: Agli Chandra Pratama Date: Thu, 18 Jun 2026 22:56:16 +0700 Subject: [PATCH] fix: rename misleading USD Equivalent column in CSV exports The 'USD Equivalent' column in donation CSV exports was hardcoded to '0.00' with a comment indicating it would be fetched from a price cache in production. This is misleading for users who may trust the value for tax/accounting purposes. Changes: - Renamed column to 'USD Equivalent (pending)' to clearly indicate the value is not yet available - Changed hardcoded '0.00' to 'N/A' with explanatory comment - Applied to all three export locations: - src/users/users.service.ts - src/users/export.processor.ts - src/donations/donations.service.ts Closes #15 --- src/donations/donations.service.ts | 4 ++-- src/users/export.processor.ts | 4 ++-- src/users/users.service.ts | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/donations/donations.service.ts b/src/donations/donations.service.ts index 559e5d0..8ffe903 100644 --- a/src/donations/donations.service.ts +++ b/src/donations/donations.service.ts @@ -418,7 +418,7 @@ export class DonationsService { 'Asset', 'Date', 'Tx Hash', - 'USD Equivalent', + 'USD Equivalent (pending)', ]; const rows: string[] = [headers.map((h) => `"${h}"`).join(',')]; @@ -429,7 +429,7 @@ export class DonationsService { donation.assetCode, donation.donatedAt.toISOString().split('T')[0], `"${donation.txHash || ''}"`, - '0.00', + 'N/A', // Price oracle not yet integrated ]; rows.push(row.join(',')); } diff --git a/src/users/export.processor.ts b/src/users/export.processor.ts index e684ff5..bea4eb8 100644 --- a/src/users/export.processor.ts +++ b/src/users/export.processor.ts @@ -70,7 +70,7 @@ export class ExportProcessor { 'Asset', 'Date', 'Tx Hash', - 'USD Equivalent', + 'USD Equivalent (pending)', ]; const rows: string[] = [headers.map((h) => `"${h}"`).join(',')]; @@ -81,7 +81,7 @@ export class ExportProcessor { donation.assetCode, donation.donatedAt.toISOString().split('T')[0], `"${donation.txHash || ''}"`, - '0.00', // USD equivalent: fetched from price cache in production + 'N/A', // Price oracle not yet integrated ]; rows.push(row.join(',')); } diff --git a/src/users/users.service.ts b/src/users/users.service.ts index 13aca38..a9b7e86 100644 --- a/src/users/users.service.ts +++ b/src/users/users.service.ts @@ -406,7 +406,7 @@ export class UsersService { 'Asset', 'Date', 'Tx Hash', - 'USD Equivalent', + 'USD Equivalent (pending)', ]; const rows: string[] = [headers.map((h) => `"${h}"`).join(',')]; @@ -417,7 +417,7 @@ export class UsersService { donation.assetCode, donation.donatedAt.toISOString().split('T')[0], `"${donation.txHash || ''}"`, - '0.00', // USD equivalent: fetched from price cache in production + 'N/A', // Price oracle not yet integrated ]; rows.push(row.join(',')); }