SqlRSSetup: Will always make an edition upgrade

[johlju]

Details of the scenario you tried and the problem that is occurring

The parameter EditionUpgrade currently does not work. The resource will always make an edition upgrade if the configuration is change to use for example another Edition value.

Verbose logs showing the problem

n/a

Suggested solution to the issue

The function Test-TargetResource should handle this. Find a way to look what edition is currently installed. If the currently installed edition differs from what the configuration wants (and it is upgradable, e.g 'Eval' to 'Dev'), and EditionUpgrade is set to $true, then run Set-TargetResource. If the EditionUpgrade is set to $false (or not provided) Set-TargetResource should not be called even if the edition differs.

The DSC configuration that is used to reproduce the issue (as detailed as possible)

First run installs evaluation:

SqlRSSetup 'InstallDefaultInstance'
{
    InstanceName          = 'SSRS'
    IAcceptLicenseTerms   = 'Yes'
    SourcePath            = 'C:\InstallMedia\SQLServerReportingServices.exe'
    Edition               = 'Evaluation'

     PsDscRunAsCredential = $SqlInstallCredential
}

Second run upgrades the edition to 'Development':

SqlRSSetup 'InstallDefaultInstance'
{
    InstanceName          = 'SSRS'
    IAcceptLicenseTerms   = 'Yes'
    SourcePath            = 'C:\InstallMedia\SQLServerReportingServices.exe'
    Edition               = 'Development'
    EditionUpgrade        = $false

     PsDscRunAsCredential = $SqlInstallCredential
}

SQL Server edition and version the target node is running

Microsoft SQL Server Reporting Services 2017 (October 2017)

SQL Server PowerShell modules present on the target node

n/a

The operating system the target node is running

n/a

Version and build of PowerShell the target node is running

n/a

Version of the DSC module that was used ('dev' if using current dev branch)

Dev