Port jit path fixes - #17
Merged
Merged
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port JIT path fixes from Fix JIT path for Pytorch extensions and other hipify fixes (rocm5.0_internal_testing) #906 to hipify_torch
Pytorch build - passes (tested with local pytorch fork with hipify_submodule changes and jit path fix changes )
Changes made on top of jit fix PR changes:
Steps for pytorch build and install
git clone https://github.com/bmedishe/pytorch/tree/hipify_torch_sub_modulegit clone https://github.com/ROCmSoftwarePlatform/hipify_torch.gitcd pytorchgit submodule update --init --recursivecp -r ~/hipify_torch third_party/hipify_torchpython tools/amd_build/build_amd.pypython setup.py installDeepspeed(upstream 41d90830e2d78c154d560f36c8273ca2f889bbfb) jit build - passes
Deepspeed unittests -
=========================== short test summary info ============================
FAILED tests/unit/test_checkpointing.py::test_checkpoint_moe[4]
FAILED tests/unit/test_checkpointing.py::test_checkpoint_moe_and_zero[4-True]
FAILED tests/unit/test_checkpointing.py::test_checkpoint_moe_and_zero[2-True]
FAILED tests/unit/test_configurable_parallel.py::TestConfigurableMP::test_gpt2_basic
====== 4 failed, 581 passed, 58 skipped, 1 warning in 3850.22s (1:04:10) =======
Attached deepspeed jit build and unittest logs ( Note : #include<THC/THCGeneral.h> removed before building)