Uh oh!
There was an error while loading. Please reload this page.
Adding fix for still persistent #40 which still fired when user didn't exist - #70
Closed
rossdrew wants to merge 2 commits into
Closed
Adding fix for still persistent #40 which still fired when user didn't exist#70rossdrew wants to merge 2 commits into
rossdrew wants to merge 2 commits into
Conversation
klehman-rally
commented
Oct 10, 2016
Contributor
Incorporated the line of code with the else "Unknown" in 1.2.0. The root cause of the condition in which this happens in that the user credentials for the connection aren't a SubscriptionAdmin, so that issue is taken care of in code preceding this. Also the warning is commented out as if the user is not a SubscriptionAdmin the warning output is just lengthy without offering any real value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.