From db291bf627f648c265f279171418228b9c888ea6 Mon Sep 17 00:00:00 2001 From: Brent Rager Date: Tue, 25 Aug 2026 22:05:17 -0400 Subject: [PATCH] =?UTF-8?q?Retire=20the=20shared-drift=20gate=20=E2=80=94?= =?UTF-8?q?=20the=20copy=20it=20policed=20is=20being=20deleted?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The gate existed because SmooAI/client-shared kept a byte-identical copy of shared/, and the two had silently diverged (client-shared served the pre-f230808 monogram, no inner 'S', no dot, and had lost the .input CSS family). An org-wide search found nothing imports client_shared::ui. Its only real consumer, the th CLI, builds features=["auth"] and all 39 of its imports are smooai_client_shared::auth — the design half was pure residue from an abandoned migration. So the duplicate is being deleted at the source rather than policed forever, and this gate goes with it. This lands FIRST, deliberately: the gate curls client-shared/shared/ from the contents API, so removing that directory while the gate still runs would red this repo's CI for no reason. Consumers are unaffected — smooblue and observability-studio keep depending on this crate exactly as they do today. Co-Authored-By: Claude Fable 5 Claude-Session: https://claude.ai/code/session_0152bbE1veqfG1SVJdyLCBxC --- .github/workflows/rust.yml | 44 ++++++++------------------------------ README.md | 24 ++++++--------------- 2 files changed, 15 insertions(+), 53 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 0544bd8..882538b 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -1,9 +1,14 @@ name: Rust -# This repo shipped with no CI at all — `.github/` held only banner images — so -# a change could land unbuilt, and `shared/` could drift from SmooAI/client-shared -# without anything saying so. It did: SmooAI/client-shared spent weeks serving the -# pre-f230808 monogram (no inner 'S', no dot) because that fix never crossed. +# This repo shipped with no CI at all — `.github/` held only banner images — so a +# change could land unbuilt. +# +# It also used to carry a `shared-drift` job, because SmooAI/client-shared kept a +# byte-identical copy of `shared/` and the two silently diverged: client-shared +# spent weeks serving the pre-f230808 monogram (no inner 'S', no dot) because that +# fix never crossed. That copy is gone — client-shared is an auth library now, and +# nothing imported its `ui` module — so this repo is the single source of the +# design system and there is nothing left to drift against. on: pull_request: @@ -47,34 +52,3 @@ jobs: # never compiles and no other check can see it. - name: Every .rs file is reachable from the module tree run: python3 scripts/check-module-tree.py - - shared-drift: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - # SmooAI/client-shared owns the design system; this repo carries a copy for - # its own consumers. The gate is deliberately ONE-directional — client-shared - # is ungated, so a design change lands there first and this repo follows. - # A bidirectional gate would deadlock: neither PR could go green until the - # other merged. - # - # Compares git blob SHAs from the GitHub contents API against `git ls-tree`, - # so added and deleted files are caught as well as edited ones — no - # hand-maintained filename list to fall behind. - - name: shared/ must match SmooAI/client-shared - run: | - set -euo pipefail - curl -fsSL "https://api.github.com/repos/SmooAI/client-shared/contents/shared?ref=main" \ - | python3 -c 'import json,sys; [print(e["sha"], e["name"]) for e in sorted(json.load(sys.stdin), key=lambda e: e["name"])]' \ - > /tmp/upstream.txt - git ls-tree HEAD shared/ --format='%(objectname) %(path)' \ - | sed 's| shared/| |' | sort -k2 > /tmp/local.txt - if ! diff -u --label "SmooAI/client-shared@main" /tmp/upstream.txt --label "this repo" /tmp/local.txt; then - echo "::error::shared/ has drifted from SmooAI/client-shared, which owns the design system." - echo "Land the change in SmooAI/client-shared first, then copy shared/ across:" - echo " for f in \$(git ls-tree --name-only HEAD shared/); do" - echo " curl -fsSL \"https://raw.githubusercontent.com/SmooAI/client-shared/main/\$f\" -o \"\$f\"" - echo " done" - exit 1 - fi - echo "✓ shared/ matches SmooAI/client-shared@main" diff --git a/README.md b/README.md index dbb03d8..229fdbb 100644 --- a/README.md +++ b/README.md @@ -168,25 +168,13 @@ The honest per-language picture — one binding exists, the rest are direction, ## Relationship to client-shared -**[`SmooAI/client-shared`](https://github.com/SmooAI/client-shared) owns the design system. This repo carries a gated copy.** +**This repo owns the design system. [`SmooAI/client-shared`](https://github.com/SmooAI/client-shared) is an auth library and carries no copy of it.** -client-shared declares itself this crate's successor and is what the [`th` CLI](https://github.com/SmooAI/smooth) ships in production. This repo keeps `shared/` for its own consumers (`observability-studio`, smooblue), and CI **fails if the two diverge** — `shared-drift` compares every blob in `shared/` against `SmooAI/client-shared@main`. +It used to. client-shared declared itself this crate's successor and kept a byte-identical `shared/`, with a CI gate here failing if the two diverged. That arrangement is retired: an org-wide search found **nothing imported `client_shared::ui`** — its only consumer, the [`th` CLI](https://github.com/SmooAI/smooth), builds `features = ["auth"]` and never touched the design half. So the duplicate was deleted at the source rather than policed forever, and the gate went with it. -The gate is deliberately **one-directional**: client-shared is ungated, so a design change lands there first and this repo follows. A bidirectional gate would deadlock, with neither repo's PR able to go green until the other merged. +> The duplication was not hypothetical. The two copies **had** already diverged: the monogram fix in `f230808` ("restore the inner 'S' curve and the dot") never crossed, so client-shared served a monogram with no S and no dot, and its `styles.css` lost the whole `.input` family. Nothing was red. Deleting the copy removes the failure mode instead of detecting it. -Why a gate and not a cargo dependency on client-shared? Both crates are git dependencies rather than crates.io publishes, so depending across would put two independently rev-pinned git deps in one graph for any consumer that wants both. The gate closes the silent-divergence hole without the coupling. - -> This is not hypothetical. The two copies **had** already diverged: the monogram fix in `f230808` ("restore the inner 'S' curve and the dot") never crossed, so client-shared served a monogram with no S and no dot, and `styles.css` lost the whole `.input` family. Nothing was red. That is the defect this gate exists to prevent. - -To sync after a change lands upstream: - -```bash -for f in $(git ls-tree --name-only HEAD shared/); do - curl -fsSL "https://raw.githubusercontent.com/SmooAI/client-shared/main/$f" -o "$f" -done -``` - -If you need only the design system, either crate works — the `ui` surface is identical (`smooai_ui::STYLES` ⇄ `smooai_client_shared::ui::STYLES`). +Design changes land here, and only here. Consumers today are [`observability-studio`](https://github.com/SmooAI/observability) and [smooblue](https://github.com/SmooAI/smooblue). ## Versioning @@ -203,11 +191,11 @@ Per-language packages share the same semver line so consumers can correlate vers `@smooai/ui` is built and open-sourced by **[Smoo AI](https://smoo.ai)** — the AI-powered business platform with AI built into every product: CRM, customer support, campaigns, field service, observability, and developer tools. - 🧰 **More open source from Smoo AI** — [smoo.ai/open-source](https://smoo.ai/open-source) -- 🧩 **Sibling packages** — [client-shared](https://github.com/SmooAI/client-shared) (this crate's superset), [@smooai/logger](https://github.com/SmooAI/logger), [@smooai/utils](https://github.com/SmooAI/utils), [@smooai/file](https://github.com/SmooAI/file), [smooth](https://github.com/SmooAI/smooth) (the `th` CLI) +- 🧩 **Sibling packages** — [client-shared](https://github.com/SmooAI/client-shared) (auth for the `th` CLI), [@smooai/logger](https://github.com/SmooAI/logger), [@smooai/utils](https://github.com/SmooAI/utils), [@smooai/file](https://github.com/SmooAI/file), [smooth](https://github.com/SmooAI/smooth) (the `th` CLI) ## 🤝 Contributing -PRs welcome. Keep this surface narrow — only add a token or class when at least two apps need it. **Design-system changes land in [`SmooAI/client-shared`](https://github.com/SmooAI/client-shared) first**; this repo's `shared/` is a gated copy and CI rejects a divergent one. Add tokens to `shared/tokens.json` (the Rust constants generate from it) rather than to the CSS alone. +PRs welcome. Keep this surface narrow — only add a token or class when at least two apps need it. **Design-system changes land here** — this repo is the single source. Add tokens to `shared/tokens.json` (the Rust constants generate from it) rather than to the CSS alone. ## 📄 License