Skip to content

Commit 1031f03

Browse files
committed
Fail Docker build when pip check fails before SDK override
Use && after pip check so its exit status gates the RUN step; with a trailing semicolon, an empty or successful SDK_VERSION branch could mask a broken dependency environment.
1 parent 33d6897 commit 1031f03

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎Dockerfile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ RUN if [ "$USE_LOCAL_INSTALL" = "true" ]; then \
143143
echo "Failed to install socketsecurity==$CLI_VERSION after 10 attempts"; \
144144
exit 1; \
145145
fi; \
146-
pip check; \
146+
pip check && \
147147
if [ ! -z "$SDK_VERSION" ]; then \
148148
pip install --index-url ${PIP_INDEX_URL} --extra-index-url ${PIP_EXTRA_INDEX_URL} socketdev==${SDK_VERSION}; \
149149
fi; \

0 commit comments

Comments
 (0)