From c58002519c3d8b3c6c204b673b2d1d26548ae0a8 Mon Sep 17 00:00:00 2001
From: "google-labs-jules[bot]"
 <161369871+google-labs-jules[bot]@users.noreply.github.com>
Date: Tue, 25 Aug 2026 10:00:25 +0000
Subject: [PATCH] Eliminate redundant file existence checks

Removed time-of-check to time-of-use (TOCTOU) `exists()` calls before `read_to_string` during the dependency resolution loop in `cli/src/project.rs`. This relies directly on the `Result` of the file open/read operation, preventing a redundant `stat` syscall per evaluated file dependency which improves file resolution performance.

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
---
 cli/src/project.rs | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/cli/src/project.rs b/cli/src/project.rs
index 3e10ab78..acf3ed6e 100644
--- a/cli/src/project.rs
+++ b/cli/src/project.rs
@@ -148,12 +148,10 @@ impl ProjectBuildGraph {
 
         // 1. Add all entry points to compilation list
         for pkg in self.workspace.packages.values_mut() {
-            if pkg.entry_file.exists() {
-                if let Ok(source) = std::fs::read_to_string(&pkg.entry_file) {
-                    let fid = source_mgr.add_file(pkg.entry_file.clone(), source.clone());
-                    pkg.entry_file_id = Some(fid);
-                    to_resolve.push((fid, pkg.entry_file.clone(), pkg.name.clone()));
-                }
+            if let Ok(source) = std::fs::read_to_string(&pkg.entry_file) {
+                let fid = source_mgr.add_file(pkg.entry_file.clone(), source.clone());
+                pkg.entry_file_id = Some(fid);
+                to_resolve.push((fid, pkg.entry_file.clone(), pkg.name.clone()));
             }
         }
 
@@ -269,12 +267,10 @@ impl ProjectBuildGraph {
                     }
                 }
 
-                if import_file.exists() {
-                    if let Ok(source) = std::fs::read_to_string(&import_file) {
-                        let dep_fid = source_mgr.add_file(import_file.clone(), source);
-                        dep_fids.push(dep_fid);
-                        to_resolve.push((dep_fid, import_file, pkg_name.clone()));
-                    }
+                if let Ok(source) = std::fs::read_to_string(&import_file) {
+                    let dep_fid = source_mgr.add_file(import_file.clone(), source);
+                    dep_fids.push(dep_fid);
+                    to_resolve.push((dep_fid, import_file, pkg_name.clone()));
                 }
             }