From 4528eac709c1edd27dc42f699a5f4b587cd0e744 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Wed, 18 Feb 2026 19:30:50 +0000 Subject: [PATCH 1/3] chore: remove hardcoded API URL fallback and add environment validation - Removed 'http://localhost:3000' fallback for VITE_API_URL in frontend/src/services/api.ts - Added runtime check to throw an error if VITE_API_URL is not defined - Created frontend/.env.example to document required environment variables - Updated frontend/src/test/setup.ts to mock VITE_API_URL for tests Co-authored-by: davidraehles <6085055+davidraehles@users.noreply.github.com> --- frontend/.env.example | 1 + frontend/src/services/api.ts | 6 +++++- frontend/src/test/setup.ts | 5 ++++- 3 files changed, 10 insertions(+), 2 deletions(-) create mode 100644 frontend/.env.example diff --git a/frontend/.env.example b/frontend/.env.example new file mode 100644 index 0000000..5317fce --- /dev/null +++ b/frontend/.env.example @@ -0,0 +1 @@ +VITE_API_URL=http://localhost:3000 diff --git a/frontend/src/services/api.ts b/frontend/src/services/api.ts index d97db38..55f4791 100644 --- a/frontend/src/services/api.ts +++ b/frontend/src/services/api.ts @@ -4,7 +4,11 @@ import type { EncryptedNote, LoginCredentials, RegisterCredentials, User } from '../models/types'; -const API_BASE_URL = import.meta.env.VITE_API_URL || 'http://localhost:3000'; +const API_BASE_URL = import.meta.env.VITE_API_URL; + +if (!API_BASE_URL) { + throw new Error('VITE_API_URL environment variable is not defined'); +} class ApiClient { private baseUrl: string; diff --git a/frontend/src/test/setup.ts b/frontend/src/test/setup.ts index 28dc603..543469c 100644 --- a/frontend/src/test/setup.ts +++ b/frontend/src/test/setup.ts @@ -2,7 +2,10 @@ * Test setup file for Vitest */ -import { expect, afterEach } from 'vitest'; +import { expect, afterEach, vi } from 'vitest'; + +// Mock environment variables +vi.stubEnv('VITE_API_URL', 'http://localhost:3000'); import { cleanup } from '@testing-library/react'; import '@testing-library/jest-dom'; From 9ff4730ebdbef7486f8003b0aa848eb2f43e06a3 Mon Sep 17 00:00:00 2001 From: David Date: Wed, 18 Feb 2026 21:16:47 +0100 Subject: [PATCH 2/3] fix: address review feedback - remove unused expect import from test setup --- frontend/src/test/setup.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/test/setup.ts b/frontend/src/test/setup.ts index 543469c..7dcd43c 100644 --- a/frontend/src/test/setup.ts +++ b/frontend/src/test/setup.ts @@ -2,7 +2,7 @@ * Test setup file for Vitest */ -import { expect, afterEach, vi } from 'vitest'; +import { afterEach, vi } from 'vitest'; // Mock environment variables vi.stubEnv('VITE_API_URL', 'http://localhost:3000'); From 5b0a3c13c61cc8b0820e93d2a8541144466c64b0 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Wed, 18 Feb 2026 20:18:07 +0000 Subject: [PATCH 3/3] chore: address PR feedback - remove unused expect import from test setup Co-authored-by: davidraehles <6085055+davidraehles@users.noreply.github.com>