Commit 0a032dc

Browse files
ToolboxAidToolboxAid
committed
Calculate Assets upload progress from file bytes without blocking the UI - PR_26163_079-assets-byte-accurate-upload-progress
1 parent 19a0289 commit 0a032dc

7 files changed

Lines changed: 1025 additions & 2047 deletions

File tree

‎docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md‎

Lines changed: 118 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,118 @@
1+
# PR_26163_079-assets-byte-accurate-upload-progress
2+
3+
## Branch Validation
4+
5+
- Current branch: `main`
6+
- Expected branch: `main`
7+
- Branch validation: PASS
8+
9+
## Requirement Checklist
10+
11+
- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before changes.
12+
- PASS: Continued from PR_26163_078.
13+
- PASS: Replaced staged upload progress with byte-based progress.
14+
- PASS: Progress bar percentage is calculated as `bytesUploaded / totalBytes`.
15+
- PASS: Upload file processing now runs through `toolbox/assets/assets-upload-worker.js`.
16+
- PASS: Dev/test throttled uploads update incrementally per worker chunk.
17+
- PASS: Progress starts at 0 before first bytes upload.
18+
- PASS: Progress does not jump to 50% on start.
19+
- PASS: Progress reaches 100 only after selected bytes are processed and repository write succeeds.
20+
- PASS: Failed write after byte transfer shows FAIL and creates no asset record.
21+
- PASS: Batch progress uses summed uploaded bytes divided by summed selected bytes.
22+
- PASS: Inline upload progress remains below each upload-capable asset table.
23+
- PASS: `/projects/` directory validation and create-if-missing behavior are preserved from PR_26163_078.
24+
- PASS: Duplicate same folder/filename blocking is preserved.
25+
- PASS: `codex_review.diff` is UTF-8 readable.
26+
- PASS: Full samples smoke was not run.
27+
28+
## Byte Progress Evidence
29+
30+
- Playwright test `Assets worker upload progress is byte accurate and keeps the UI responsive` validates:
31+
- progress value starts at `0`;
32+
- bytes uploaded starts at `0 B`;
33+
- first chunk progress is greater than `0`, less than `50`, and not equal to `50`;
34+
- later chunk progress is greater than the first chunk value;
35+
- final successful upload reaches `100`.
36+
- Playwright test `Assets batch progress uses summed uploaded bytes across selected files` validates two equal 20-byte files reach `50` after the first file succeeds, then `100` when both writes succeed.
37+
- Playwright test `Assets upload write failure after byte transfer is visible and creates no asset record` validates bytes progress becomes greater than `0`, remains below `100`, shows FAIL, and asset count stays `0`.
38+
39+
## UI Responsiveness Evidence
40+
41+
- During throttled worker upload, Playwright toggles the Audio accordion and verifies its `open` state changes.
42+
- During throttled worker upload, Playwright scrolls the page and verifies `window.scrollY > 0`.
43+
- Progress fields continue rendering while the UI remains interactive: BPS, speed, ETA, elapsed, current file, and per-file status are asserted during/after throttled upload.
44+
- No cancel/stop upload control exists in the current Assets UI; no cancel behavior was added in this PR.
45+
46+
## Worker / Background Execution Evidence
47+
48+
- New worker file: `toolbox/assets/assets-upload-worker.js`.
49+
- Assets page creates the worker with `new Worker(UPLOAD_WORKER_URL, { type: "module" })`.
50+
- Playwright waits for the `worker` event and asserts the worker URL contains `toolbox/assets/assets-upload-worker.js`.
51+
- Inline upload diagnostics expose worker status (`Active`, `Write Pending`, `Complete`, `Failed`) for validation.
52+
53+
## Throttled Upload Evidence
54+
55+
- Dev/test throttling remains query-parameter controlled through `uploadProgressDelayMs`.
56+
- Added dev/test chunk-size control through `uploadChunkSizeBytes`.
57+
- Targeted tests use throttled uploads with small chunks to validate incremental progress without affecting production uploads.
58+
59+
## Changed Files
60+
61+
-`toolbox/assets/assets.js`
62+
-`toolbox/assets/assets-upload-worker.js`
63+
-`tests/playwright/tools/AssetToolMockRepository.spec.mjs`
64+
-`docs_build/dev/reports/playwright_v8_coverage_report.txt`
65+
-`docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md`
66+
-`docs_build/dev/reports/codex_review.diff`
67+
-`docs_build/dev/reports/codex_changed_files.txt`
68+
69+
## Impacted Lanes
70+
71+
- runtime: Assets upload UI progress and worker-backed file processing.
72+
- integration: Assets upload path through server/mock repository remains exercised by Playwright.
73+
- recovery/UAT: targeted Assets Playwright coverage for throttled upload behavior and failure behavior.
74+
75+
## Skipped Lanes
76+
77+
- samples: SKIP. This PR is scoped to Toolbox Assets upload progress and does not change sample runtime contracts.
78+
- engine: SKIP. No engine input/render/game runtime files changed.
79+
80+
## Validation Performed
81+
82+
- PASS: `node --check toolbox/assets/assets.js`
83+
- PASS: `node --check toolbox/assets/assets-upload-worker.js`
84+
- PASS: `node --check tests/playwright/tools/AssetToolMockRepository.spec.mjs`
85+
- PASS: `git diff --check -- toolbox/assets/assets.js toolbox/assets/assets-upload-worker.js tests/playwright/tools/AssetToolMockRepository.spec.mjs`
86+
- PASS: `git diff --check -- .`
87+
- PASS: `npx playwright test tests/playwright/tools/AssetToolMockRepository.spec.mjs --workers=1 --reporter=list`
88+
- Result: 13 passed.
89+
- PASS: `npm run test:workspace-v2`
90+
- Result: workspace-contract lane passed, 5 Playwright tests passed.
91+
92+
## Playwright Result
93+
94+
- PASS: Targeted Assets Playwright suite passed 13/13.
95+
- PASS: `npm run test:workspace-v2` passed.
96+
97+
## V8 Coverage
98+
99+
- Coverage report: `docs_build/dev/reports/playwright_v8_coverage_report.txt`
100+
- PASS: `toolbox/assets/assets.js` collected browser V8 coverage: 93%.
101+
- WARN: `toolbox/assets/assets-upload-worker.js` is listed in the changed runtime JS coverage report, but Chromium page-level V8 coverage did not collect dedicated worker script coverage. Worker execution is still validated by Playwright worker-event assertions.
102+
- WARN: `src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js` appears from the stacked HEAD changed-file coverage baseline and is Node-side repository code not collected by Chromium page coverage.
103+
104+
## Manual Validation Steps
105+
106+
1. Open `/toolbox/assets/index.html?uploadProgressDelayMs=180&uploadChunkSizeBytes=8` in local DB mode.
107+
2. Reset Asset Library.
108+
3. Add Images, choose a usage, and select a file.
109+
4. Confirm inline upload progress starts at `0%`, then increments by bytes instead of jumping to `50%`.
110+
5. Confirm BPS, speed, ETA, elapsed, current file, and bytes uploaded update while the upload is running.
111+
6. Toggle another asset accordion during upload and confirm it remains responsive.
112+
7. Confirm successful write reaches `100%` and creates one asset record.
113+
8. Repeat with write support disabled and confirm FAIL appears, progress remains below `100%`, and no record is created.
114+
115+
## Samples Validation
116+
117+
- Full samples smoke: SKIP.
118+
- Reason: requested skip, and this PR is limited to Assets upload progress behavior.

‎docs_build/dev/reports/codex_changed_files.txt‎

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,16 @@
11
# git status --short
2-
M docs_build/dev/reports/codex_changed_files.txt
3-
M docs_build/dev/reports/codex_review.diff
4-
M docs_build/dev/reports/playwright_v8_coverage_report.txt
5-
M src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js
2+
M docs_build/dev/reports/playwright_v8_coverage_report.txt
63
M tests/playwright/tools/AssetToolMockRepository.spec.mjs
74
M toolbox/assets/assets.js
8-
?? docs_build/dev/reports/PR_26163_078-assets-inline-upload-progress.md
5+
?? docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md
6+
?? toolbox/assets/assets-upload-worker.js
97

108
# git ls-files --others --exclude-standard
11-
docs_build/dev/reports/PR_26163_078-assets-inline-upload-progress.md
9+
docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md
10+
toolbox/assets/assets-upload-worker.js
1211

1312
# git diff --stat
14-
docs_build/dev/reports/codex_changed_files.txt | 14 +-
15-
docs_build/dev/reports/codex_review.diff | 1160 +++++++++++++-------
16-
.../dev/reports/playwright_v8_coverage_report.txt | 6 +-
17-
.../tool-repositories/assets-mock-repository.js | 198 +++-
18-
.../tools/AssetToolMockRepository.spec.mjs | 61 +
19-
toolbox/assets/assets.js | 177 ++-
20-
6 files changed, 1162 insertions(+), 454 deletions(-)
13+
.../dev/reports/playwright_v8_coverage_report.txt | 11 +-
14+
.../tools/AssetToolMockRepository.spec.mjs | 108 ++++++++++++++-
15+
toolbox/assets/assets.js | 149 +++++++++++++++++----
16+
3 files changed, 234 insertions(+), 34 deletions(-)

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Commit 0a032dc
Browse files
ToolboxAidToolboxAid
committed
Calculate Assets upload progress from file bytes without blocking the UI - PR_26163_079-assets-byte-accurate-upload-progress
1 parent 19a0289 commit 0a032dc
7 files changed
Lines changed: 1025 additions & 2047 deletions
File tree
‎docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md‎
Lines changed: 118 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,118 @@
1+
# PR_26163_079-assets-byte-accurate-upload-progress
2+
3+
## Branch Validation
4+
5+
- Current branch: `main`
6+
- Expected branch: `main`
7+
- Branch validation: PASS
8+
9+
## Requirement Checklist
10+
11+
- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before changes.
12+
- PASS: Continued from PR_26163_078.
13+
- PASS: Replaced staged upload progress with byte-based progress.
14+
- PASS: Progress bar percentage is calculated as `bytesUploaded / totalBytes`.
15+
- PASS: Upload file processing now runs through `toolbox/assets/assets-upload-worker.js`.
16+
- PASS: Dev/test throttled uploads update incrementally per worker chunk.
17+
- PASS: Progress starts at 0 before first bytes upload.
18+
- PASS: Progress does not jump to 50% on start.
19+
- PASS: Progress reaches 100 only after selected bytes are processed and repository write succeeds.
20+
- PASS: Failed write after byte transfer shows FAIL and creates no asset record.
21+
- PASS: Batch progress uses summed uploaded bytes divided by summed selected bytes.
22+
- PASS: Inline upload progress remains below each upload-capable asset table.
23+
- PASS: `/projects/` directory validation and create-if-missing behavior are preserved from PR_26163_078.
24+
- PASS: Duplicate same folder/filename blocking is preserved.
25+
- PASS: `codex_review.diff` is UTF-8 readable.
26+
- PASS: Full samples smoke was not run.
27+
28+
## Byte Progress Evidence
29+
30+
- Playwright test `Assets worker upload progress is byte accurate and keeps the UI responsive` validates:
31+
- progress value starts at `0`;
32+
- bytes uploaded starts at `0 B`;
33+
- first chunk progress is greater than `0`, less than `50`, and not equal to `50`;
34+
- later chunk progress is greater than the first chunk value;
35+
- final successful upload reaches `100`.
36+
- Playwright test `Assets batch progress uses summed uploaded bytes across selected files` validates two equal 20-byte files reach `50` after the first file succeeds, then `100` when both writes succeed.
37+
- Playwright test `Assets upload write failure after byte transfer is visible and creates no asset record` validates bytes progress becomes greater than `0`, remains below `100`, shows FAIL, and asset count stays `0`.
38+
39+
## UI Responsiveness Evidence
40+
41+
- During throttled worker upload, Playwright toggles the Audio accordion and verifies its `open` state changes.
42+
- During throttled worker upload, Playwright scrolls the page and verifies `window.scrollY > 0`.
43+
- Progress fields continue rendering while the UI remains interactive: BPS, speed, ETA, elapsed, current file, and per-file status are asserted during/after throttled upload.
44+
- No cancel/stop upload control exists in the current Assets UI; no cancel behavior was added in this PR.
45+
46+
## Worker / Background Execution Evidence
47+
48+
- New worker file: `toolbox/assets/assets-upload-worker.js`.
49+
- Assets page creates the worker with `new Worker(UPLOAD_WORKER_URL, { type: "module" })`.
50+
- Playwright waits for the `worker` event and asserts the worker URL contains `toolbox/assets/assets-upload-worker.js`.
51+
- Inline upload diagnostics expose worker status (`Active`, `Write Pending`, `Complete`, `Failed`) for validation.
52+
53+
## Throttled Upload Evidence
54+
55+
- Dev/test throttling remains query-parameter controlled through `uploadProgressDelayMs`.
56+
- Added dev/test chunk-size control through `uploadChunkSizeBytes`.
57+
- Targeted tests use throttled uploads with small chunks to validate incremental progress without affecting production uploads.
58+
59+
## Changed Files
60+
61+
-`toolbox/assets/assets.js`
62+
-`toolbox/assets/assets-upload-worker.js`
63+
-`tests/playwright/tools/AssetToolMockRepository.spec.mjs`
64+
-`docs_build/dev/reports/playwright_v8_coverage_report.txt`
65+
-`docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md`
66+
-`docs_build/dev/reports/codex_review.diff`
67+
-`docs_build/dev/reports/codex_changed_files.txt`
68+
69+
## Impacted Lanes
70+
71+
- runtime: Assets upload UI progress and worker-backed file processing.
72+
- integration: Assets upload path through server/mock repository remains exercised by Playwright.
73+
- recovery/UAT: targeted Assets Playwright coverage for throttled upload behavior and failure behavior.
74+
75+
## Skipped Lanes
76+
77+
- samples: SKIP. This PR is scoped to Toolbox Assets upload progress and does not change sample runtime contracts.
78+
- engine: SKIP. No engine input/render/game runtime files changed.
79+
80+
## Validation Performed
81+
82+
- PASS: `node --check toolbox/assets/assets.js`
83+
- PASS: `node --check toolbox/assets/assets-upload-worker.js`
84+
- PASS: `node --check tests/playwright/tools/AssetToolMockRepository.spec.mjs`
85+
- PASS: `git diff --check -- toolbox/assets/assets.js toolbox/assets/assets-upload-worker.js tests/playwright/tools/AssetToolMockRepository.spec.mjs`
86+
- PASS: `git diff --check -- .`
87+
- PASS: `npx playwright test tests/playwright/tools/AssetToolMockRepository.spec.mjs --workers=1 --reporter=list`
88+
- Result: 13 passed.
89+
- PASS: `npm run test:workspace-v2`
90+
- Result: workspace-contract lane passed, 5 Playwright tests passed.
91+
92+
## Playwright Result
93+
94+
- PASS: Targeted Assets Playwright suite passed 13/13.
95+
- PASS: `npm run test:workspace-v2` passed.
96+
97+
## V8 Coverage
98+
99+
- Coverage report: `docs_build/dev/reports/playwright_v8_coverage_report.txt`
100+
- PASS: `toolbox/assets/assets.js` collected browser V8 coverage: 93%.
101+
- WARN: `toolbox/assets/assets-upload-worker.js` is listed in the changed runtime JS coverage report, but Chromium page-level V8 coverage did not collect dedicated worker script coverage. Worker execution is still validated by Playwright worker-event assertions.
102+
- WARN: `src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js` appears from the stacked HEAD changed-file coverage baseline and is Node-side repository code not collected by Chromium page coverage.
103+
104+
## Manual Validation Steps
105+
106+
1. Open `/toolbox/assets/index.html?uploadProgressDelayMs=180&uploadChunkSizeBytes=8` in local DB mode.
107+
2. Reset Asset Library.
108+
3. Add Images, choose a usage, and select a file.
109+
4. Confirm inline upload progress starts at `0%`, then increments by bytes instead of jumping to `50%`.
110+
5. Confirm BPS, speed, ETA, elapsed, current file, and bytes uploaded update while the upload is running.
111+
6. Toggle another asset accordion during upload and confirm it remains responsive.
112+
7. Confirm successful write reaches `100%` and creates one asset record.
113+
8. Repeat with write support disabled and confirm FAIL appears, progress remains below `100%`, and no record is created.
114+
115+
## Samples Validation
116+
117+
- Full samples smoke: SKIP.
118+
- Reason: requested skip, and this PR is limited to Assets upload progress behavior.
‎docs_build/dev/reports/codex_changed_files.txt‎
Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,16 @@
11
# git status --short
2-
M docs_build/dev/reports/codex_changed_files.txt
3-
 M docs_build/dev/reports/codex_review.diff
4-
 M docs_build/dev/reports/playwright_v8_coverage_report.txt
5-
 M src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js
2+
M docs_build/dev/reports/playwright_v8_coverage_report.txt
63
 M tests/playwright/tools/AssetToolMockRepository.spec.mjs
74
 M toolbox/assets/assets.js
8-
?? docs_build/dev/reports/PR_26163_078-assets-inline-upload-progress.md
5+
?? docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md
6+
?? toolbox/assets/assets-upload-worker.js
97

108
# git ls-files --others --exclude-standard
11-
docs_build/dev/reports/PR_26163_078-assets-inline-upload-progress.md
9+
docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md
10+
toolbox/assets/assets-upload-worker.js
1211

1312
# git diff --stat
14-
docs_build/dev/reports/codex_changed_files.txt | 14 +-
15-
 docs_build/dev/reports/codex_review.diff | 1160 +++++++++++++-------
16-
 .../dev/reports/playwright_v8_coverage_report.txt | 6 +-
17-
 .../tool-repositories/assets-mock-repository.js | 198 +++-
18-
 .../tools/AssetToolMockRepository.spec.mjs | 61 +
19-
 toolbox/assets/assets.js | 177 ++-
20-
 6 files changed, 1162 insertions(+), 454 deletions(-)
13+
.../dev/reports/playwright_v8_coverage_report.txt | 11 +-
14+
 .../tools/AssetToolMockRepository.spec.mjs | 108 ++++++++++++++-
15+
 toolbox/assets/assets.js | 149 +++++++++++++++++----
16+
 3 files changed, 234 insertions(+), 34 deletions(-)
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit 0a032dc
Browse files
ToolboxAidToolboxAid
committed
Calculate Assets upload progress from file bytes without blocking the UI - PR_26163_079-assets-byte-accurate-upload-progress
1 parent 19a0289 commit 0a032dc
7 files changed
Lines changed: 1025 additions & 2047 deletions
File tree
‎docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md‎
Lines changed: 118 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,118 @@
1+
# PR_26163_079-assets-byte-accurate-upload-progress
2+
3+
## Branch Validation
4+
5+
- Current branch: `main`
6+
- Expected branch: `main`
7+
- Branch validation: PASS
8+
9+
## Requirement Checklist
10+
11+
- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before changes.
12+
- PASS: Continued from PR_26163_078.
13+
- PASS: Replaced staged upload progress with byte-based progress.
14+
- PASS: Progress bar percentage is calculated as `bytesUploaded / totalBytes`.
15+
- PASS: Upload file processing now runs through `toolbox/assets/assets-upload-worker.js`.
16+
- PASS: Dev/test throttled uploads update incrementally per worker chunk.
17+
- PASS: Progress starts at 0 before first bytes upload.
18+
- PASS: Progress does not jump to 50% on start.
19+
- PASS: Progress reaches 100 only after selected bytes are processed and repository write succeeds.
20+
- PASS: Failed write after byte transfer shows FAIL and creates no asset record.
21+
- PASS: Batch progress uses summed uploaded bytes divided by summed selected bytes.
22+
- PASS: Inline upload progress remains below each upload-capable asset table.
23+
- PASS: `/projects/` directory validation and create-if-missing behavior are preserved from PR_26163_078.
24+
- PASS: Duplicate same folder/filename blocking is preserved.
25+
- PASS: `codex_review.diff` is UTF-8 readable.
26+
- PASS: Full samples smoke was not run.
27+
28+
## Byte Progress Evidence
29+
30+
- Playwright test `Assets worker upload progress is byte accurate and keeps the UI responsive` validates:
31+
- progress value starts at `0`;
32+
- bytes uploaded starts at `0 B`;
33+
- first chunk progress is greater than `0`, less than `50`, and not equal to `50`;
34+
- later chunk progress is greater than the first chunk value;
35+
- final successful upload reaches `100`.
36+
- Playwright test `Assets batch progress uses summed uploaded bytes across selected files` validates two equal 20-byte files reach `50` after the first file succeeds, then `100` when both writes succeed.
37+
- Playwright test `Assets upload write failure after byte transfer is visible and creates no asset record` validates bytes progress becomes greater than `0`, remains below `100`, shows FAIL, and asset count stays `0`.
38+
39+
## UI Responsiveness Evidence
40+
41+
- During throttled worker upload, Playwright toggles the Audio accordion and verifies its `open` state changes.
42+
- During throttled worker upload, Playwright scrolls the page and verifies `window.scrollY > 0`.
43+
- Progress fields continue rendering while the UI remains interactive: BPS, speed, ETA, elapsed, current file, and per-file status are asserted during/after throttled upload.
44+
- No cancel/stop upload control exists in the current Assets UI; no cancel behavior was added in this PR.
45+
46+
## Worker / Background Execution Evidence
47+
48+
- New worker file: `toolbox/assets/assets-upload-worker.js`.
49+
- Assets page creates the worker with `new Worker(UPLOAD_WORKER_URL, { type: "module" })`.
50+
- Playwright waits for the `worker` event and asserts the worker URL contains `toolbox/assets/assets-upload-worker.js`.
51+
- Inline upload diagnostics expose worker status (`Active`, `Write Pending`, `Complete`, `Failed`) for validation.
52+
53+
## Throttled Upload Evidence
54+
55+
- Dev/test throttling remains query-parameter controlled through `uploadProgressDelayMs`.
56+
- Added dev/test chunk-size control through `uploadChunkSizeBytes`.
57+
- Targeted tests use throttled uploads with small chunks to validate incremental progress without affecting production uploads.
58+
59+
## Changed Files
60+
61+
-`toolbox/assets/assets.js`
62+
-`toolbox/assets/assets-upload-worker.js`
63+
-`tests/playwright/tools/AssetToolMockRepository.spec.mjs`
64+
-`docs_build/dev/reports/playwright_v8_coverage_report.txt`
65+
-`docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md`
66+
-`docs_build/dev/reports/codex_review.diff`
67+
-`docs_build/dev/reports/codex_changed_files.txt`
68+
69+
## Impacted Lanes
70+
71+
- runtime: Assets upload UI progress and worker-backed file processing.
72+
- integration: Assets upload path through server/mock repository remains exercised by Playwright.
73+
- recovery/UAT: targeted Assets Playwright coverage for throttled upload behavior and failure behavior.
74+
75+
## Skipped Lanes
76+
77+
- samples: SKIP. This PR is scoped to Toolbox Assets upload progress and does not change sample runtime contracts.
78+
- engine: SKIP. No engine input/render/game runtime files changed.
79+
80+
## Validation Performed
81+
82+
- PASS: `node --check toolbox/assets/assets.js`
83+
- PASS: `node --check toolbox/assets/assets-upload-worker.js`
84+
- PASS: `node --check tests/playwright/tools/AssetToolMockRepository.spec.mjs`
85+
- PASS: `git diff --check -- toolbox/assets/assets.js toolbox/assets/assets-upload-worker.js tests/playwright/tools/AssetToolMockRepository.spec.mjs`
86+
- PASS: `git diff --check -- .`
87+
- PASS: `npx playwright test tests/playwright/tools/AssetToolMockRepository.spec.mjs --workers=1 --reporter=list`
88+
- Result: 13 passed.
89+
- PASS: `npm run test:workspace-v2`
90+
- Result: workspace-contract lane passed, 5 Playwright tests passed.
91+
92+
## Playwright Result
93+
94+
- PASS: Targeted Assets Playwright suite passed 13/13.
95+
- PASS: `npm run test:workspace-v2` passed.
96+
97+
## V8 Coverage
98+
99+
- Coverage report: `docs_build/dev/reports/playwright_v8_coverage_report.txt`
100+
- PASS: `toolbox/assets/assets.js` collected browser V8 coverage: 93%.
101+
- WARN: `toolbox/assets/assets-upload-worker.js` is listed in the changed runtime JS coverage report, but Chromium page-level V8 coverage did not collect dedicated worker script coverage. Worker execution is still validated by Playwright worker-event assertions.
102+
- WARN: `src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js` appears from the stacked HEAD changed-file coverage baseline and is Node-side repository code not collected by Chromium page coverage.
103+
104+
## Manual Validation Steps
105+
106+
1. Open `/toolbox/assets/index.html?uploadProgressDelayMs=180&uploadChunkSizeBytes=8` in local DB mode.
107+
2. Reset Asset Library.
108+
3. Add Images, choose a usage, and select a file.
109+
4. Confirm inline upload progress starts at `0%`, then increments by bytes instead of jumping to `50%`.
110+
5. Confirm BPS, speed, ETA, elapsed, current file, and bytes uploaded update while the upload is running.
111+
6. Toggle another asset accordion during upload and confirm it remains responsive.
112+
7. Confirm successful write reaches `100%` and creates one asset record.
113+
8. Repeat with write support disabled and confirm FAIL appears, progress remains below `100%`, and no record is created.
114+
115+
## Samples Validation
116+
117+
- Full samples smoke: SKIP.
118+
- Reason: requested skip, and this PR is limited to Assets upload progress behavior.
‎docs_build/dev/reports/codex_changed_files.txt‎
Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,16 @@
11
# git status --short
2-
M docs_build/dev/reports/codex_changed_files.txt
3-
 M docs_build/dev/reports/codex_review.diff
4-
 M docs_build/dev/reports/playwright_v8_coverage_report.txt
5-
 M src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js
2+
M docs_build/dev/reports/playwright_v8_coverage_report.txt
63
 M tests/playwright/tools/AssetToolMockRepository.spec.mjs
74
 M toolbox/assets/assets.js
8-
?? docs_build/dev/reports/PR_26163_078-assets-inline-upload-progress.md
5+
?? docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md
6+
?? toolbox/assets/assets-upload-worker.js
97

108
# git ls-files --others --exclude-standard
11-
docs_build/dev/reports/PR_26163_078-assets-inline-upload-progress.md
9+
docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md
10+
toolbox/assets/assets-upload-worker.js
1211

1312
# git diff --stat
14-
docs_build/dev/reports/codex_changed_files.txt | 14 +-
15-
 docs_build/dev/reports/codex_review.diff | 1160 +++++++++++++-------
16-
 .../dev/reports/playwright_v8_coverage_report.txt | 6 +-
17-
 .../tool-repositories/assets-mock-repository.js | 198 +++-
18-
 .../tools/AssetToolMockRepository.spec.mjs | 61 +
19-
 toolbox/assets/assets.js | 177 ++-
20-
 6 files changed, 1162 insertions(+), 454 deletions(-)
13+
.../dev/reports/playwright_v8_coverage_report.txt | 11 +-
14+
 .../tools/AssetToolMockRepository.spec.mjs | 108 ++++++++++++++-
15+
 toolbox/assets/assets.js | 149 +++++++++++++++++----
16+
 3 files changed, 234 insertions(+), 34 deletions(-)
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit 0a032dc
Browse files
ToolboxAidToolboxAid
committed
Calculate Assets upload progress from file bytes without blocking the UI - PR_26163_079-assets-byte-accurate-upload-progress
1 parent 19a0289 commit 0a032dc
7 files changed
Lines changed: 1025 additions & 2047 deletions
File tree
‎docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md‎
Lines changed: 118 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,118 @@
1+
# PR_26163_079-assets-byte-accurate-upload-progress
2+
3+
## Branch Validation
4+
5+
- Current branch: `main`
6+
- Expected branch: `main`
7+
- Branch validation: PASS
8+
9+
## Requirement Checklist
10+
11+
- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before changes.
12+
- PASS: Continued from PR_26163_078.
13+
- PASS: Replaced staged upload progress with byte-based progress.
14+
- PASS: Progress bar percentage is calculated as `bytesUploaded / totalBytes`.
15+
- PASS: Upload file processing now runs through `toolbox/assets/assets-upload-worker.js`.
16+
- PASS: Dev/test throttled uploads update incrementally per worker chunk.
17+
- PASS: Progress starts at 0 before first bytes upload.
18+
- PASS: Progress does not jump to 50% on start.
19+
- PASS: Progress reaches 100 only after selected bytes are processed and repository write succeeds.
20+
- PASS: Failed write after byte transfer shows FAIL and creates no asset record.
21+
- PASS: Batch progress uses summed uploaded bytes divided by summed selected bytes.
22+
- PASS: Inline upload progress remains below each upload-capable asset table.
23+
- PASS: `/projects/` directory validation and create-if-missing behavior are preserved from PR_26163_078.
24+
- PASS: Duplicate same folder/filename blocking is preserved.
25+
- PASS: `codex_review.diff` is UTF-8 readable.
26+
- PASS: Full samples smoke was not run.
27+
28+
## Byte Progress Evidence
29+
30+
- Playwright test `Assets worker upload progress is byte accurate and keeps the UI responsive` validates:
31+
- progress value starts at `0`;
32+
- bytes uploaded starts at `0 B`;
33+
- first chunk progress is greater than `0`, less than `50`, and not equal to `50`;
34+
- later chunk progress is greater than the first chunk value;
35+
- final successful upload reaches `100`.
36+
- Playwright test `Assets batch progress uses summed uploaded bytes across selected files` validates two equal 20-byte files reach `50` after the first file succeeds, then `100` when both writes succeed.
37+
- Playwright test `Assets upload write failure after byte transfer is visible and creates no asset record` validates bytes progress becomes greater than `0`, remains below `100`, shows FAIL, and asset count stays `0`.
38+
39+
## UI Responsiveness Evidence
40+
41+
- During throttled worker upload, Playwright toggles the Audio accordion and verifies its `open` state changes.
42+
- During throttled worker upload, Playwright scrolls the page and verifies `window.scrollY > 0`.
43+
- Progress fields continue rendering while the UI remains interactive: BPS, speed, ETA, elapsed, current file, and per-file status are asserted during/after throttled upload.
44+
- No cancel/stop upload control exists in the current Assets UI; no cancel behavior was added in this PR.
45+
46+
## Worker / Background Execution Evidence
47+
48+
- New worker file: `toolbox/assets/assets-upload-worker.js`.
49+
- Assets page creates the worker with `new Worker(UPLOAD_WORKER_URL, { type: "module" })`.
50+
- Playwright waits for the `worker` event and asserts the worker URL contains `toolbox/assets/assets-upload-worker.js`.
51+
- Inline upload diagnostics expose worker status (`Active`, `Write Pending`, `Complete`, `Failed`) for validation.
52+
53+
## Throttled Upload Evidence
54+
55+
- Dev/test throttling remains query-parameter controlled through `uploadProgressDelayMs`.
56+
- Added dev/test chunk-size control through `uploadChunkSizeBytes`.
57+
- Targeted tests use throttled uploads with small chunks to validate incremental progress without affecting production uploads.
58+
59+
## Changed Files
60+
61+
-`toolbox/assets/assets.js`
62+
-`toolbox/assets/assets-upload-worker.js`
63+
-`tests/playwright/tools/AssetToolMockRepository.spec.mjs`
64+
-`docs_build/dev/reports/playwright_v8_coverage_report.txt`
65+
-`docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md`
66+
-`docs_build/dev/reports/codex_review.diff`
67+
-`docs_build/dev/reports/codex_changed_files.txt`
68+
69+
## Impacted Lanes
70+
71+
- runtime: Assets upload UI progress and worker-backed file processing.
72+
- integration: Assets upload path through server/mock repository remains exercised by Playwright.
73+
- recovery/UAT: targeted Assets Playwright coverage for throttled upload behavior and failure behavior.
74+
75+
## Skipped Lanes
76+
77+
- samples: SKIP. This PR is scoped to Toolbox Assets upload progress and does not change sample runtime contracts.
78+
- engine: SKIP. No engine input/render/game runtime files changed.
79+
80+
## Validation Performed
81+
82+
- PASS: `node --check toolbox/assets/assets.js`
83+
- PASS: `node --check toolbox/assets/assets-upload-worker.js`
84+
- PASS: `node --check tests/playwright/tools/AssetToolMockRepository.spec.mjs`
85+
- PASS: `git diff --check -- toolbox/assets/assets.js toolbox/assets/assets-upload-worker.js tests/playwright/tools/AssetToolMockRepository.spec.mjs`
86+
- PASS: `git diff --check -- .`
87+
- PASS: `npx playwright test tests/playwright/tools/AssetToolMockRepository.spec.mjs --workers=1 --reporter=list`
88+
- Result: 13 passed.
89+
- PASS: `npm run test:workspace-v2`
90+
- Result: workspace-contract lane passed, 5 Playwright tests passed.
91+
92+
## Playwright Result
93+
94+
- PASS: Targeted Assets Playwright suite passed 13/13.
95+
- PASS: `npm run test:workspace-v2` passed.
96+
97+
## V8 Coverage
98+
99+
- Coverage report: `docs_build/dev/reports/playwright_v8_coverage_report.txt`
100+
- PASS: `toolbox/assets/assets.js` collected browser V8 coverage: 93%.
101+
- WARN: `toolbox/assets/assets-upload-worker.js` is listed in the changed runtime JS coverage report, but Chromium page-level V8 coverage did not collect dedicated worker script coverage. Worker execution is still validated by Playwright worker-event assertions.
102+
- WARN: `src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js` appears from the stacked HEAD changed-file coverage baseline and is Node-side repository code not collected by Chromium page coverage.
103+
104+
## Manual Validation Steps
105+
106+
1. Open `/toolbox/assets/index.html?uploadProgressDelayMs=180&uploadChunkSizeBytes=8` in local DB mode.
107+
2. Reset Asset Library.
108+
3. Add Images, choose a usage, and select a file.
109+
4. Confirm inline upload progress starts at `0%`, then increments by bytes instead of jumping to `50%`.
110+
5. Confirm BPS, speed, ETA, elapsed, current file, and bytes uploaded update while the upload is running.
111+
6. Toggle another asset accordion during upload and confirm it remains responsive.
112+
7. Confirm successful write reaches `100%` and creates one asset record.
113+
8. Repeat with write support disabled and confirm FAIL appears, progress remains below `100%`, and no record is created.
114+
115+
## Samples Validation
116+
117+
- Full samples smoke: SKIP.
118+
- Reason: requested skip, and this PR is limited to Assets upload progress behavior.
‎docs_build/dev/reports/codex_changed_files.txt‎
Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,16 @@
11
# git status --short
2-
M docs_build/dev/reports/codex_changed_files.txt
3-
 M docs_build/dev/reports/codex_review.diff
4-
 M docs_build/dev/reports/playwright_v8_coverage_report.txt
5-
 M src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js
2+
M docs_build/dev/reports/playwright_v8_coverage_report.txt
63
 M tests/playwright/tools/AssetToolMockRepository.spec.mjs
74
 M toolbox/assets/assets.js
8-
?? docs_build/dev/reports/PR_26163_078-assets-inline-upload-progress.md
5+
?? docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md
6+
?? toolbox/assets/assets-upload-worker.js
97

108
# git ls-files --others --exclude-standard
11-
docs_build/dev/reports/PR_26163_078-assets-inline-upload-progress.md
9+
docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md
10+
toolbox/assets/assets-upload-worker.js
1211

1312
# git diff --stat
14-
docs_build/dev/reports/codex_changed_files.txt | 14 +-
15-
 docs_build/dev/reports/codex_review.diff | 1160 +++++++++++++-------
16-
 .../dev/reports/playwright_v8_coverage_report.txt | 6 +-
17-
 .../tool-repositories/assets-mock-repository.js | 198 +++-
18-
 .../tools/AssetToolMockRepository.spec.mjs | 61 +
19-
 toolbox/assets/assets.js | 177 ++-
20-
 6 files changed, 1162 insertions(+), 454 deletions(-)
13+
.../dev/reports/playwright_v8_coverage_report.txt | 11 +-
14+
 .../tools/AssetToolMockRepository.spec.mjs | 108 ++++++++++++++-
15+
 toolbox/assets/assets.js | 149 +++++++++++++++++----
16+
 3 files changed, 234 insertions(+), 34 deletions(-)
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Commit 0a032dc
Browse files
ToolboxAidToolboxAid
committed
Calculate Assets upload progress from file bytes without blocking the UI - PR_26163_079-assets-byte-accurate-upload-progress
1 parent 19a0289 commit 0a032dc
7 files changed
Lines changed: 1025 additions & 2047 deletions
File tree
‎docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md‎
Lines changed: 118 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,118 @@
1+
# PR_26163_079-assets-byte-accurate-upload-progress
2+
3+
## Branch Validation
4+
5+
- Current branch: `main`
6+
- Expected branch: `main`
7+
- Branch validation: PASS
8+
9+
## Requirement Checklist
10+
11+
- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before changes.
12+
- PASS: Continued from PR_26163_078.
13+
- PASS: Replaced staged upload progress with byte-based progress.
14+
- PASS: Progress bar percentage is calculated as `bytesUploaded / totalBytes`.
15+
- PASS: Upload file processing now runs through `toolbox/assets/assets-upload-worker.js`.
16+
- PASS: Dev/test throttled uploads update incrementally per worker chunk.
17+
- PASS: Progress starts at 0 before first bytes upload.
18+
- PASS: Progress does not jump to 50% on start.
19+
- PASS: Progress reaches 100 only after selected bytes are processed and repository write succeeds.
20+
- PASS: Failed write after byte transfer shows FAIL and creates no asset record.
21+
- PASS: Batch progress uses summed uploaded bytes divided by summed selected bytes.
22+
- PASS: Inline upload progress remains below each upload-capable asset table.
23+
- PASS: `/projects/` directory validation and create-if-missing behavior are preserved from PR_26163_078.
24+
- PASS: Duplicate same folder/filename blocking is preserved.
25+
- PASS: `codex_review.diff` is UTF-8 readable.
26+
- PASS: Full samples smoke was not run.
27+
28+
## Byte Progress Evidence
29+
30+
- Playwright test `Assets worker upload progress is byte accurate and keeps the UI responsive` validates:
31+
- progress value starts at `0`;
32+
- bytes uploaded starts at `0 B`;
33+
- first chunk progress is greater than `0`, less than `50`, and not equal to `50`;
34+
- later chunk progress is greater than the first chunk value;
35+
- final successful upload reaches `100`.
36+
- Playwright test `Assets batch progress uses summed uploaded bytes across selected files` validates two equal 20-byte files reach `50` after the first file succeeds, then `100` when both writes succeed.
37+
- Playwright test `Assets upload write failure after byte transfer is visible and creates no asset record` validates bytes progress becomes greater than `0`, remains below `100`, shows FAIL, and asset count stays `0`.
38+
39+
## UI Responsiveness Evidence
40+
41+
- During throttled worker upload, Playwright toggles the Audio accordion and verifies its `open` state changes.
42+
- During throttled worker upload, Playwright scrolls the page and verifies `window.scrollY > 0`.
43+
- Progress fields continue rendering while the UI remains interactive: BPS, speed, ETA, elapsed, current file, and per-file status are asserted during/after throttled upload.
44+
- No cancel/stop upload control exists in the current Assets UI; no cancel behavior was added in this PR.
45+
46+
## Worker / Background Execution Evidence
47+
48+
- New worker file: `toolbox/assets/assets-upload-worker.js`.
49+
- Assets page creates the worker with `new Worker(UPLOAD_WORKER_URL, { type: "module" })`.
50+
- Playwright waits for the `worker` event and asserts the worker URL contains `toolbox/assets/assets-upload-worker.js`.
51+
- Inline upload diagnostics expose worker status (`Active`, `Write Pending`, `Complete`, `Failed`) for validation.
52+
53+
## Throttled Upload Evidence
54+
55+
- Dev/test throttling remains query-parameter controlled through `uploadProgressDelayMs`.
56+
- Added dev/test chunk-size control through `uploadChunkSizeBytes`.
57+
- Targeted tests use throttled uploads with small chunks to validate incremental progress without affecting production uploads.
58+
59+
## Changed Files
60+
61+
-`toolbox/assets/assets.js`
62+
-`toolbox/assets/assets-upload-worker.js`
63+
-`tests/playwright/tools/AssetToolMockRepository.spec.mjs`
64+
-`docs_build/dev/reports/playwright_v8_coverage_report.txt`
65+
-`docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md`
66+
-`docs_build/dev/reports/codex_review.diff`
67+
-`docs_build/dev/reports/codex_changed_files.txt`
68+
69+
## Impacted Lanes
70+
71+
- runtime: Assets upload UI progress and worker-backed file processing.
72+
- integration: Assets upload path through server/mock repository remains exercised by Playwright.
73+
- recovery/UAT: targeted Assets Playwright coverage for throttled upload behavior and failure behavior.
74+
75+
## Skipped Lanes
76+
77+
- samples: SKIP. This PR is scoped to Toolbox Assets upload progress and does not change sample runtime contracts.
78+
- engine: SKIP. No engine input/render/game runtime files changed.
79+
80+
## Validation Performed
81+
82+
- PASS: `node --check toolbox/assets/assets.js`
83+
- PASS: `node --check toolbox/assets/assets-upload-worker.js`
84+
- PASS: `node --check tests/playwright/tools/AssetToolMockRepository.spec.mjs`
85+
- PASS: `git diff --check -- toolbox/assets/assets.js toolbox/assets/assets-upload-worker.js tests/playwright/tools/AssetToolMockRepository.spec.mjs`
86+
- PASS: `git diff --check -- .`
87+
- PASS: `npx playwright test tests/playwright/tools/AssetToolMockRepository.spec.mjs --workers=1 --reporter=list`
88+
- Result: 13 passed.
89+
- PASS: `npm run test:workspace-v2`
90+
- Result: workspace-contract lane passed, 5 Playwright tests passed.
91+
92+
## Playwright Result
93+
94+
- PASS: Targeted Assets Playwright suite passed 13/13.
95+
- PASS: `npm run test:workspace-v2` passed.
96+
97+
## V8 Coverage
98+
99+
- Coverage report: `docs_build/dev/reports/playwright_v8_coverage_report.txt`
100+
- PASS: `toolbox/assets/assets.js` collected browser V8 coverage: 93%.
101+
- WARN: `toolbox/assets/assets-upload-worker.js` is listed in the changed runtime JS coverage report, but Chromium page-level V8 coverage did not collect dedicated worker script coverage. Worker execution is still validated by Playwright worker-event assertions.
102+
- WARN: `src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js` appears from the stacked HEAD changed-file coverage baseline and is Node-side repository code not collected by Chromium page coverage.
103+
104+
## Manual Validation Steps
105+
106+
1. Open `/toolbox/assets/index.html?uploadProgressDelayMs=180&uploadChunkSizeBytes=8` in local DB mode.
107+
2. Reset Asset Library.
108+
3. Add Images, choose a usage, and select a file.
109+
4. Confirm inline upload progress starts at `0%`, then increments by bytes instead of jumping to `50%`.
110+
5. Confirm BPS, speed, ETA, elapsed, current file, and bytes uploaded update while the upload is running.
111+
6. Toggle another asset accordion during upload and confirm it remains responsive.
112+
7. Confirm successful write reaches `100%` and creates one asset record.
113+
8. Repeat with write support disabled and confirm FAIL appears, progress remains below `100%`, and no record is created.
114+
115+
## Samples Validation
116+
117+
- Full samples smoke: SKIP.
118+
- Reason: requested skip, and this PR is limited to Assets upload progress behavior.
‎docs_build/dev/reports/codex_changed_files.txt‎
Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,16 @@
11
# git status --short
2-
M docs_build/dev/reports/codex_changed_files.txt
3-
 M docs_build/dev/reports/codex_review.diff
4-
 M docs_build/dev/reports/playwright_v8_coverage_report.txt
5-
 M src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js
2+
M docs_build/dev/reports/playwright_v8_coverage_report.txt
63
 M tests/playwright/tools/AssetToolMockRepository.spec.mjs
74
 M toolbox/assets/assets.js
8-
?? docs_build/dev/reports/PR_26163_078-assets-inline-upload-progress.md
5+
?? docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md
6+
?? toolbox/assets/assets-upload-worker.js
97

108
# git ls-files --others --exclude-standard
11-
docs_build/dev/reports/PR_26163_078-assets-inline-upload-progress.md
9+
docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md
10+
toolbox/assets/assets-upload-worker.js
1211

1312
# git diff --stat
14-
docs_build/dev/reports/codex_changed_files.txt | 14 +-
15-
 docs_build/dev/reports/codex_review.diff | 1160 +++++++++++++-------
16-
 .../dev/reports/playwright_v8_coverage_report.txt | 6 +-
17-
 .../tool-repositories/assets-mock-repository.js | 198 +++-
18-
 .../tools/AssetToolMockRepository.spec.mjs | 61 +
19-
 toolbox/assets/assets.js | 177 ++-
20-
 6 files changed, 1162 insertions(+), 454 deletions(-)
13+
.../dev/reports/playwright_v8_coverage_report.txt | 11 +-
14+
 .../tools/AssetToolMockRepository.spec.mjs | 108 ++++++++++++++-
15+
 toolbox/assets/assets.js | 149 +++++++++++++++++----
16+
 3 files changed, 234 insertions(+), 34 deletions(-)
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit 0a032dc
Browse files
ToolboxAidToolboxAid
committed
Calculate Assets upload progress from file bytes without blocking the UI - PR_26163_079-assets-byte-accurate-upload-progress
1 parent 19a0289 commit 0a032dc
7 files changed
Lines changed: 1025 additions & 2047 deletions
File tree
‎docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md‎
Lines changed: 118 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,118 @@
1+
# PR_26163_079-assets-byte-accurate-upload-progress
2+
3+
## Branch Validation
4+
5+
- Current branch: `main`
6+
- Expected branch: `main`
7+
- Branch validation: PASS
8+
9+
## Requirement Checklist
10+
11+
- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before changes.
12+
- PASS: Continued from PR_26163_078.
13+
- PASS: Replaced staged upload progress with byte-based progress.
14+
- PASS: Progress bar percentage is calculated as `bytesUploaded / totalBytes`.
15+
- PASS: Upload file processing now runs through `toolbox/assets/assets-upload-worker.js`.
16+
- PASS: Dev/test throttled uploads update incrementally per worker chunk.
17+
- PASS: Progress starts at 0 before first bytes upload.
18+
- PASS: Progress does not jump to 50% on start.
19+
- PASS: Progress reaches 100 only after selected bytes are processed and repository write succeeds.
20+
- PASS: Failed write after byte transfer shows FAIL and creates no asset record.
21+
- PASS: Batch progress uses summed uploaded bytes divided by summed selected bytes.
22+
- PASS: Inline upload progress remains below each upload-capable asset table.
23+
- PASS: `/projects/` directory validation and create-if-missing behavior are preserved from PR_26163_078.
24+
- PASS: Duplicate same folder/filename blocking is preserved.
25+
- PASS: `codex_review.diff` is UTF-8 readable.
26+
- PASS: Full samples smoke was not run.
27+
28+
## Byte Progress Evidence
29+
30+
- Playwright test `Assets worker upload progress is byte accurate and keeps the UI responsive` validates:
31+
- progress value starts at `0`;
32+
- bytes uploaded starts at `0 B`;
33+
- first chunk progress is greater than `0`, less than `50`, and not equal to `50`;
34+
- later chunk progress is greater than the first chunk value;
35+
- final successful upload reaches `100`.
36+
- Playwright test `Assets batch progress uses summed uploaded bytes across selected files` validates two equal 20-byte files reach `50` after the first file succeeds, then `100` when both writes succeed.
37+
- Playwright test `Assets upload write failure after byte transfer is visible and creates no asset record` validates bytes progress becomes greater than `0`, remains below `100`, shows FAIL, and asset count stays `0`.
38+
39+
## UI Responsiveness Evidence
40+
41+
- During throttled worker upload, Playwright toggles the Audio accordion and verifies its `open` state changes.
42+
- During throttled worker upload, Playwright scrolls the page and verifies `window.scrollY > 0`.
43+
- Progress fields continue rendering while the UI remains interactive: BPS, speed, ETA, elapsed, current file, and per-file status are asserted during/after throttled upload.
44+
- No cancel/stop upload control exists in the current Assets UI; no cancel behavior was added in this PR.
45+
46+
## Worker / Background Execution Evidence
47+
48+
- New worker file: `toolbox/assets/assets-upload-worker.js`.
49+
- Assets page creates the worker with `new Worker(UPLOAD_WORKER_URL, { type: "module" })`.
50+
- Playwright waits for the `worker` event and asserts the worker URL contains `toolbox/assets/assets-upload-worker.js`.
51+
- Inline upload diagnostics expose worker status (`Active`, `Write Pending`, `Complete`, `Failed`) for validation.
52+
53+
## Throttled Upload Evidence
54+
55+
- Dev/test throttling remains query-parameter controlled through `uploadProgressDelayMs`.
56+
- Added dev/test chunk-size control through `uploadChunkSizeBytes`.
57+
- Targeted tests use throttled uploads with small chunks to validate incremental progress without affecting production uploads.
58+
59+
## Changed Files
60+
61+
-`toolbox/assets/assets.js`
62+
-`toolbox/assets/assets-upload-worker.js`
63+
-`tests/playwright/tools/AssetToolMockRepository.spec.mjs`
64+
-`docs_build/dev/reports/playwright_v8_coverage_report.txt`
65+
-`docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md`
66+
-`docs_build/dev/reports/codex_review.diff`
67+
-`docs_build/dev/reports/codex_changed_files.txt`
68+
69+
## Impacted Lanes
70+
71+
- runtime: Assets upload UI progress and worker-backed file processing.
72+
- integration: Assets upload path through server/mock repository remains exercised by Playwright.
73+
- recovery/UAT: targeted Assets Playwright coverage for throttled upload behavior and failure behavior.
74+
75+
## Skipped Lanes
76+
77+
- samples: SKIP. This PR is scoped to Toolbox Assets upload progress and does not change sample runtime contracts.
78+
- engine: SKIP. No engine input/render/game runtime files changed.
79+
80+
## Validation Performed
81+
82+
- PASS: `node --check toolbox/assets/assets.js`
83+
- PASS: `node --check toolbox/assets/assets-upload-worker.js`
84+
- PASS: `node --check tests/playwright/tools/AssetToolMockRepository.spec.mjs`
85+
- PASS: `git diff --check -- toolbox/assets/assets.js toolbox/assets/assets-upload-worker.js tests/playwright/tools/AssetToolMockRepository.spec.mjs`
86+
- PASS: `git diff --check -- .`
87+
- PASS: `npx playwright test tests/playwright/tools/AssetToolMockRepository.spec.mjs --workers=1 --reporter=list`
88+
- Result: 13 passed.
89+
- PASS: `npm run test:workspace-v2`
90+
- Result: workspace-contract lane passed, 5 Playwright tests passed.
91+
92+
## Playwright Result
93+
94+
- PASS: Targeted Assets Playwright suite passed 13/13.
95+
- PASS: `npm run test:workspace-v2` passed.
96+
97+
## V8 Coverage
98+
99+
- Coverage report: `docs_build/dev/reports/playwright_v8_coverage_report.txt`
100+
- PASS: `toolbox/assets/assets.js` collected browser V8 coverage: 93%.
101+
- WARN: `toolbox/assets/assets-upload-worker.js` is listed in the changed runtime JS coverage report, but Chromium page-level V8 coverage did not collect dedicated worker script coverage. Worker execution is still validated by Playwright worker-event assertions.
102+
- WARN: `src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js` appears from the stacked HEAD changed-file coverage baseline and is Node-side repository code not collected by Chromium page coverage.
103+
104+
## Manual Validation Steps
105+
106+
1. Open `/toolbox/assets/index.html?uploadProgressDelayMs=180&uploadChunkSizeBytes=8` in local DB mode.
107+
2. Reset Asset Library.
108+
3. Add Images, choose a usage, and select a file.
109+
4. Confirm inline upload progress starts at `0%`, then increments by bytes instead of jumping to `50%`.
110+
5. Confirm BPS, speed, ETA, elapsed, current file, and bytes uploaded update while the upload is running.
111+
6. Toggle another asset accordion during upload and confirm it remains responsive.
112+
7. Confirm successful write reaches `100%` and creates one asset record.
113+
8. Repeat with write support disabled and confirm FAIL appears, progress remains below `100%`, and no record is created.
114+
115+
## Samples Validation
116+
117+
- Full samples smoke: SKIP.
118+
- Reason: requested skip, and this PR is limited to Assets upload progress behavior.
‎docs_build/dev/reports/codex_changed_files.txt‎
Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,16 @@
11
# git status --short
2-
M docs_build/dev/reports/codex_changed_files.txt
3-
 M docs_build/dev/reports/codex_review.diff
4-
 M docs_build/dev/reports/playwright_v8_coverage_report.txt
5-
 M src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js
2+
M docs_build/dev/reports/playwright_v8_coverage_report.txt
63
 M tests/playwright/tools/AssetToolMockRepository.spec.mjs
74
 M toolbox/assets/assets.js
8-
?? docs_build/dev/reports/PR_26163_078-assets-inline-upload-progress.md
5+
?? docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md
6+
?? toolbox/assets/assets-upload-worker.js
97

108
# git ls-files --others --exclude-standard
11-
docs_build/dev/reports/PR_26163_078-assets-inline-upload-progress.md
9+
docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md
10+
toolbox/assets/assets-upload-worker.js
1211

1312
# git diff --stat
14-
docs_build/dev/reports/codex_changed_files.txt | 14 +-
15-
 docs_build/dev/reports/codex_review.diff | 1160 +++++++++++++-------
16-
 .../dev/reports/playwright_v8_coverage_report.txt | 6 +-
17-
 .../tool-repositories/assets-mock-repository.js | 198 +++-
18-
 .../tools/AssetToolMockRepository.spec.mjs | 61 +
19-
 toolbox/assets/assets.js | 177 ++-
20-
 6 files changed, 1162 insertions(+), 454 deletions(-)
13+
.../dev/reports/playwright_v8_coverage_report.txt | 11 +-
14+
 .../tools/AssetToolMockRepository.spec.mjs | 108 ++++++++++++++-
15+
 toolbox/assets/assets.js | 149 +++++++++++++++++----
16+
 3 files changed, 234 insertions(+), 34 deletions(-)
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit 0a032dc
Browse files
ToolboxAidToolboxAid
committed
Calculate Assets upload progress from file bytes without blocking the UI - PR_26163_079-assets-byte-accurate-upload-progress
1 parent 19a0289 commit 0a032dc
7 files changed
Lines changed: 1025 additions & 2047 deletions
File tree
‎docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md‎
Lines changed: 118 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,118 @@
1+
# PR_26163_079-assets-byte-accurate-upload-progress
2+
3+
## Branch Validation
4+
5+
- Current branch: `main`
6+
- Expected branch: `main`
7+
- Branch validation: PASS
8+
9+
## Requirement Checklist
10+
11+
- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before changes.
12+
- PASS: Continued from PR_26163_078.
13+
- PASS: Replaced staged upload progress with byte-based progress.
14+
- PASS: Progress bar percentage is calculated as `bytesUploaded / totalBytes`.
15+
- PASS: Upload file processing now runs through `toolbox/assets/assets-upload-worker.js`.
16+
- PASS: Dev/test throttled uploads update incrementally per worker chunk.
17+
- PASS: Progress starts at 0 before first bytes upload.
18+
- PASS: Progress does not jump to 50% on start.
19+
- PASS: Progress reaches 100 only after selected bytes are processed and repository write succeeds.
20+
- PASS: Failed write after byte transfer shows FAIL and creates no asset record.
21+
- PASS: Batch progress uses summed uploaded bytes divided by summed selected bytes.
22+
- PASS: Inline upload progress remains below each upload-capable asset table.
23+
- PASS: `/projects/` directory validation and create-if-missing behavior are preserved from PR_26163_078.
24+
- PASS: Duplicate same folder/filename blocking is preserved.
25+
- PASS: `codex_review.diff` is UTF-8 readable.
26+
- PASS: Full samples smoke was not run.
27+
28+
## Byte Progress Evidence
29+
30+
- Playwright test `Assets worker upload progress is byte accurate and keeps the UI responsive` validates:
31+
- progress value starts at `0`;
32+
- bytes uploaded starts at `0 B`;
33+
- first chunk progress is greater than `0`, less than `50`, and not equal to `50`;
34+
- later chunk progress is greater than the first chunk value;
35+
- final successful upload reaches `100`.
36+
- Playwright test `Assets batch progress uses summed uploaded bytes across selected files` validates two equal 20-byte files reach `50` after the first file succeeds, then `100` when both writes succeed.
37+
- Playwright test `Assets upload write failure after byte transfer is visible and creates no asset record` validates bytes progress becomes greater than `0`, remains below `100`, shows FAIL, and asset count stays `0`.
38+
39+
## UI Responsiveness Evidence
40+
41+
- During throttled worker upload, Playwright toggles the Audio accordion and verifies its `open` state changes.
42+
- During throttled worker upload, Playwright scrolls the page and verifies `window.scrollY > 0`.
43+
- Progress fields continue rendering while the UI remains interactive: BPS, speed, ETA, elapsed, current file, and per-file status are asserted during/after throttled upload.
44+
- No cancel/stop upload control exists in the current Assets UI; no cancel behavior was added in this PR.
45+
46+
## Worker / Background Execution Evidence
47+
48+
- New worker file: `toolbox/assets/assets-upload-worker.js`.
49+
- Assets page creates the worker with `new Worker(UPLOAD_WORKER_URL, { type: "module" })`.
50+
- Playwright waits for the `worker` event and asserts the worker URL contains `toolbox/assets/assets-upload-worker.js`.
51+
- Inline upload diagnostics expose worker status (`Active`, `Write Pending`, `Complete`, `Failed`) for validation.
52+
53+
## Throttled Upload Evidence
54+
55+
- Dev/test throttling remains query-parameter controlled through `uploadProgressDelayMs`.
56+
- Added dev/test chunk-size control through `uploadChunkSizeBytes`.
57+
- Targeted tests use throttled uploads with small chunks to validate incremental progress without affecting production uploads.
58+
59+
## Changed Files
60+
61+
-`toolbox/assets/assets.js`
62+
-`toolbox/assets/assets-upload-worker.js`
63+
-`tests/playwright/tools/AssetToolMockRepository.spec.mjs`
64+
-`docs_build/dev/reports/playwright_v8_coverage_report.txt`
65+
-`docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md`
66+
-`docs_build/dev/reports/codex_review.diff`
67+
-`docs_build/dev/reports/codex_changed_files.txt`
68+
69+
## Impacted Lanes
70+
71+
- runtime: Assets upload UI progress and worker-backed file processing.
72+
- integration: Assets upload path through server/mock repository remains exercised by Playwright.
73+
- recovery/UAT: targeted Assets Playwright coverage for throttled upload behavior and failure behavior.
74+
75+
## Skipped Lanes
76+
77+
- samples: SKIP. This PR is scoped to Toolbox Assets upload progress and does not change sample runtime contracts.
78+
- engine: SKIP. No engine input/render/game runtime files changed.
79+
80+
## Validation Performed
81+
82+
- PASS: `node --check toolbox/assets/assets.js`
83+
- PASS: `node --check toolbox/assets/assets-upload-worker.js`
84+
- PASS: `node --check tests/playwright/tools/AssetToolMockRepository.spec.mjs`
85+
- PASS: `git diff --check -- toolbox/assets/assets.js toolbox/assets/assets-upload-worker.js tests/playwright/tools/AssetToolMockRepository.spec.mjs`
86+
- PASS: `git diff --check -- .`
87+
- PASS: `npx playwright test tests/playwright/tools/AssetToolMockRepository.spec.mjs --workers=1 --reporter=list`
88+
- Result: 13 passed.
89+
- PASS: `npm run test:workspace-v2`
90+
- Result: workspace-contract lane passed, 5 Playwright tests passed.
91+
92+
## Playwright Result
93+
94+
- PASS: Targeted Assets Playwright suite passed 13/13.
95+
- PASS: `npm run test:workspace-v2` passed.
96+
97+
## V8 Coverage
98+
99+
- Coverage report: `docs_build/dev/reports/playwright_v8_coverage_report.txt`
100+
- PASS: `toolbox/assets/assets.js` collected browser V8 coverage: 93%.
101+
- WARN: `toolbox/assets/assets-upload-worker.js` is listed in the changed runtime JS coverage report, but Chromium page-level V8 coverage did not collect dedicated worker script coverage. Worker execution is still validated by Playwright worker-event assertions.
102+
- WARN: `src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js` appears from the stacked HEAD changed-file coverage baseline and is Node-side repository code not collected by Chromium page coverage.
103+
104+
## Manual Validation Steps
105+
106+
1. Open `/toolbox/assets/index.html?uploadProgressDelayMs=180&uploadChunkSizeBytes=8` in local DB mode.
107+
2. Reset Asset Library.
108+
3. Add Images, choose a usage, and select a file.
109+
4. Confirm inline upload progress starts at `0%`, then increments by bytes instead of jumping to `50%`.
110+
5. Confirm BPS, speed, ETA, elapsed, current file, and bytes uploaded update while the upload is running.
111+
6. Toggle another asset accordion during upload and confirm it remains responsive.
112+
7. Confirm successful write reaches `100%` and creates one asset record.
113+
8. Repeat with write support disabled and confirm FAIL appears, progress remains below `100%`, and no record is created.
114+
115+
## Samples Validation
116+
117+
- Full samples smoke: SKIP.
118+
- Reason: requested skip, and this PR is limited to Assets upload progress behavior.
‎docs_build/dev/reports/codex_changed_files.txt‎
Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,16 @@
11
# git status --short
2-
M docs_build/dev/reports/codex_changed_files.txt
3-
 M docs_build/dev/reports/codex_review.diff
4-
 M docs_build/dev/reports/playwright_v8_coverage_report.txt
5-
 M src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js
2+
M docs_build/dev/reports/playwright_v8_coverage_report.txt
63
 M tests/playwright/tools/AssetToolMockRepository.spec.mjs
74
 M toolbox/assets/assets.js
8-
?? docs_build/dev/reports/PR_26163_078-assets-inline-upload-progress.md
5+
?? docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md
6+
?? toolbox/assets/assets-upload-worker.js
97

108
# git ls-files --others --exclude-standard
11-
docs_build/dev/reports/PR_26163_078-assets-inline-upload-progress.md
9+
docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md
10+
toolbox/assets/assets-upload-worker.js
1211

1312
# git diff --stat
14-
docs_build/dev/reports/codex_changed_files.txt | 14 +-
15-
 docs_build/dev/reports/codex_review.diff | 1160 +++++++++++++-------
16-
 .../dev/reports/playwright_v8_coverage_report.txt | 6 +-
17-
 .../tool-repositories/assets-mock-repository.js | 198 +++-
18-
 .../tools/AssetToolMockRepository.spec.mjs | 61 +
19-
 toolbox/assets/assets.js | 177 ++-
20-
 6 files changed, 1162 insertions(+), 454 deletions(-)
13+
.../dev/reports/playwright_v8_coverage_report.txt | 11 +-
14+
 .../tools/AssetToolMockRepository.spec.mjs | 108 ++++++++++++++-
15+
 toolbox/assets/assets.js | 149 +++++++++++++++++----
16+
 3 files changed, 234 insertions(+), 34 deletions(-)
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Commit 0a032dc
Browse files
ToolboxAidToolboxAid
committed
Calculate Assets upload progress from file bytes without blocking the UI - PR_26163_079-assets-byte-accurate-upload-progress
1 parent 19a0289 commit 0a032dc
7 files changed
Lines changed: 1025 additions & 2047 deletions
File tree
‎docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md‎
Lines changed: 118 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,118 @@
1+
# PR_26163_079-assets-byte-accurate-upload-progress
2+
3+
## Branch Validation
4+
5+
- Current branch: `main`
6+
- Expected branch: `main`
7+
- Branch validation: PASS
8+
9+
## Requirement Checklist
10+
11+
- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before changes.
12+
- PASS: Continued from PR_26163_078.
13+
- PASS: Replaced staged upload progress with byte-based progress.
14+
- PASS: Progress bar percentage is calculated as `bytesUploaded / totalBytes`.
15+
- PASS: Upload file processing now runs through `toolbox/assets/assets-upload-worker.js`.
16+
- PASS: Dev/test throttled uploads update incrementally per worker chunk.
17+
- PASS: Progress starts at 0 before first bytes upload.
18+
- PASS: Progress does not jump to 50% on start.
19+
- PASS: Progress reaches 100 only after selected bytes are processed and repository write succeeds.
20+
- PASS: Failed write after byte transfer shows FAIL and creates no asset record.
21+
- PASS: Batch progress uses summed uploaded bytes divided by summed selected bytes.
22+
- PASS: Inline upload progress remains below each upload-capable asset table.
23+
- PASS: `/projects/` directory validation and create-if-missing behavior are preserved from PR_26163_078.
24+
- PASS: Duplicate same folder/filename blocking is preserved.
25+
- PASS: `codex_review.diff` is UTF-8 readable.
26+
- PASS: Full samples smoke was not run.
27+
28+
## Byte Progress Evidence
29+
30+
- Playwright test `Assets worker upload progress is byte accurate and keeps the UI responsive` validates:
31+
- progress value starts at `0`;
32+
- bytes uploaded starts at `0 B`;
33+
- first chunk progress is greater than `0`, less than `50`, and not equal to `50`;
34+
- later chunk progress is greater than the first chunk value;
35+
- final successful upload reaches `100`.
36+
- Playwright test `Assets batch progress uses summed uploaded bytes across selected files` validates two equal 20-byte files reach `50` after the first file succeeds, then `100` when both writes succeed.
37+
- Playwright test `Assets upload write failure after byte transfer is visible and creates no asset record` validates bytes progress becomes greater than `0`, remains below `100`, shows FAIL, and asset count stays `0`.
38+
39+
## UI Responsiveness Evidence
40+
41+
- During throttled worker upload, Playwright toggles the Audio accordion and verifies its `open` state changes.
42+
- During throttled worker upload, Playwright scrolls the page and verifies `window.scrollY > 0`.
43+
- Progress fields continue rendering while the UI remains interactive: BPS, speed, ETA, elapsed, current file, and per-file status are asserted during/after throttled upload.
44+
- No cancel/stop upload control exists in the current Assets UI; no cancel behavior was added in this PR.
45+
46+
## Worker / Background Execution Evidence
47+
48+
- New worker file: `toolbox/assets/assets-upload-worker.js`.
49+
- Assets page creates the worker with `new Worker(UPLOAD_WORKER_URL, { type: "module" })`.
50+
- Playwright waits for the `worker` event and asserts the worker URL contains `toolbox/assets/assets-upload-worker.js`.
51+
- Inline upload diagnostics expose worker status (`Active`, `Write Pending`, `Complete`, `Failed`) for validation.
52+
53+
## Throttled Upload Evidence
54+
55+
- Dev/test throttling remains query-parameter controlled through `uploadProgressDelayMs`.
56+
- Added dev/test chunk-size control through `uploadChunkSizeBytes`.
57+
- Targeted tests use throttled uploads with small chunks to validate incremental progress without affecting production uploads.
58+
59+
## Changed Files
60+
61+
-`toolbox/assets/assets.js`
62+
-`toolbox/assets/assets-upload-worker.js`
63+
-`tests/playwright/tools/AssetToolMockRepository.spec.mjs`
64+
-`docs_build/dev/reports/playwright_v8_coverage_report.txt`
65+
-`docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md`
66+
-`docs_build/dev/reports/codex_review.diff`
67+
-`docs_build/dev/reports/codex_changed_files.txt`
68+
69+
## Impacted Lanes
70+
71+
- runtime: Assets upload UI progress and worker-backed file processing.
72+
- integration: Assets upload path through server/mock repository remains exercised by Playwright.
73+
- recovery/UAT: targeted Assets Playwright coverage for throttled upload behavior and failure behavior.
74+
75+
## Skipped Lanes
76+
77+
- samples: SKIP. This PR is scoped to Toolbox Assets upload progress and does not change sample runtime contracts.
78+
- engine: SKIP. No engine input/render/game runtime files changed.
79+
80+
## Validation Performed
81+
82+
- PASS: `node --check toolbox/assets/assets.js`
83+
- PASS: `node --check toolbox/assets/assets-upload-worker.js`
84+
- PASS: `node --check tests/playwright/tools/AssetToolMockRepository.spec.mjs`
85+
- PASS: `git diff --check -- toolbox/assets/assets.js toolbox/assets/assets-upload-worker.js tests/playwright/tools/AssetToolMockRepository.spec.mjs`
86+
- PASS: `git diff --check -- .`
87+
- PASS: `npx playwright test tests/playwright/tools/AssetToolMockRepository.spec.mjs --workers=1 --reporter=list`
88+
- Result: 13 passed.
89+
- PASS: `npm run test:workspace-v2`
90+
- Result: workspace-contract lane passed, 5 Playwright tests passed.
91+
92+
## Playwright Result
93+
94+
- PASS: Targeted Assets Playwright suite passed 13/13.
95+
- PASS: `npm run test:workspace-v2` passed.
96+
97+
## V8 Coverage
98+
99+
- Coverage report: `docs_build/dev/reports/playwright_v8_coverage_report.txt`
100+
- PASS: `toolbox/assets/assets.js` collected browser V8 coverage: 93%.
101+
- WARN: `toolbox/assets/assets-upload-worker.js` is listed in the changed runtime JS coverage report, but Chromium page-level V8 coverage did not collect dedicated worker script coverage. Worker execution is still validated by Playwright worker-event assertions.
102+
- WARN: `src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js` appears from the stacked HEAD changed-file coverage baseline and is Node-side repository code not collected by Chromium page coverage.
103+
104+
## Manual Validation Steps
105+
106+
1. Open `/toolbox/assets/index.html?uploadProgressDelayMs=180&uploadChunkSizeBytes=8` in local DB mode.
107+
2. Reset Asset Library.
108+
3. Add Images, choose a usage, and select a file.
109+
4. Confirm inline upload progress starts at `0%`, then increments by bytes instead of jumping to `50%`.
110+
5. Confirm BPS, speed, ETA, elapsed, current file, and bytes uploaded update while the upload is running.
111+
6. Toggle another asset accordion during upload and confirm it remains responsive.
112+
7. Confirm successful write reaches `100%` and creates one asset record.
113+
8. Repeat with write support disabled and confirm FAIL appears, progress remains below `100%`, and no record is created.
114+
115+
## Samples Validation
116+
117+
- Full samples smoke: SKIP.
118+
- Reason: requested skip, and this PR is limited to Assets upload progress behavior.
‎docs_build/dev/reports/codex_changed_files.txt‎
Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,16 @@
11
# git status --short
2-
M docs_build/dev/reports/codex_changed_files.txt
3-
 M docs_build/dev/reports/codex_review.diff
4-
 M docs_build/dev/reports/playwright_v8_coverage_report.txt
5-
 M src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js
2+
M docs_build/dev/reports/playwright_v8_coverage_report.txt
63
 M tests/playwright/tools/AssetToolMockRepository.spec.mjs
74
 M toolbox/assets/assets.js
8-
?? docs_build/dev/reports/PR_26163_078-assets-inline-upload-progress.md
5+
?? docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md
6+
?? toolbox/assets/assets-upload-worker.js
97

108
# git ls-files --others --exclude-standard
11-
docs_build/dev/reports/PR_26163_078-assets-inline-upload-progress.md
9+
docs_build/dev/reports/PR_26163_079-assets-byte-accurate-upload-progress.md
10+
toolbox/assets/assets-upload-worker.js
1211

1312
# git diff --stat
14-
docs_build/dev/reports/codex_changed_files.txt | 14 +-
15-
 docs_build/dev/reports/codex_review.diff | 1160 +++++++++++++-------
16-
 .../dev/reports/playwright_v8_coverage_report.txt | 6 +-
17-
 .../tool-repositories/assets-mock-repository.js | 198 +++-
18-
 .../tools/AssetToolMockRepository.spec.mjs | 61 +
19-
 toolbox/assets/assets.js | 177 ++-
20-
 6 files changed, 1162 insertions(+), 454 deletions(-)
13+
.../dev/reports/playwright_v8_coverage_report.txt | 11 +-
14+
 .../tools/AssetToolMockRepository.spec.mjs | 108 ++++++++++++++-
15+
 toolbox/assets/assets.js | 149 +++++++++++++++++----
16+
 3 files changed, 234 insertions(+), 34 deletions(-)
0 commit comments
Comments
 (0)