Commit 892e469

Browse files
committed
Simplify Workspace V2 Playwright gate to use installed dependencies only - PR_11_320
1 parent 35c3772 commit 892e469

7 files changed

Lines changed: 85 additions & 6 deletions

File tree

‎docs/dev/codex_commands.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,3 +215,10 @@ PR_11_319
215215
```bash
216216
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_319: Add required Workspace V2 Playwright gate command with explicit pass/fail summary and non-zero failure handling."
217217
```
218+
219+
---
220+
PR_11_320
221+
222+
```bash
223+
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_320: Update Workspace V2 Playwright gate to execute installed Playwright command path only, preserving fail-fast and summary output."
224+
```

‎docs/dev/commit_comment.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Promote Workspace V2 Playwright validation into required gate script with explicit non-zero failure handling - PR 11.319
1+
Update Workspace V2 Playwright gate to use installed command path while preserving fail-fast summary behavior - PR 11.320
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
# PR_11_320 Report
2+
3+
## Purpose
4+
Update Workspace V2 Playwright gate execution for installed Playwright command usage without install/bootstrap behaviors.
5+
6+
## Files Changed
7+
-`package.json`
8+
-`scripts/run-workspace-v2-playwright-gate.mjs`
9+
-`docs/pr/PR_11_320_WORKSPACE_V2_GATE_UPDATE/PLAN_PR.md`
10+
-`docs/pr/PR_11_320_WORKSPACE_V2_GATE_UPDATE/BUILD_PR.md`
11+
-`docs/dev/reports/PR_11_320_report.md`
12+
-`docs/dev/codex_commands.md`
13+
-`docs/dev/commit_comment.txt`
14+
15+
## Implementation Summary
16+
- Added explicit installed Playwright command script:
17+
-`npm run test:workspace-v2:playwright`
18+
- Kept gate command:
19+
-`npm run test:workspace-v2`
20+
- Gate runner now executes installed command path through Node/npm CLI path and preserves:
21+
- fail-fast non-zero exit on any failure
22+
- clear summary output:
23+
-`Workspace V2 Playwright Gate Summary: passed=<n> failed=<n>`
24+
- Existing results/report behavior remains under `tests/results/**` from prior Playwright config.
25+
26+
## Validation Commands
27+
-`node -e "const fs=require('fs'); JSON.parse(fs.readFileSync('package.json','utf8')); console.log('package.json parse: PASS');"` -> **PASS**
28+
-`node --check scripts/run-workspace-v2-playwright-gate.mjs` -> **PASS**
29+
-`npm run test:workspace-v2` -> **PASS**
30+
31+
## Notes
32+
- No test logic changes.
33+
- No runtime/schema/tool behavior changes.
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# BUILD_PR_11_320
2+
3+
## Implementation
4+
- Updated `package.json` scripts:
5+
- added `test:workspace-v2:playwright`:
6+
-`playwright test tests/ui/workspace-v2.asset-manager.spec.js`
7+
- kept `test:workspace-v2` gate entry:
8+
-`node ./scripts/run-workspace-v2-playwright-gate.mjs`
9+
- Updated `scripts/run-workspace-v2-playwright-gate.mjs`:
10+
- executes installed Playwright command path via Node:
11+
- preferred: `process.execPath + process.env.npm_execpath run --silent test:workspace-v2:playwright`
12+
- fallback: local Playwright CLI path under `node_modules`
13+
- preserves:
14+
- streamed output
15+
- clear gate summary
16+
- non-zero exit on any failure condition
17+
18+
## Validation
19+
-`node -e "const fs=require('fs'); JSON.parse(fs.readFileSync('package.json','utf8')); console.log('package.json parse: PASS');"`
20+
-`node --check scripts/run-workspace-v2-playwright-gate.mjs`
21+
-`npm run test:workspace-v2`
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# PLAN_PR_11_320
2+
3+
## Purpose
4+
Update the Workspace V2 Playwright gate script to run the installed Playwright command path only, without install/bootstrap behaviors.
5+
6+
## Scope
7+
-`package.json`
8+
-`scripts/run-workspace-v2-playwright-gate.mjs`
9+
-`docs/dev/reports/PR_11_320_report.md`
10+
-`docs/dev/codex_commands.md`
11+
-`docs/dev/commit_comment.txt`
12+
13+
## Steps
14+
1. Add an explicit script for the installed Playwright command path.
15+
2. Update gate runner to execute that command through Node/npm CLI path (no install/bootstrap).
16+
3. Preserve fail-fast non-zero exit and pass/fail summary output.
17+
4. Keep results/report behavior under `tests/results/**` via existing Playwright config.
18+
5. Run required parse/syntax/test validations.

‎package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
"check:phase24-closeout-guard": "node tools/dev/checkPhase24CloseoutExecutionGuard.mjs",
1212
"check:style-system-guard": "node tools/dev/checkStyleSystemGuard.mjs",
1313
"check:games-template-contract": "node ./scripts/validate-games-template-contract.mjs",
14+
"test:workspace-v2:playwright": "playwright test tests/ui/workspace-v2.asset-manager.spec.js",
1415
"test:workspace-v2": "node ./scripts/run-workspace-v2-playwright-gate.mjs",
1516
"test:launch-smoke": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs",
1617
"test:launch-smoke:games": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --games",

‎scripts/run-workspace-v2-playwright-gate.mjs‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@ import { fileURLToPath } from "node:url";
1111
const__filename=fileURLToPath(import.meta.url);
1212
const__dirname=path.dirname(__filename);
1313
constrepoRoot=path.resolve(__dirname,"..");
14+
constnpmExecPath=typeofprocess.env.npm_execpath==="string" ? process.env.npm_execpath.trim() : "";
1415
constcommand=process.execPath;
15-
constargs=[
16-
path.join(repoRoot,"node_modules","@playwright","test","cli.js"),
17-
"test",
18-
"tests/ui/workspace-v2.asset-manager.spec.js"
19-
];
16+
constargs=npmExecPath
17+
? [npmExecPath,"run","--silent","test:workspace-v2:playwright"]
18+
: [path.join(repoRoot,"node_modules","@playwright","test","cli.js"),"test","tests/ui/workspace-v2.asset-manager.spec.js"];
2019

2120
constresult=spawnSync(command,args,{
2221
cwd: repoRoot,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Commit 892e469

Browse files
committed
Simplify Workspace V2 Playwright gate to use installed dependencies only - PR_11_320
1 parent 35c3772 commit 892e469

7 files changed

Lines changed: 85 additions & 6 deletions

File tree

‎docs/dev/codex_commands.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,3 +215,10 @@ PR_11_319
215215
```bash
216216
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_319: Add required Workspace V2 Playwright gate command with explicit pass/fail summary and non-zero failure handling."
217217
```
218+
219+
---
220+
PR_11_320
221+
222+
```bash
223+
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_320: Update Workspace V2 Playwright gate to execute installed Playwright command path only, preserving fail-fast and summary output."
224+
```

‎docs/dev/commit_comment.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Promote Workspace V2 Playwright validation into required gate script with explicit non-zero failure handling - PR 11.319
1+
Update Workspace V2 Playwright gate to use installed command path while preserving fail-fast summary behavior - PR 11.320
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
# PR_11_320 Report
2+
3+
## Purpose
4+
Update Workspace V2 Playwright gate execution for installed Playwright command usage without install/bootstrap behaviors.
5+
6+
## Files Changed
7+
-`package.json`
8+
-`scripts/run-workspace-v2-playwright-gate.mjs`
9+
-`docs/pr/PR_11_320_WORKSPACE_V2_GATE_UPDATE/PLAN_PR.md`
10+
-`docs/pr/PR_11_320_WORKSPACE_V2_GATE_UPDATE/BUILD_PR.md`
11+
-`docs/dev/reports/PR_11_320_report.md`
12+
-`docs/dev/codex_commands.md`
13+
-`docs/dev/commit_comment.txt`
14+
15+
## Implementation Summary
16+
- Added explicit installed Playwright command script:
17+
-`npm run test:workspace-v2:playwright`
18+
- Kept gate command:
19+
-`npm run test:workspace-v2`
20+
- Gate runner now executes installed command path through Node/npm CLI path and preserves:
21+
- fail-fast non-zero exit on any failure
22+
- clear summary output:
23+
-`Workspace V2 Playwright Gate Summary: passed=<n> failed=<n>`
24+
- Existing results/report behavior remains under `tests/results/**` from prior Playwright config.
25+
26+
## Validation Commands
27+
-`node -e "const fs=require('fs'); JSON.parse(fs.readFileSync('package.json','utf8')); console.log('package.json parse: PASS');"` -> **PASS**
28+
-`node --check scripts/run-workspace-v2-playwright-gate.mjs` -> **PASS**
29+
-`npm run test:workspace-v2` -> **PASS**
30+
31+
## Notes
32+
- No test logic changes.
33+
- No runtime/schema/tool behavior changes.
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# BUILD_PR_11_320
2+
3+
## Implementation
4+
- Updated `package.json` scripts:
5+
- added `test:workspace-v2:playwright`:
6+
-`playwright test tests/ui/workspace-v2.asset-manager.spec.js`
7+
- kept `test:workspace-v2` gate entry:
8+
-`node ./scripts/run-workspace-v2-playwright-gate.mjs`
9+
- Updated `scripts/run-workspace-v2-playwright-gate.mjs`:
10+
- executes installed Playwright command path via Node:
11+
- preferred: `process.execPath + process.env.npm_execpath run --silent test:workspace-v2:playwright`
12+
- fallback: local Playwright CLI path under `node_modules`
13+
- preserves:
14+
- streamed output
15+
- clear gate summary
16+
- non-zero exit on any failure condition
17+
18+
## Validation
19+
-`node -e "const fs=require('fs'); JSON.parse(fs.readFileSync('package.json','utf8')); console.log('package.json parse: PASS');"`
20+
-`node --check scripts/run-workspace-v2-playwright-gate.mjs`
21+
-`npm run test:workspace-v2`
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# PLAN_PR_11_320
2+
3+
## Purpose
4+
Update the Workspace V2 Playwright gate script to run the installed Playwright command path only, without install/bootstrap behaviors.
5+
6+
## Scope
7+
-`package.json`
8+
-`scripts/run-workspace-v2-playwright-gate.mjs`
9+
-`docs/dev/reports/PR_11_320_report.md`
10+
-`docs/dev/codex_commands.md`
11+
-`docs/dev/commit_comment.txt`
12+
13+
## Steps
14+
1. Add an explicit script for the installed Playwright command path.
15+
2. Update gate runner to execute that command through Node/npm CLI path (no install/bootstrap).
16+
3. Preserve fail-fast non-zero exit and pass/fail summary output.
17+
4. Keep results/report behavior under `tests/results/**` via existing Playwright config.
18+
5. Run required parse/syntax/test validations.

‎package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
"check:phase24-closeout-guard": "node tools/dev/checkPhase24CloseoutExecutionGuard.mjs",
1212
"check:style-system-guard": "node tools/dev/checkStyleSystemGuard.mjs",
1313
"check:games-template-contract": "node ./scripts/validate-games-template-contract.mjs",
14+
"test:workspace-v2:playwright": "playwright test tests/ui/workspace-v2.asset-manager.spec.js",
1415
"test:workspace-v2": "node ./scripts/run-workspace-v2-playwright-gate.mjs",
1516
"test:launch-smoke": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs",
1617
"test:launch-smoke:games": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --games",

‎scripts/run-workspace-v2-playwright-gate.mjs‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@ import { fileURLToPath } from "node:url";
1111
const__filename=fileURLToPath(import.meta.url);
1212
const__dirname=path.dirname(__filename);
1313
constrepoRoot=path.resolve(__dirname,"..");
14+
constnpmExecPath=typeofprocess.env.npm_execpath==="string" ? process.env.npm_execpath.trim() : "";
1415
constcommand=process.execPath;
15-
constargs=[
16-
path.join(repoRoot,"node_modules","@playwright","test","cli.js"),
17-
"test",
18-
"tests/ui/workspace-v2.asset-manager.spec.js"
19-
];
16+
constargs=npmExecPath
17+
? [npmExecPath,"run","--silent","test:workspace-v2:playwright"]
18+
: [path.join(repoRoot,"node_modules","@playwright","test","cli.js"),"test","tests/ui/workspace-v2.asset-manager.spec.js"];
2019

2120
constresult=spawnSync(command,args,{
2221
cwd: repoRoot,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 892e469

Browse files
committed
Simplify Workspace V2 Playwright gate to use installed dependencies only - PR_11_320
1 parent 35c3772 commit 892e469

7 files changed

Lines changed: 85 additions & 6 deletions

File tree

‎docs/dev/codex_commands.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,3 +215,10 @@ PR_11_319
215215
```bash
216216
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_319: Add required Workspace V2 Playwright gate command with explicit pass/fail summary and non-zero failure handling."
217217
```
218+
219+
---
220+
PR_11_320
221+
222+
```bash
223+
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_320: Update Workspace V2 Playwright gate to execute installed Playwright command path only, preserving fail-fast and summary output."
224+
```

‎docs/dev/commit_comment.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Promote Workspace V2 Playwright validation into required gate script with explicit non-zero failure handling - PR 11.319
1+
Update Workspace V2 Playwright gate to use installed command path while preserving fail-fast summary behavior - PR 11.320
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
# PR_11_320 Report
2+
3+
## Purpose
4+
Update Workspace V2 Playwright gate execution for installed Playwright command usage without install/bootstrap behaviors.
5+
6+
## Files Changed
7+
-`package.json`
8+
-`scripts/run-workspace-v2-playwright-gate.mjs`
9+
-`docs/pr/PR_11_320_WORKSPACE_V2_GATE_UPDATE/PLAN_PR.md`
10+
-`docs/pr/PR_11_320_WORKSPACE_V2_GATE_UPDATE/BUILD_PR.md`
11+
-`docs/dev/reports/PR_11_320_report.md`
12+
-`docs/dev/codex_commands.md`
13+
-`docs/dev/commit_comment.txt`
14+
15+
## Implementation Summary
16+
- Added explicit installed Playwright command script:
17+
-`npm run test:workspace-v2:playwright`
18+
- Kept gate command:
19+
-`npm run test:workspace-v2`
20+
- Gate runner now executes installed command path through Node/npm CLI path and preserves:
21+
- fail-fast non-zero exit on any failure
22+
- clear summary output:
23+
-`Workspace V2 Playwright Gate Summary: passed=<n> failed=<n>`
24+
- Existing results/report behavior remains under `tests/results/**` from prior Playwright config.
25+
26+
## Validation Commands
27+
-`node -e "const fs=require('fs'); JSON.parse(fs.readFileSync('package.json','utf8')); console.log('package.json parse: PASS');"` -> **PASS**
28+
-`node --check scripts/run-workspace-v2-playwright-gate.mjs` -> **PASS**
29+
-`npm run test:workspace-v2` -> **PASS**
30+
31+
## Notes
32+
- No test logic changes.
33+
- No runtime/schema/tool behavior changes.
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# BUILD_PR_11_320
2+
3+
## Implementation
4+
- Updated `package.json` scripts:
5+
- added `test:workspace-v2:playwright`:
6+
-`playwright test tests/ui/workspace-v2.asset-manager.spec.js`
7+
- kept `test:workspace-v2` gate entry:
8+
-`node ./scripts/run-workspace-v2-playwright-gate.mjs`
9+
- Updated `scripts/run-workspace-v2-playwright-gate.mjs`:
10+
- executes installed Playwright command path via Node:
11+
- preferred: `process.execPath + process.env.npm_execpath run --silent test:workspace-v2:playwright`
12+
- fallback: local Playwright CLI path under `node_modules`
13+
- preserves:
14+
- streamed output
15+
- clear gate summary
16+
- non-zero exit on any failure condition
17+
18+
## Validation
19+
-`node -e "const fs=require('fs'); JSON.parse(fs.readFileSync('package.json','utf8')); console.log('package.json parse: PASS');"`
20+
-`node --check scripts/run-workspace-v2-playwright-gate.mjs`
21+
-`npm run test:workspace-v2`
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# PLAN_PR_11_320
2+
3+
## Purpose
4+
Update the Workspace V2 Playwright gate script to run the installed Playwright command path only, without install/bootstrap behaviors.
5+
6+
## Scope
7+
-`package.json`
8+
-`scripts/run-workspace-v2-playwright-gate.mjs`
9+
-`docs/dev/reports/PR_11_320_report.md`
10+
-`docs/dev/codex_commands.md`
11+
-`docs/dev/commit_comment.txt`
12+
13+
## Steps
14+
1. Add an explicit script for the installed Playwright command path.
15+
2. Update gate runner to execute that command through Node/npm CLI path (no install/bootstrap).
16+
3. Preserve fail-fast non-zero exit and pass/fail summary output.
17+
4. Keep results/report behavior under `tests/results/**` via existing Playwright config.
18+
5. Run required parse/syntax/test validations.

‎package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
"check:phase24-closeout-guard": "node tools/dev/checkPhase24CloseoutExecutionGuard.mjs",
1212
"check:style-system-guard": "node tools/dev/checkStyleSystemGuard.mjs",
1313
"check:games-template-contract": "node ./scripts/validate-games-template-contract.mjs",
14+
"test:workspace-v2:playwright": "playwright test tests/ui/workspace-v2.asset-manager.spec.js",
1415
"test:workspace-v2": "node ./scripts/run-workspace-v2-playwright-gate.mjs",
1516
"test:launch-smoke": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs",
1617
"test:launch-smoke:games": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --games",

‎scripts/run-workspace-v2-playwright-gate.mjs‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@ import { fileURLToPath } from "node:url";
1111
const__filename=fileURLToPath(import.meta.url);
1212
const__dirname=path.dirname(__filename);
1313
constrepoRoot=path.resolve(__dirname,"..");
14+
constnpmExecPath=typeofprocess.env.npm_execpath==="string" ? process.env.npm_execpath.trim() : "";
1415
constcommand=process.execPath;
15-
constargs=[
16-
path.join(repoRoot,"node_modules","@playwright","test","cli.js"),
17-
"test",
18-
"tests/ui/workspace-v2.asset-manager.spec.js"
19-
];
16+
constargs=npmExecPath
17+
? [npmExecPath,"run","--silent","test:workspace-v2:playwright"]
18+
: [path.join(repoRoot,"node_modules","@playwright","test","cli.js"),"test","tests/ui/workspace-v2.asset-manager.spec.js"];
2019

2120
constresult=spawnSync(command,args,{
2221
cwd: repoRoot,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 892e469

Browse files
committed
Simplify Workspace V2 Playwright gate to use installed dependencies only - PR_11_320
1 parent 35c3772 commit 892e469

7 files changed

Lines changed: 85 additions & 6 deletions

File tree

‎docs/dev/codex_commands.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,3 +215,10 @@ PR_11_319
215215
```bash
216216
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_319: Add required Workspace V2 Playwright gate command with explicit pass/fail summary and non-zero failure handling."
217217
```
218+
219+
---
220+
PR_11_320
221+
222+
```bash
223+
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_320: Update Workspace V2 Playwright gate to execute installed Playwright command path only, preserving fail-fast and summary output."
224+
```

‎docs/dev/commit_comment.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Promote Workspace V2 Playwright validation into required gate script with explicit non-zero failure handling - PR 11.319
1+
Update Workspace V2 Playwright gate to use installed command path while preserving fail-fast summary behavior - PR 11.320
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
# PR_11_320 Report
2+
3+
## Purpose
4+
Update Workspace V2 Playwright gate execution for installed Playwright command usage without install/bootstrap behaviors.
5+
6+
## Files Changed
7+
-`package.json`
8+
-`scripts/run-workspace-v2-playwright-gate.mjs`
9+
-`docs/pr/PR_11_320_WORKSPACE_V2_GATE_UPDATE/PLAN_PR.md`
10+
-`docs/pr/PR_11_320_WORKSPACE_V2_GATE_UPDATE/BUILD_PR.md`
11+
-`docs/dev/reports/PR_11_320_report.md`
12+
-`docs/dev/codex_commands.md`
13+
-`docs/dev/commit_comment.txt`
14+
15+
## Implementation Summary
16+
- Added explicit installed Playwright command script:
17+
-`npm run test:workspace-v2:playwright`
18+
- Kept gate command:
19+
-`npm run test:workspace-v2`
20+
- Gate runner now executes installed command path through Node/npm CLI path and preserves:
21+
- fail-fast non-zero exit on any failure
22+
- clear summary output:
23+
-`Workspace V2 Playwright Gate Summary: passed=<n> failed=<n>`
24+
- Existing results/report behavior remains under `tests/results/**` from prior Playwright config.
25+
26+
## Validation Commands
27+
-`node -e "const fs=require('fs'); JSON.parse(fs.readFileSync('package.json','utf8')); console.log('package.json parse: PASS');"` -> **PASS**
28+
-`node --check scripts/run-workspace-v2-playwright-gate.mjs` -> **PASS**
29+
-`npm run test:workspace-v2` -> **PASS**
30+
31+
## Notes
32+
- No test logic changes.
33+
- No runtime/schema/tool behavior changes.
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# BUILD_PR_11_320
2+
3+
## Implementation
4+
- Updated `package.json` scripts:
5+
- added `test:workspace-v2:playwright`:
6+
-`playwright test tests/ui/workspace-v2.asset-manager.spec.js`
7+
- kept `test:workspace-v2` gate entry:
8+
-`node ./scripts/run-workspace-v2-playwright-gate.mjs`
9+
- Updated `scripts/run-workspace-v2-playwright-gate.mjs`:
10+
- executes installed Playwright command path via Node:
11+
- preferred: `process.execPath + process.env.npm_execpath run --silent test:workspace-v2:playwright`
12+
- fallback: local Playwright CLI path under `node_modules`
13+
- preserves:
14+
- streamed output
15+
- clear gate summary
16+
- non-zero exit on any failure condition
17+
18+
## Validation
19+
-`node -e "const fs=require('fs'); JSON.parse(fs.readFileSync('package.json','utf8')); console.log('package.json parse: PASS');"`
20+
-`node --check scripts/run-workspace-v2-playwright-gate.mjs`
21+
-`npm run test:workspace-v2`
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# PLAN_PR_11_320
2+
3+
## Purpose
4+
Update the Workspace V2 Playwright gate script to run the installed Playwright command path only, without install/bootstrap behaviors.
5+
6+
## Scope
7+
-`package.json`
8+
-`scripts/run-workspace-v2-playwright-gate.mjs`
9+
-`docs/dev/reports/PR_11_320_report.md`
10+
-`docs/dev/codex_commands.md`
11+
-`docs/dev/commit_comment.txt`
12+
13+
## Steps
14+
1. Add an explicit script for the installed Playwright command path.
15+
2. Update gate runner to execute that command through Node/npm CLI path (no install/bootstrap).
16+
3. Preserve fail-fast non-zero exit and pass/fail summary output.
17+
4. Keep results/report behavior under `tests/results/**` via existing Playwright config.
18+
5. Run required parse/syntax/test validations.

‎package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
"check:phase24-closeout-guard": "node tools/dev/checkPhase24CloseoutExecutionGuard.mjs",
1212
"check:style-system-guard": "node tools/dev/checkStyleSystemGuard.mjs",
1313
"check:games-template-contract": "node ./scripts/validate-games-template-contract.mjs",
14+
"test:workspace-v2:playwright": "playwright test tests/ui/workspace-v2.asset-manager.spec.js",
1415
"test:workspace-v2": "node ./scripts/run-workspace-v2-playwright-gate.mjs",
1516
"test:launch-smoke": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs",
1617
"test:launch-smoke:games": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --games",

‎scripts/run-workspace-v2-playwright-gate.mjs‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@ import { fileURLToPath } from "node:url";
1111
const__filename=fileURLToPath(import.meta.url);
1212
const__dirname=path.dirname(__filename);
1313
constrepoRoot=path.resolve(__dirname,"..");
14+
constnpmExecPath=typeofprocess.env.npm_execpath==="string" ? process.env.npm_execpath.trim() : "";
1415
constcommand=process.execPath;
15-
constargs=[
16-
path.join(repoRoot,"node_modules","@playwright","test","cli.js"),
17-
"test",
18-
"tests/ui/workspace-v2.asset-manager.spec.js"
19-
];
16+
constargs=npmExecPath
17+
? [npmExecPath,"run","--silent","test:workspace-v2:playwright"]
18+
: [path.join(repoRoot,"node_modules","@playwright","test","cli.js"),"test","tests/ui/workspace-v2.asset-manager.spec.js"];
2019

2120
constresult=spawnSync(command,args,{
2221
cwd: repoRoot,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Commit 892e469

Browse files
committed
Simplify Workspace V2 Playwright gate to use installed dependencies only - PR_11_320
1 parent 35c3772 commit 892e469

7 files changed

Lines changed: 85 additions & 6 deletions

File tree

‎docs/dev/codex_commands.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,3 +215,10 @@ PR_11_319
215215
```bash
216216
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_319: Add required Workspace V2 Playwright gate command with explicit pass/fail summary and non-zero failure handling."
217217
```
218+
219+
---
220+
PR_11_320
221+
222+
```bash
223+
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_320: Update Workspace V2 Playwright gate to execute installed Playwright command path only, preserving fail-fast and summary output."
224+
```

‎docs/dev/commit_comment.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Promote Workspace V2 Playwright validation into required gate script with explicit non-zero failure handling - PR 11.319
1+
Update Workspace V2 Playwright gate to use installed command path while preserving fail-fast summary behavior - PR 11.320
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
# PR_11_320 Report
2+
3+
## Purpose
4+
Update Workspace V2 Playwright gate execution for installed Playwright command usage without install/bootstrap behaviors.
5+
6+
## Files Changed
7+
-`package.json`
8+
-`scripts/run-workspace-v2-playwright-gate.mjs`
9+
-`docs/pr/PR_11_320_WORKSPACE_V2_GATE_UPDATE/PLAN_PR.md`
10+
-`docs/pr/PR_11_320_WORKSPACE_V2_GATE_UPDATE/BUILD_PR.md`
11+
-`docs/dev/reports/PR_11_320_report.md`
12+
-`docs/dev/codex_commands.md`
13+
-`docs/dev/commit_comment.txt`
14+
15+
## Implementation Summary
16+
- Added explicit installed Playwright command script:
17+
-`npm run test:workspace-v2:playwright`
18+
- Kept gate command:
19+
-`npm run test:workspace-v2`
20+
- Gate runner now executes installed command path through Node/npm CLI path and preserves:
21+
- fail-fast non-zero exit on any failure
22+
- clear summary output:
23+
-`Workspace V2 Playwright Gate Summary: passed=<n> failed=<n>`
24+
- Existing results/report behavior remains under `tests/results/**` from prior Playwright config.
25+
26+
## Validation Commands
27+
-`node -e "const fs=require('fs'); JSON.parse(fs.readFileSync('package.json','utf8')); console.log('package.json parse: PASS');"` -> **PASS**
28+
-`node --check scripts/run-workspace-v2-playwright-gate.mjs` -> **PASS**
29+
-`npm run test:workspace-v2` -> **PASS**
30+
31+
## Notes
32+
- No test logic changes.
33+
- No runtime/schema/tool behavior changes.
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# BUILD_PR_11_320
2+
3+
## Implementation
4+
- Updated `package.json` scripts:
5+
- added `test:workspace-v2:playwright`:
6+
-`playwright test tests/ui/workspace-v2.asset-manager.spec.js`
7+
- kept `test:workspace-v2` gate entry:
8+
-`node ./scripts/run-workspace-v2-playwright-gate.mjs`
9+
- Updated `scripts/run-workspace-v2-playwright-gate.mjs`:
10+
- executes installed Playwright command path via Node:
11+
- preferred: `process.execPath + process.env.npm_execpath run --silent test:workspace-v2:playwright`
12+
- fallback: local Playwright CLI path under `node_modules`
13+
- preserves:
14+
- streamed output
15+
- clear gate summary
16+
- non-zero exit on any failure condition
17+
18+
## Validation
19+
-`node -e "const fs=require('fs'); JSON.parse(fs.readFileSync('package.json','utf8')); console.log('package.json parse: PASS');"`
20+
-`node --check scripts/run-workspace-v2-playwright-gate.mjs`
21+
-`npm run test:workspace-v2`
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# PLAN_PR_11_320
2+
3+
## Purpose
4+
Update the Workspace V2 Playwright gate script to run the installed Playwright command path only, without install/bootstrap behaviors.
5+
6+
## Scope
7+
-`package.json`
8+
-`scripts/run-workspace-v2-playwright-gate.mjs`
9+
-`docs/dev/reports/PR_11_320_report.md`
10+
-`docs/dev/codex_commands.md`
11+
-`docs/dev/commit_comment.txt`
12+
13+
## Steps
14+
1. Add an explicit script for the installed Playwright command path.
15+
2. Update gate runner to execute that command through Node/npm CLI path (no install/bootstrap).
16+
3. Preserve fail-fast non-zero exit and pass/fail summary output.
17+
4. Keep results/report behavior under `tests/results/**` via existing Playwright config.
18+
5. Run required parse/syntax/test validations.

‎package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
"check:phase24-closeout-guard": "node tools/dev/checkPhase24CloseoutExecutionGuard.mjs",
1212
"check:style-system-guard": "node tools/dev/checkStyleSystemGuard.mjs",
1313
"check:games-template-contract": "node ./scripts/validate-games-template-contract.mjs",
14+
"test:workspace-v2:playwright": "playwright test tests/ui/workspace-v2.asset-manager.spec.js",
1415
"test:workspace-v2": "node ./scripts/run-workspace-v2-playwright-gate.mjs",
1516
"test:launch-smoke": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs",
1617
"test:launch-smoke:games": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --games",

‎scripts/run-workspace-v2-playwright-gate.mjs‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@ import { fileURLToPath } from "node:url";
1111
const__filename=fileURLToPath(import.meta.url);
1212
const__dirname=path.dirname(__filename);
1313
constrepoRoot=path.resolve(__dirname,"..");
14+
constnpmExecPath=typeofprocess.env.npm_execpath==="string" ? process.env.npm_execpath.trim() : "";
1415
constcommand=process.execPath;
15-
constargs=[
16-
path.join(repoRoot,"node_modules","@playwright","test","cli.js"),
17-
"test",
18-
"tests/ui/workspace-v2.asset-manager.spec.js"
19-
];
16+
constargs=npmExecPath
17+
? [npmExecPath,"run","--silent","test:workspace-v2:playwright"]
18+
: [path.join(repoRoot,"node_modules","@playwright","test","cli.js"),"test","tests/ui/workspace-v2.asset-manager.spec.js"];
2019

2120
constresult=spawnSync(command,args,{
2221
cwd: repoRoot,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 892e469

Browse files
committed
Simplify Workspace V2 Playwright gate to use installed dependencies only - PR_11_320
1 parent 35c3772 commit 892e469

7 files changed

Lines changed: 85 additions & 6 deletions

File tree

‎docs/dev/codex_commands.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,3 +215,10 @@ PR_11_319
215215
```bash
216216
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_319: Add required Workspace V2 Playwright gate command with explicit pass/fail summary and non-zero failure handling."
217217
```
218+
219+
---
220+
PR_11_320
221+
222+
```bash
223+
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_320: Update Workspace V2 Playwright gate to execute installed Playwright command path only, preserving fail-fast and summary output."
224+
```

‎docs/dev/commit_comment.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Promote Workspace V2 Playwright validation into required gate script with explicit non-zero failure handling - PR 11.319
1+
Update Workspace V2 Playwright gate to use installed command path while preserving fail-fast summary behavior - PR 11.320
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
# PR_11_320 Report
2+
3+
## Purpose
4+
Update Workspace V2 Playwright gate execution for installed Playwright command usage without install/bootstrap behaviors.
5+
6+
## Files Changed
7+
-`package.json`
8+
-`scripts/run-workspace-v2-playwright-gate.mjs`
9+
-`docs/pr/PR_11_320_WORKSPACE_V2_GATE_UPDATE/PLAN_PR.md`
10+
-`docs/pr/PR_11_320_WORKSPACE_V2_GATE_UPDATE/BUILD_PR.md`
11+
-`docs/dev/reports/PR_11_320_report.md`
12+
-`docs/dev/codex_commands.md`
13+
-`docs/dev/commit_comment.txt`
14+
15+
## Implementation Summary
16+
- Added explicit installed Playwright command script:
17+
-`npm run test:workspace-v2:playwright`
18+
- Kept gate command:
19+
-`npm run test:workspace-v2`
20+
- Gate runner now executes installed command path through Node/npm CLI path and preserves:
21+
- fail-fast non-zero exit on any failure
22+
- clear summary output:
23+
-`Workspace V2 Playwright Gate Summary: passed=<n> failed=<n>`
24+
- Existing results/report behavior remains under `tests/results/**` from prior Playwright config.
25+
26+
## Validation Commands
27+
-`node -e "const fs=require('fs'); JSON.parse(fs.readFileSync('package.json','utf8')); console.log('package.json parse: PASS');"` -> **PASS**
28+
-`node --check scripts/run-workspace-v2-playwright-gate.mjs` -> **PASS**
29+
-`npm run test:workspace-v2` -> **PASS**
30+
31+
## Notes
32+
- No test logic changes.
33+
- No runtime/schema/tool behavior changes.
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# BUILD_PR_11_320
2+
3+
## Implementation
4+
- Updated `package.json` scripts:
5+
- added `test:workspace-v2:playwright`:
6+
-`playwright test tests/ui/workspace-v2.asset-manager.spec.js`
7+
- kept `test:workspace-v2` gate entry:
8+
-`node ./scripts/run-workspace-v2-playwright-gate.mjs`
9+
- Updated `scripts/run-workspace-v2-playwright-gate.mjs`:
10+
- executes installed Playwright command path via Node:
11+
- preferred: `process.execPath + process.env.npm_execpath run --silent test:workspace-v2:playwright`
12+
- fallback: local Playwright CLI path under `node_modules`
13+
- preserves:
14+
- streamed output
15+
- clear gate summary
16+
- non-zero exit on any failure condition
17+
18+
## Validation
19+
-`node -e "const fs=require('fs'); JSON.parse(fs.readFileSync('package.json','utf8')); console.log('package.json parse: PASS');"`
20+
-`node --check scripts/run-workspace-v2-playwright-gate.mjs`
21+
-`npm run test:workspace-v2`
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# PLAN_PR_11_320
2+
3+
## Purpose
4+
Update the Workspace V2 Playwright gate script to run the installed Playwright command path only, without install/bootstrap behaviors.
5+
6+
## Scope
7+
-`package.json`
8+
-`scripts/run-workspace-v2-playwright-gate.mjs`
9+
-`docs/dev/reports/PR_11_320_report.md`
10+
-`docs/dev/codex_commands.md`
11+
-`docs/dev/commit_comment.txt`
12+
13+
## Steps
14+
1. Add an explicit script for the installed Playwright command path.
15+
2. Update gate runner to execute that command through Node/npm CLI path (no install/bootstrap).
16+
3. Preserve fail-fast non-zero exit and pass/fail summary output.
17+
4. Keep results/report behavior under `tests/results/**` via existing Playwright config.
18+
5. Run required parse/syntax/test validations.

‎package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
"check:phase24-closeout-guard": "node tools/dev/checkPhase24CloseoutExecutionGuard.mjs",
1212
"check:style-system-guard": "node tools/dev/checkStyleSystemGuard.mjs",
1313
"check:games-template-contract": "node ./scripts/validate-games-template-contract.mjs",
14+
"test:workspace-v2:playwright": "playwright test tests/ui/workspace-v2.asset-manager.spec.js",
1415
"test:workspace-v2": "node ./scripts/run-workspace-v2-playwright-gate.mjs",
1516
"test:launch-smoke": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs",
1617
"test:launch-smoke:games": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --games",

‎scripts/run-workspace-v2-playwright-gate.mjs‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@ import { fileURLToPath } from "node:url";
1111
const__filename=fileURLToPath(import.meta.url);
1212
const__dirname=path.dirname(__filename);
1313
constrepoRoot=path.resolve(__dirname,"..");
14+
constnpmExecPath=typeofprocess.env.npm_execpath==="string" ? process.env.npm_execpath.trim() : "";
1415
constcommand=process.execPath;
15-
constargs=[
16-
path.join(repoRoot,"node_modules","@playwright","test","cli.js"),
17-
"test",
18-
"tests/ui/workspace-v2.asset-manager.spec.js"
19-
];
16+
constargs=npmExecPath
17+
? [npmExecPath,"run","--silent","test:workspace-v2:playwright"]
18+
: [path.join(repoRoot,"node_modules","@playwright","test","cli.js"),"test","tests/ui/workspace-v2.asset-manager.spec.js"];
2019

2120
constresult=spawnSync(command,args,{
2221
cwd: repoRoot,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 892e469

Browse files
committed
Simplify Workspace V2 Playwright gate to use installed dependencies only - PR_11_320
1 parent 35c3772 commit 892e469

7 files changed

Lines changed: 85 additions & 6 deletions

File tree

‎docs/dev/codex_commands.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,3 +215,10 @@ PR_11_319
215215
```bash
216216
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_319: Add required Workspace V2 Playwright gate command with explicit pass/fail summary and non-zero failure handling."
217217
```
218+
219+
---
220+
PR_11_320
221+
222+
```bash
223+
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_320: Update Workspace V2 Playwright gate to execute installed Playwright command path only, preserving fail-fast and summary output."
224+
```

‎docs/dev/commit_comment.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Promote Workspace V2 Playwright validation into required gate script with explicit non-zero failure handling - PR 11.319
1+
Update Workspace V2 Playwright gate to use installed command path while preserving fail-fast summary behavior - PR 11.320
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
# PR_11_320 Report
2+
3+
## Purpose
4+
Update Workspace V2 Playwright gate execution for installed Playwright command usage without install/bootstrap behaviors.
5+
6+
## Files Changed
7+
-`package.json`
8+
-`scripts/run-workspace-v2-playwright-gate.mjs`
9+
-`docs/pr/PR_11_320_WORKSPACE_V2_GATE_UPDATE/PLAN_PR.md`
10+
-`docs/pr/PR_11_320_WORKSPACE_V2_GATE_UPDATE/BUILD_PR.md`
11+
-`docs/dev/reports/PR_11_320_report.md`
12+
-`docs/dev/codex_commands.md`
13+
-`docs/dev/commit_comment.txt`
14+
15+
## Implementation Summary
16+
- Added explicit installed Playwright command script:
17+
-`npm run test:workspace-v2:playwright`
18+
- Kept gate command:
19+
-`npm run test:workspace-v2`
20+
- Gate runner now executes installed command path through Node/npm CLI path and preserves:
21+
- fail-fast non-zero exit on any failure
22+
- clear summary output:
23+
-`Workspace V2 Playwright Gate Summary: passed=<n> failed=<n>`
24+
- Existing results/report behavior remains under `tests/results/**` from prior Playwright config.
25+
26+
## Validation Commands
27+
-`node -e "const fs=require('fs'); JSON.parse(fs.readFileSync('package.json','utf8')); console.log('package.json parse: PASS');"` -> **PASS**
28+
-`node --check scripts/run-workspace-v2-playwright-gate.mjs` -> **PASS**
29+
-`npm run test:workspace-v2` -> **PASS**
30+
31+
## Notes
32+
- No test logic changes.
33+
- No runtime/schema/tool behavior changes.
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# BUILD_PR_11_320
2+
3+
## Implementation
4+
- Updated `package.json` scripts:
5+
- added `test:workspace-v2:playwright`:
6+
-`playwright test tests/ui/workspace-v2.asset-manager.spec.js`
7+
- kept `test:workspace-v2` gate entry:
8+
-`node ./scripts/run-workspace-v2-playwright-gate.mjs`
9+
- Updated `scripts/run-workspace-v2-playwright-gate.mjs`:
10+
- executes installed Playwright command path via Node:
11+
- preferred: `process.execPath + process.env.npm_execpath run --silent test:workspace-v2:playwright`
12+
- fallback: local Playwright CLI path under `node_modules`
13+
- preserves:
14+
- streamed output
15+
- clear gate summary
16+
- non-zero exit on any failure condition
17+
18+
## Validation
19+
-`node -e "const fs=require('fs'); JSON.parse(fs.readFileSync('package.json','utf8')); console.log('package.json parse: PASS');"`
20+
-`node --check scripts/run-workspace-v2-playwright-gate.mjs`
21+
-`npm run test:workspace-v2`
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# PLAN_PR_11_320
2+
3+
## Purpose
4+
Update the Workspace V2 Playwright gate script to run the installed Playwright command path only, without install/bootstrap behaviors.
5+
6+
## Scope
7+
-`package.json`
8+
-`scripts/run-workspace-v2-playwright-gate.mjs`
9+
-`docs/dev/reports/PR_11_320_report.md`
10+
-`docs/dev/codex_commands.md`
11+
-`docs/dev/commit_comment.txt`
12+
13+
## Steps
14+
1. Add an explicit script for the installed Playwright command path.
15+
2. Update gate runner to execute that command through Node/npm CLI path (no install/bootstrap).
16+
3. Preserve fail-fast non-zero exit and pass/fail summary output.
17+
4. Keep results/report behavior under `tests/results/**` via existing Playwright config.
18+
5. Run required parse/syntax/test validations.

‎package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
"check:phase24-closeout-guard": "node tools/dev/checkPhase24CloseoutExecutionGuard.mjs",
1212
"check:style-system-guard": "node tools/dev/checkStyleSystemGuard.mjs",
1313
"check:games-template-contract": "node ./scripts/validate-games-template-contract.mjs",
14+
"test:workspace-v2:playwright": "playwright test tests/ui/workspace-v2.asset-manager.spec.js",
1415
"test:workspace-v2": "node ./scripts/run-workspace-v2-playwright-gate.mjs",
1516
"test:launch-smoke": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs",
1617
"test:launch-smoke:games": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --games",

‎scripts/run-workspace-v2-playwright-gate.mjs‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@ import { fileURLToPath } from "node:url";
1111
const__filename=fileURLToPath(import.meta.url);
1212
const__dirname=path.dirname(__filename);
1313
constrepoRoot=path.resolve(__dirname,"..");
14+
constnpmExecPath=typeofprocess.env.npm_execpath==="string" ? process.env.npm_execpath.trim() : "";
1415
constcommand=process.execPath;
15-
constargs=[
16-
path.join(repoRoot,"node_modules","@playwright","test","cli.js"),
17-
"test",
18-
"tests/ui/workspace-v2.asset-manager.spec.js"
19-
];
16+
constargs=npmExecPath
17+
? [npmExecPath,"run","--silent","test:workspace-v2:playwright"]
18+
: [path.join(repoRoot,"node_modules","@playwright","test","cli.js"),"test","tests/ui/workspace-v2.asset-manager.spec.js"];
2019

2120
constresult=spawnSync(command,args,{
2221
cwd: repoRoot,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Commit 892e469

Browse files
committed
Simplify Workspace V2 Playwright gate to use installed dependencies only - PR_11_320
1 parent 35c3772 commit 892e469

7 files changed

Lines changed: 85 additions & 6 deletions

File tree

‎docs/dev/codex_commands.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,3 +215,10 @@ PR_11_319
215215
```bash
216216
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_319: Add required Workspace V2 Playwright gate command with explicit pass/fail summary and non-zero failure handling."
217217
```
218+
219+
---
220+
PR_11_320
221+
222+
```bash
223+
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_320: Update Workspace V2 Playwright gate to execute installed Playwright command path only, preserving fail-fast and summary output."
224+
```

‎docs/dev/commit_comment.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Promote Workspace V2 Playwright validation into required gate script with explicit non-zero failure handling - PR 11.319
1+
Update Workspace V2 Playwright gate to use installed command path while preserving fail-fast summary behavior - PR 11.320
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
# PR_11_320 Report
2+
3+
## Purpose
4+
Update Workspace V2 Playwright gate execution for installed Playwright command usage without install/bootstrap behaviors.
5+
6+
## Files Changed
7+
-`package.json`
8+
-`scripts/run-workspace-v2-playwright-gate.mjs`
9+
-`docs/pr/PR_11_320_WORKSPACE_V2_GATE_UPDATE/PLAN_PR.md`
10+
-`docs/pr/PR_11_320_WORKSPACE_V2_GATE_UPDATE/BUILD_PR.md`
11+
-`docs/dev/reports/PR_11_320_report.md`
12+
-`docs/dev/codex_commands.md`
13+
-`docs/dev/commit_comment.txt`
14+
15+
## Implementation Summary
16+
- Added explicit installed Playwright command script:
17+
-`npm run test:workspace-v2:playwright`
18+
- Kept gate command:
19+
-`npm run test:workspace-v2`
20+
- Gate runner now executes installed command path through Node/npm CLI path and preserves:
21+
- fail-fast non-zero exit on any failure
22+
- clear summary output:
23+
-`Workspace V2 Playwright Gate Summary: passed=<n> failed=<n>`
24+
- Existing results/report behavior remains under `tests/results/**` from prior Playwright config.
25+
26+
## Validation Commands
27+
-`node -e "const fs=require('fs'); JSON.parse(fs.readFileSync('package.json','utf8')); console.log('package.json parse: PASS');"` -> **PASS**
28+
-`node --check scripts/run-workspace-v2-playwright-gate.mjs` -> **PASS**
29+
-`npm run test:workspace-v2` -> **PASS**
30+
31+
## Notes
32+
- No test logic changes.
33+
- No runtime/schema/tool behavior changes.
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# BUILD_PR_11_320
2+
3+
## Implementation
4+
- Updated `package.json` scripts:
5+
- added `test:workspace-v2:playwright`:
6+
-`playwright test tests/ui/workspace-v2.asset-manager.spec.js`
7+
- kept `test:workspace-v2` gate entry:
8+
-`node ./scripts/run-workspace-v2-playwright-gate.mjs`
9+
- Updated `scripts/run-workspace-v2-playwright-gate.mjs`:
10+
- executes installed Playwright command path via Node:
11+
- preferred: `process.execPath + process.env.npm_execpath run --silent test:workspace-v2:playwright`
12+
- fallback: local Playwright CLI path under `node_modules`
13+
- preserves:
14+
- streamed output
15+
- clear gate summary
16+
- non-zero exit on any failure condition
17+
18+
## Validation
19+
-`node -e "const fs=require('fs'); JSON.parse(fs.readFileSync('package.json','utf8')); console.log('package.json parse: PASS');"`
20+
-`node --check scripts/run-workspace-v2-playwright-gate.mjs`
21+
-`npm run test:workspace-v2`
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# PLAN_PR_11_320
2+
3+
## Purpose
4+
Update the Workspace V2 Playwright gate script to run the installed Playwright command path only, without install/bootstrap behaviors.
5+
6+
## Scope
7+
-`package.json`
8+
-`scripts/run-workspace-v2-playwright-gate.mjs`
9+
-`docs/dev/reports/PR_11_320_report.md`
10+
-`docs/dev/codex_commands.md`
11+
-`docs/dev/commit_comment.txt`
12+
13+
## Steps
14+
1. Add an explicit script for the installed Playwright command path.
15+
2. Update gate runner to execute that command through Node/npm CLI path (no install/bootstrap).
16+
3. Preserve fail-fast non-zero exit and pass/fail summary output.
17+
4. Keep results/report behavior under `tests/results/**` via existing Playwright config.
18+
5. Run required parse/syntax/test validations.

‎package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
"check:phase24-closeout-guard": "node tools/dev/checkPhase24CloseoutExecutionGuard.mjs",
1212
"check:style-system-guard": "node tools/dev/checkStyleSystemGuard.mjs",
1313
"check:games-template-contract": "node ./scripts/validate-games-template-contract.mjs",
14+
"test:workspace-v2:playwright": "playwright test tests/ui/workspace-v2.asset-manager.spec.js",
1415
"test:workspace-v2": "node ./scripts/run-workspace-v2-playwright-gate.mjs",
1516
"test:launch-smoke": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs",
1617
"test:launch-smoke:games": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --games",

‎scripts/run-workspace-v2-playwright-gate.mjs‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@ import { fileURLToPath } from "node:url";
1111
const__filename=fileURLToPath(import.meta.url);
1212
const__dirname=path.dirname(__filename);
1313
constrepoRoot=path.resolve(__dirname,"..");
14+
constnpmExecPath=typeofprocess.env.npm_execpath==="string" ? process.env.npm_execpath.trim() : "";
1415
constcommand=process.execPath;
15-
constargs=[
16-
path.join(repoRoot,"node_modules","@playwright","test","cli.js"),
17-
"test",
18-
"tests/ui/workspace-v2.asset-manager.spec.js"
19-
];
16+
constargs=npmExecPath
17+
? [npmExecPath,"run","--silent","test:workspace-v2:playwright"]
18+
: [path.join(repoRoot,"node_modules","@playwright","test","cli.js"),"test","tests/ui/workspace-v2.asset-manager.spec.js"];
2019

2120
constresult=spawnSync(command,args,{
2221
cwd: repoRoot,

0 commit comments

Comments
 (0)