Skip to content

allow typeCheck CLI flag to override transpileOnly tsconfig flag - #1142

Merged
cspotcode merged 1 commit into
masterfrom
ab/fix-1119
Nov 3, 2020
Merged

allow typeCheck CLI flag to override transpileOnly tsconfig flag#1142
cspotcode merged 1 commit into
masterfrom
ab/fix-1119

Conversation

@cspotcode

Copy link
Copy Markdown
Collaborator

Fixes#1119

In #1119 we discussed some more ideal solutions, but this fix is simple and unblocks the user.

@codecov

codecovBot commented Nov 1, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1142 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #1142 +/- ##
=======================================
Coverage 79.60% 79.60% =======================================
Files 7 7 Lines 711 711 Branches 158 158 =======================================
Hits 566 566 Misses 89 89 Partials 56 56 
FlagCoverage Δ
node_1076.28% <0.00%> (ø)
node_12_1576.63% <0.00%> (ø)
node_12_1676.63% <0.00%> (ø)
node_1379.32% <0.00%> (ø)
node_1479.32% <0.00%> (ø)
node_14_13_078.19% <0.00%> (ø)
node_1579.32% <0.00%> (ø)
typescript_2_779.18% <0.00%> (ø)
typescript_latest78.48% <0.00%> (ø)
typescript_next78.34% <0.00%> (ø)
ubuntu79.32% <0.00%> (ø)
windows79.46% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e6e3e...6a707b8. Read the comment docs.

@coveralls

coveralls commented Nov 1, 2020

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.9%) to 87.097% when pulling 6a707b8 on ab/fix-1119 into c1e6e3e on master.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flag to override a default of transpileOnly

3 participants

@cspotcode@coveralls@blakeembrey