Skip to content

Fix misleading codecov failures - #1159

Merged
cspotcode merged 1 commit into
masterfrom
ab/fix-codecov-failures
Nov 22, 2020
Merged

Fix misleading codecov failures#1159
cspotcode merged 1 commit into
masterfrom
ab/fix-codecov-failures

Conversation

@cspotcode

@cspotcodecspotcode commented Nov 22, 2020

Copy link
Copy Markdown
Collaborator

Tweaks codecov configuration.

Project coverage is allowed to fall up to 1% and will still get the green checkmark.

Patch coverage has no requirements and will always succeed. I didn't feel like automatically-failing patch coverage was particularly useful. For example, if a patch changes 2 lines, and only one is covered, then patch coverage is 50%. This is IMO not necessarily a bad thing.

@codecov

codecovBot commented Nov 22, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1159 (4068edc) into master (f848983) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #1159 +/- ##
=======================================
Coverage 79.60% 79.60% =======================================
Files 7 7 Lines 711 711 Branches 158 158 =======================================
Hits 566 566 Misses 89 89 Partials 56 56 
FlagCoverage Δ
node_1076.11% <ø> (ø)
node_12_1576.46% <ø> (ø)
node_12_1676.46% <ø> (ø)
node_1378.90% <ø> (ø)
node_1478.90% <ø> (ø)
node_14_13_078.05% <ø> (ø)
node_1578.90% <ø> (ø)
typescript_2_778.90% <ø> (ø)
typescript_latest78.05% <ø> (ø)
typescript_next78.05% <ø> (ø)
ubuntu78.76% <ø> (ø)
windows78.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f848983...4068edc. Read the comment docs.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@cspotcode