Uh oh!
There was an error while loading. Please reload this page.
Fix issues related to group repeatable subsequent rows when there is a checkbox or radio input. - #304
Closed
kynetiv wants to merge 4 commits into
Closed
Fix issues related to group repeatable subsequent rows when there is a checkbox or radio input.#304kynetiv wants to merge 4 commits into
kynetiv wants to merge 4 commits into
Conversation
…a checkbox or radio input. If the input is a checkbox or radio, the original value is needed or saving will not save the value (subsequent post saves work because inputs will then have the required value set). This patch conditionally adds values to radios and inputs on new repeatable and sets the checked attribute only on the default option (radios). Fixes issue CMB2#257 (this will set reset text inputs as well), and CMB2#246 & CMB2#263(restores radio and checkbox values on new row saves)
kynetiv
commented
Apr 29, 2015
Author
Well, need to figure out how these tests are working so it can pass, but also found that there is a bug to fix when there are multiple radio options on the second subsequent new row. Will update this in a bit. |
jtsternberg added a commit
that referenced
this pull request
Aug 7, 2015
jtsternberg
commented
Aug 7, 2015
Member
Should be good in the trunk branch. please test. |
tw2113
commented
Aug 2, 2016
Contributor
Closing as it is said to be covered already in trunk, and probably release versions now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is a checkbox or radio input in the Group, the original value is needed or saving the post will not save the checkbox or radio value (subsequent post saves work because inputs will then have the required value set).
This patch conditionally adds values to radios and inputs on new repeatable rows and sets the checked attribute only on the default option (radios).
Fixes issue #257 (this will reset text inputs as well), and #246 & #263(restores radio and checkbox values on new row saves)