Uh oh!
There was an error while loading. Please reload this page.
Update CMB2_Utils.php - #453
Closed
wpscholar wants to merge 2 commits into
Closed
Conversation
After having done a decent amount of research and testing on properly fetching an image ID from a URL, I've found this solution to be more robust. Ultimately, using the guid just isn't reliable enough: http://wpscholar.com/blog/get-attachment-id-from-wp-image-url/
Correct URL reference
jtsternberg
commented
Sep 9, 2015
Member
This looks good. The image_id_from_url method is actually a backup method in case the image ID didn't get properly saved to the hidden field. Are you seeing it fall back to this method often? |
wpscholar
commented
Sep 9, 2015
ContributorAuthor
@jtsternberg I was actually just perusing the code and noticed this. Knowing that the guid isn't the most reliable way, I figured I would throw in my two cents. |
jtsternberg
commented
Sep 9, 2015
Member
Had to fix my broken tests before I could merge your changes in, but got them in. This is merged into trunk: https://github.com/WebDevStudios/CMB2/commits/trunk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After having done a decent amount of research and testing on properly fetching an image ID from a URL, I've found this solution to be more robust. Ultimately, using the guid just isn't reliable enough: http://wpscholar.com/blog/get-attachment-id-from-wp-image-url/