fix: require `NODE_USE_ENV_PROXY` for proxy support by parkerbxyz · Pull Request #342 · actions/create-github-app-token

parkerbxyz · 2026-03-12T18:32:34Z

This PR switches proxy support to Node's native env-proxy handling and makes the required configuration explicit.

What changed

fail fast in both main and post when proxy configuration is present without NODE_USE_ENV_PROXY=1
document the supported proxy configuration in README.md
add regression tests for the proxy guard in both entrypoints
keep the existing successful end-to-end coverage and add a smaller proxy-specific workflow check that enables native proxy support, points https_proxy at an unreachable proxy, and asserts the action fails
update the test workflow so the same checks also run on pushes to beta

Proxy configuration

When using HTTP_PROXY or HTTPS_PROXY, set NODE_USE_ENV_PROXY=1 on the action step. If you need bypass rules, set NO_PROXY alongside them.

Use Undici's EnvHttpProxyAgent in the shared request client so the beta branch keeps proxy support without relying on NODE_USE_ENV_PROXY or respawning the action process. Add focused proxy tests and regenerate snapshots/dist. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add a real end-to-end proxy job that starts a local CONNECT proxy, runs the action with https_proxy, and asserts that traffic actually tunneled through the proxy. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove the extra post-action API request from the proxy workflow job so it only verifies the action succeeds and that proxy traffic occurred. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove the bundled runtime proxy handling and rely on Node's native env-proxy support instead. Document the required NODE_USE_ENV_PROXY / NODE_OPTIONS setting, fail fast when proxy vars are set without native proxy support enabled, and keep proxy CI coverage on the native path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Fold the native proxy support guard into lib/request.js so the request-related logic stays together without a separate helper file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Make NODE_USE_ENV_PROXY=1 the only documented and enforced knob for enabling native proxy support. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Bump actions org workflow dependencies to their latest major versions where available. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR makes proxy behavior explicit by relying on Node.js native env-proxy handling and failing fast when proxy env vars are set without NODE_USE_ENV_PROXY=1, with accompanying docs and test/workflow coverage.

Changes:

Add a proxy configuration guard (ensureNativeProxySupport) and invoke it in both main and post entrypoints.
Add regression tests and update AVA snapshots for the proxy guard behavior.
Update README and CI workflow to document and validate the new proxy requirement (including a proxy-failure E2E job and running on beta pushes).

Reviewed changes

Copilot reviewed 9 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`lib/request.js`	Introduces proxy env detection and the `ensureNativeProxySupport` guard.
`main.js`	Calls the new guard during action startup.
`post.js`	Calls the new guard during post-step startup.
`tests/index.js`	Sanitizes proxy-related env vars for deterministic test execution.
`tests/main-proxy-requires-native-support.test.js`	Adds regression test for `main` proxy guard.
`tests/post-proxy-requires-native-support.test.js`	Adds regression test for `post` proxy guard.
`tests/snapshots/index.js.md`	Updates snapshot report with new proxy-guard test output.
`tests/snapshots/index.js.snap`	Updates/creates AVA snapshot data backing the report.
`README.md`	Documents required configuration for proxy usage.
`.github/workflows/test.yml`	Runs tests on `beta` pushes and adds an E2E job validating failure via unreachable proxy.
`dist/main.cjs`	Updates bundled output to include the new guard and call site.
`dist/post.cjs`	Updates bundled output to include the new guard and call site.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR makes proxy behavior explicit by switching to Node.js native env-proxy handling and failing early when proxy env vars are set without NODE_USE_ENV_PROXY=1, with accompanying docs, tests, and CI coverage.

Changes:

Add a runtime guard (ensureNativeProxySupport) and call it from both main and post entrypoints.
Add regression tests + snapshot updates for the new proxy guard behavior.
Expand CI to run on beta pushes and add an end-to-end workflow job that validates failure through an unreachable proxy.

Reviewed changes

Copilot reviewed 9 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`lib/request.js`	Adds `ensureNativeProxySupport()` to enforce explicit opt-in to Node’s env proxy support.
`main.js`	Wraps entrypoint in `run()` and calls proxy guard before executing main logic.
`post.js`	Wraps entrypoint in `run()` and calls proxy guard before executing post logic.
`tests/index.js`	Clears proxy-related env vars for consistent test execution.
`tests/main-proxy-requires-native-support.test.js`	Regression test for main entrypoint proxy guard behavior.
`tests/post-proxy-requires-native-support.test.js`	Regression test for post entrypoint proxy guard behavior.
`tests/snapshots/index.js.md`	Updates snapshot report with new proxy-guard test outputs.
`tests/snapshots/index.js.snap`	Updates underlying AVA snapshot data.
`.github/workflows/test.yml`	Runs on `beta` pushes and adds an end-to-end “unreachable proxy” job.
`README.md`	Documents proxy configuration and `NODE_USE_ENV_PROXY` requirement.
`dist/main.cjs`	Bundled output reflecting entrypoint + proxy guard changes.
`dist/post.cjs`	Bundled output reflecting entrypoint + proxy guard changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR makes proxy behavior explicit by switching proxy handling to Node.js native environment proxy support and failing fast when proxy variables are set without enabling that support, with accompanying documentation and regression coverage.

Changes:

Add a guard (ensureNativeProxySupport) that throws when HTTP_PROXY/HTTPS_PROXY are set but NODE_USE_ENV_PROXY !== "1".
Invoke the guard at startup in both main and post entrypoints (and in built dist/* outputs).
Add regression tests + snapshots and a dedicated end-to-end workflow job that validates failure through an unreachable proxy; run workflows on beta pushes too.

Reviewed changes

Copilot reviewed 9 out of 12 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
lib/request.js	Adds the `ensureNativeProxySupport()` guard and proxy env detection.
main.js	Calls the proxy guard early via a new `run()` wrapper before main logic.
post.js	Calls the proxy guard early via a new `run()` wrapper before post logic.
tests/main-proxy-requires-native-support.test.js	Regression test ensuring `main` fails fast when proxy is set without native support enabled.
tests/post-proxy-requires-native-support.test.js	Regression test ensuring `post` fails fast when proxy is set without native support enabled.
tests/index.js	Clears proxy-related env vars for deterministic test runs across environments.
tests/snapshots/index.js.md	Updates human-readable AVA snapshot output to include new proxy-guard tests.
tests/snapshots/index.js.snap	Adds the corresponding AVA snapshot data file.
README.md	Documents required env configuration for proxy usage (`NODE_USE_ENV_PROXY`).
.github/workflows/test.yml	Runs CI on `beta` pushes and adds an end-to-end “unreachable proxy” validation job.
dist/main.cjs	Bundled output updated to include the proxy guard and entrypoint wrapper.
dist/post.cjs	Bundled output updated to include the proxy guard and entrypoint wrapper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

# [3.0.0-beta.3](v3.0.0-beta.2...v3.0.0-beta.3) (2026-03-13) ### Bug Fixes * require `NODE_USE_ENV_PROXY` for proxy support ([#342](#342)) ([54e58b6](54e58b6))

create-app-token-action-releaser · 2026-03-13T06:19:32Z

🎉 This PR is included in version 3.0.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

BREAKING CHANGE: Custom proxy handling has been removed. If you use HTTP_PROXY or HTTPS_PROXY, you must now also set NODE_USE_ENV_PROXY=1 on the action step.

# [3.0.0-beta.5](v3.0.0-beta.4...v3.0.0-beta.5) (2026-03-13) * fix!: require `NODE_USE_ENV_PROXY` for proxy support ([#342](#342)) ([d53a1cd](d53a1cd)) ### BREAKING CHANGES * Custom proxy handling has been removed. If you use HTTP_PROXY or HTTPS_PROXY, you must now also set NODE_USE_ENV_PROXY=1 on the action step.

This PR switches proxy support to Node's native env-proxy handling and makes the required configuration explicit. - fail fast in both `main` and `post` when proxy configuration is present without `NODE_USE_ENV_PROXY=1` - document the supported proxy configuration in `README.md` - add regression tests for the proxy guard in both entrypoints - keep the existing successful end-to-end coverage and add a smaller proxy-specific workflow check that enables native proxy support, points `https_proxy` at an unreachable proxy, and asserts the action fails - update the test workflow so the same checks also run on pushes to `beta` When using `HTTP_PROXY` or `HTTPS_PROXY`, set `NODE_USE_ENV_PROXY=1` on the action step. If you need bypass rules, set `NO_PROXY` alongside them. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit 54e58b6)

BREAKING CHANGE: Custom proxy handling has been removed. If you use HTTP_PROXY or HTTPS_PROXY, you must now also set NODE_USE_ENV_PROXY=1 on the action step.

# [3.0.0](v2.2.2...v3.0.0) (2026-03-14) * feat!: node 24 support ([#275](#275)) ([2e564a0](2e564a0)) * fix!: require `NODE_USE_ENV_PROXY` for proxy support ([#342](#342)) ([4451bcb](4451bcb)) ### Bug Fixes * remove custom proxy handling ([#143](#143)) ([dce0ab0](dce0ab0)) ### BREAKING CHANGES * Custom proxy handling has been removed. If you use HTTP_PROXY or HTTPS_PROXY, you must now also set NODE_USE_ENV_PROXY=1 on the action step. * Requires [Actions Runner v2.327.1](https://github.com/actions/runner/releases/tag/v2.327.1) or later if you are using a self-hosted runner.

parkerbxyz changed the base branch from main to betaMarch 12, 2026 18:32

parkerbxyz self-assigned this Mar 12, 2026

parkerbxyzand others added 3 commits March 12, 2026 12:19

test: add proxy smoke test workflow
3439ac9
Add a real end-to-end proxy job that starts a local CONNECT proxy, runs the action with https_proxy, and asserts that traffic actually tunneled through the proxy. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

test: simplify proxy smoke test
3d276c3
Remove the extra post-action API request from the proxy workflow job so it only verifies the action succeeds and that proxy traffic occurred. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

parkerbxyz changed the title ~~Restore beta proxy env support with EnvHttpProxyAgent~~fix: rely on native Node proxy supportMar 13, 2026

parkerbxyzand others added 2 commits March 12, 2026 20:49

refactor: move proxy guard into request module
f9148ce
Fold the native proxy support guard into lib/request.js so the request-related logic stays together without a separate helper file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

docs: standardize on NODE_USE_ENV_PROXY
4a58a8c
Make NODE_USE_ENV_PROXY=1 the only documented and enforced knob for enabling native proxy support. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

parkerbxyz changed the title ~~fix: rely on native Node proxy support~~fix!: require NODE_USE_ENV_PROXY for proxy supportMar 13, 2026

parkerbxyzand others added 2 commits March 12, 2026 21:43

ci: update actions org dependencies
614fa33
Bump actions org workflow dependencies to their latest major versions where available. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

ci: use packageManager metadata for setup-node
840e9b8
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

parkerbxyz changed the title ~~fix!: require NODE_USE_ENV_PROXY for proxy support~~fix!: require NODE_USE_ENV_PROXY for proxy supportMar 13, 2026

parkerbxyzand others added 6 commits March 12, 2026 21:53

revert: drop unrelated workflow version bumps
f264ba5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

test: simplify proxy workflow assertion
5f601e9
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

test: move proxy workflow plumbing into helper
a7b1842
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

test: simplify proxy helper logging
dcbcfe6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

test: simplify proxy end-to-end coverage
60454ce
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

test: clarify unreachable proxy workflow
8c3363d
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

parkerbxyz marked this pull request as ready for review March 13, 2026 05:28

parkerbxyz requested a review from a team as a code owner March 13, 2026 05:28

CopilotAI review requested due to automatic review settings March 13, 2026 05:28

Copilotstarted reviewing on behalf of parkerbxyz March 13, 2026 05:29 View session

parkerbxyz changed the title ~~fix!: require NODE_USE_ENV_PROXY for proxy support~~fix: require NODE_USE_ENV_PROXY for proxy supportMar 13, 2026

CopilotAI reviewed Mar 13, 2026
View reviewed changes

Comment threadpost.js Outdated
Comment threadmain.js Outdated

fix: route proxy guard failures through setFailed
9f5b13e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

parkerbxyz requested a review from Copilot March 13, 2026 05:41

Copilotstarted reviewing on behalf of parkerbxyz March 13, 2026 05:41 View session

parkerbxyz mentioned this pull request Mar 13, 2026
WIP proxy support #284
Closed
4 tasks

CopilotAI reviewed Mar 13, 2026
View reviewed changes

Comment threadlib/request.js Outdated
Comment threadREADME.md Outdated

parkerbxyzand others added 2 commits March 12, 2026 22:48

docs: clarify proxy env requirements
86a2237
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

docs: simplify proxy env wording
7938847
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

parkerbxyz requested a review from Copilot March 13, 2026 05:53

Copilotstarted reviewing on behalf of parkerbxyz March 13, 2026 05:53 View session

docs: move proxy support section
1cfe65a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CopilotAI reviewed Mar 13, 2026
View reviewed changes

parkerbxyz merged commit 54e58b6 into betaMar 13, 2026
3 checks passed

parkerbxyz deleted the issue-134-remove-custom-proxy-functionality branch March 13, 2026 06:18

create-app-token-action-releaserBot added the released on @beta label Mar 13, 2026

parkerbxyz added a commit that referenced this pull request Mar 13, 2026
fix!: requireNODE_USE_ENV_PROXYfor proxy support (#342)
d53a1cd
BREAKING CHANGE: Custom proxy handling has been removed. If you use HTTP_PROXY or HTTPS_PROXY, you must now also set NODE_USE_ENV_PROXY=1 on the action step.

parkerbxyz added a commit that referenced this pull request Mar 14, 2026
fix!: requireNODE_USE_ENV_PROXYfor proxy support (#342)
0ab3b8d
BREAKING CHANGE: Custom proxy handling has been removed. If you use HTTP_PROXY or HTTPS_PROXY, you must now also set NODE_USE_ENV_PROXY=1 on the action step.

parkerbxyz added a commit that referenced this pull request Mar 14, 2026
fix!: requireNODE_USE_ENV_PROXYfor proxy support (#342)
4451bcb
BREAKING CHANGE: Custom proxy handling has been removed. If you use HTTP_PROXY or HTTPS_PROXY, you must now also set NODE_USE_ENV_PROXY=1 on the action step.

create-app-token-action-releaserBot mentioned this pull request May 8, 2026
chore(main): release create-github-app-token 4.0.0 #368
Closed

YumNumm mentioned this pull request May 11, 2026
[Improve]: actions/create-github-app-token を v1.8.1 から v3.1.1 にアップデートする ymm-oss/flutter-mobile-project-template#629
Open
3 tasks

github-actionsBot mentioned this pull request May 15, 2026
chore(ci)(deps): bump actions/create-github-app-token from 2.2.2 to 3.2.0 CopilotKit/CopilotKit#4854
Merged

claudeBot mentioned this pull request Aug 1, 2026
chore(deps): bump actions/create-github-app-token from 2 to 3 dimagi/open-chat-studio#4033
Merged

Navigation Menu

Uh oh!

fix: require `NODE_USE_ENV_PROXY` for proxy support - #342

fix: require `NODE_USE_ENV_PROXY` for proxy support#342
parkerbxyz merged 18 commits into
betafrom
issue-134-remove-custom-proxy-functionality

parkerbxyz commented Mar 12, 2026•
edited
Loading

Uh oh!

CopilotAI left a comment

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Uh oh!

Uh oh!

create-app-token-action-releaserBot commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

parkerbxyz commented Mar 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Proxy configuration

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

create-app-token-action-releaserBot commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

parkerbxyz commented Mar 12, 2026•
edited
Loading