secure container e2e case & guide doc - #249

Merged
Spground merged 13 commits into
opensandbox-group:mainfrom
fengcone:feature/public-secure-container
Mar 5, 2026
Merged

secure container e2e case & guide doc#249
Spground merged 13 commits into
opensandbox-group:mainfrom
fengcone:feature/public-secure-container

Conversation

@fengcone

@fengconefengcone commented Feb 26, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • What is changing and why?

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@fengcone

fengcone commented Feb 26, 2026•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

see issue #174

hittyt
hittyt reviewed Feb 26, 2026
View reviewed changes
Comment threadkubernetes/test/kind/gvisor/runsc Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/gvisor_test.go Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/suite_test.go Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/testdata/batchsandbox-runtimeclass.yaml Outdated
Comment threadkubernetes/test/e2e_runtime/helpers.go Outdated
@jwx0925

jwx0925 commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Feb 27, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ddbf36c86f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadkubernetes/test/e2e_runtime/gvisor/suite_test.go
Comment threadkubernetes/Makefile Outdated
@fengcone
test(gvisor): add gVisor binaries download and improve cluster setup
041d193
- Add Makefile target to download gVisor runsc and containerd-shim-runsc-v1 binaries
- Include gVisor binaries in .gitignore to avoid tracking
- Modify setup-gvisor target to depend on binaries download
- Update Kind cluster config file path in Makefile to use new template location
- Enhance Kind cluster creation commands to use downloaded binaries
- Add environment variable KIND_CLUSTER support for gVisor tests
- Improve command comments and error handling in gVisor test suite
- Remove unused RenderTemplate function and unnecessary imports in helpers.go
- Change relative directory comments from Chinese to English in tests
@fengcone
Merge branch 'main' into feature/public-secure-container
3c40b6a
@fengcone
test(e2e_runtime): remove unused gvisor batchsandbox and pool test da…
26dcd90
…ta YAML files
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 5f1004d to 9d0b9cdCompareMarch 3, 2026 13:53
Spground
Spground reviewed Mar 4, 2026
View reviewed changes
Comment threadserver/src/config.py
Comment threadserver/src/services/runtime_resolver.py
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 9d0b9cd to cd9f468CompareMarch 4, 2026 07:27
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from cd9f468 to a64513cCompareMarch 4, 2026 07:29
@fengcone
Merge branch 'main' into feature/public-secure-container
4222dbe
# Conflicts:
#	kubernetes/Makefile
#	server/README.md
#	server/README_zh.md
#	server/src/main.py
@fengcone
chore(server): add logger instance to main module
696d6ba
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 7cf8651 to 696d6baCompareMarch 4, 2026 07:46
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 6bad9c4 to cd6c8cbCompareMarch 4, 2026 10:01
@jwx0925

jwx0925 commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

add this feature to README.md, like this:

  • Strong Isolation: Supports different security runtimes like gVisor, Kata Containers, or Firecracker microVM to provide enhanced security and isolation between sandbox workloads and the host. See doc ....

@jwx0925

jwx0925 commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Mar 4, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:0db17ac692

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadserver/src/services/k8s/provider_factory.py
Comment threadserver/src/config.py
Pangjiping
Pangjiping previously approved these changes Mar 5, 2026
View reviewed changes

@PangjipingPangjiping left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PangjipingPangjiping added documentation Improvements or additions to documentation feature New feature or request component/server labels Mar 5, 2026
@PangjipingPangjiping mentioned this pull request Mar 5, 2026
Closed
Spground
Spground approved these changes Mar 5, 2026
View reviewed changes

@SpgroundSpground left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spground
Spground merged commit 9c661b0 into opensandbox-group:mainMar 5, 2026
24 of 27 checks passed
@fengconefengcone mentioned this pull request Mar 5, 2026
Closed
axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀💥

@axistore80-coder

axistore80-coder commented Mar 8, 2026

Copy link
Copy Markdown

🚀

axistore80-coder
axistore80-coder approved these changes Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥🚀

axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

pllana95
pllana95 reviewed Mar 22, 2026
View reviewed changes

@pllana95pllana95 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hittythittythittyt left review comments
@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments
@SpgroundSpgroundSpground approved these changes
@PangjipingPangjipingPangjiping approved these changes
@GeneralwinGeneralwinAwaiting requested review from GeneralwinGeneralwin is a code owner
@kevinlynxkevinlynxAwaiting requested review from kevinlynxkevinlynx is a code owner
@jwx0925jwx0925Awaiting requested review from jwx0925jwx0925 is a code owner
@ninan-nnninan-nnAwaiting requested review from ninan-nnninan-nn is a code owner
+2 more reviewers
@pllana95pllana95pllana95 left review comments
@axistore80-coderaxistore80-coderaxistore80-coder approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/serverdocumentationImprovements or additions to documentationfeatureNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@fengcone@jwx0925@axistore80-coder@hittyt@Spground@Pangjiping@pllana95
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

secure container e2e case & guide doc - #249

Merged
Spground merged 13 commits into
opensandbox-group:mainfrom
fengcone:feature/public-secure-container
Mar 5, 2026
Merged

secure container e2e case & guide doc#249
Spground merged 13 commits into
opensandbox-group:mainfrom
fengcone:feature/public-secure-container

Conversation

@fengcone

@fengconefengcone commented Feb 26, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • What is changing and why?

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@fengcone

fengcone commented Feb 26, 2026•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

see issue #174

hittyt
hittyt reviewed Feb 26, 2026
View reviewed changes
Comment threadkubernetes/test/kind/gvisor/runsc Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/gvisor_test.go Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/suite_test.go Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/testdata/batchsandbox-runtimeclass.yaml Outdated
Comment threadkubernetes/test/e2e_runtime/helpers.go Outdated
@jwx0925

jwx0925 commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Feb 27, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ddbf36c86f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadkubernetes/test/e2e_runtime/gvisor/suite_test.go
Comment threadkubernetes/Makefile Outdated
@fengcone
test(gvisor): add gVisor binaries download and improve cluster setup
041d193
- Add Makefile target to download gVisor runsc and containerd-shim-runsc-v1 binaries
- Include gVisor binaries in .gitignore to avoid tracking
- Modify setup-gvisor target to depend on binaries download
- Update Kind cluster config file path in Makefile to use new template location
- Enhance Kind cluster creation commands to use downloaded binaries
- Add environment variable KIND_CLUSTER support for gVisor tests
- Improve command comments and error handling in gVisor test suite
- Remove unused RenderTemplate function and unnecessary imports in helpers.go
- Change relative directory comments from Chinese to English in tests
@fengcone
Merge branch 'main' into feature/public-secure-container
3c40b6a
@fengcone
test(e2e_runtime): remove unused gvisor batchsandbox and pool test da…
26dcd90
…ta YAML files
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 5f1004d to 9d0b9cdCompareMarch 3, 2026 13:53
Spground
Spground reviewed Mar 4, 2026
View reviewed changes
Comment threadserver/src/config.py
Comment threadserver/src/services/runtime_resolver.py
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 9d0b9cd to cd9f468CompareMarch 4, 2026 07:27
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from cd9f468 to a64513cCompareMarch 4, 2026 07:29
@fengcone
Merge branch 'main' into feature/public-secure-container
4222dbe
# Conflicts:
#	kubernetes/Makefile
#	server/README.md
#	server/README_zh.md
#	server/src/main.py
@fengcone
chore(server): add logger instance to main module
696d6ba
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 7cf8651 to 696d6baCompareMarch 4, 2026 07:46
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 6bad9c4 to cd6c8cbCompareMarch 4, 2026 10:01
@jwx0925

jwx0925 commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

add this feature to README.md, like this:

  • Strong Isolation: Supports different security runtimes like gVisor, Kata Containers, or Firecracker microVM to provide enhanced security and isolation between sandbox workloads and the host. See doc ....

@jwx0925

jwx0925 commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Mar 4, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:0db17ac692

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadserver/src/services/k8s/provider_factory.py
Comment threadserver/src/config.py
Pangjiping
Pangjiping previously approved these changes Mar 5, 2026
View reviewed changes

@PangjipingPangjiping left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PangjipingPangjiping added documentation Improvements or additions to documentation feature New feature or request component/server labels Mar 5, 2026
@PangjipingPangjiping mentioned this pull request Mar 5, 2026
Closed
Spground
Spground approved these changes Mar 5, 2026
View reviewed changes

@SpgroundSpground left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spground
Spground merged commit 9c661b0 into opensandbox-group:mainMar 5, 2026
24 of 27 checks passed
@fengconefengcone mentioned this pull request Mar 5, 2026
Closed
axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀💥

@axistore80-coder

axistore80-coder commented Mar 8, 2026

Copy link
Copy Markdown

🚀

axistore80-coder
axistore80-coder approved these changes Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥🚀

axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

pllana95
pllana95 reviewed Mar 22, 2026
View reviewed changes

@pllana95pllana95 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hittythittythittyt left review comments
@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments
@SpgroundSpgroundSpground approved these changes
@PangjipingPangjipingPangjiping approved these changes
@GeneralwinGeneralwinAwaiting requested review from GeneralwinGeneralwin is a code owner
@kevinlynxkevinlynxAwaiting requested review from kevinlynxkevinlynx is a code owner
@jwx0925jwx0925Awaiting requested review from jwx0925jwx0925 is a code owner
@ninan-nnninan-nnAwaiting requested review from ninan-nnninan-nn is a code owner
+2 more reviewers
@pllana95pllana95pllana95 left review comments
@axistore80-coderaxistore80-coderaxistore80-coder approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/serverdocumentationImprovements or additions to documentationfeatureNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@fengcone@jwx0925@axistore80-coder@hittyt@Spground@Pangjiping@pllana95
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

secure container e2e case & guide doc - #249

Merged
Spground merged 13 commits into
opensandbox-group:mainfrom
fengcone:feature/public-secure-container
Mar 5, 2026
Merged

secure container e2e case & guide doc#249
Spground merged 13 commits into
opensandbox-group:mainfrom
fengcone:feature/public-secure-container

Conversation

@fengcone

@fengconefengcone commented Feb 26, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • What is changing and why?

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@fengcone

fengcone commented Feb 26, 2026•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

see issue #174

hittyt
hittyt reviewed Feb 26, 2026
View reviewed changes
Comment threadkubernetes/test/kind/gvisor/runsc Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/gvisor_test.go Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/suite_test.go Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/testdata/batchsandbox-runtimeclass.yaml Outdated
Comment threadkubernetes/test/e2e_runtime/helpers.go Outdated
@jwx0925

jwx0925 commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Feb 27, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ddbf36c86f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadkubernetes/test/e2e_runtime/gvisor/suite_test.go
Comment threadkubernetes/Makefile Outdated
@fengcone
test(gvisor): add gVisor binaries download and improve cluster setup
041d193
- Add Makefile target to download gVisor runsc and containerd-shim-runsc-v1 binaries
- Include gVisor binaries in .gitignore to avoid tracking
- Modify setup-gvisor target to depend on binaries download
- Update Kind cluster config file path in Makefile to use new template location
- Enhance Kind cluster creation commands to use downloaded binaries
- Add environment variable KIND_CLUSTER support for gVisor tests
- Improve command comments and error handling in gVisor test suite
- Remove unused RenderTemplate function and unnecessary imports in helpers.go
- Change relative directory comments from Chinese to English in tests
@fengcone
Merge branch 'main' into feature/public-secure-container
3c40b6a
@fengcone
test(e2e_runtime): remove unused gvisor batchsandbox and pool test da…
26dcd90
…ta YAML files
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 5f1004d to 9d0b9cdCompareMarch 3, 2026 13:53
Spground
Spground reviewed Mar 4, 2026
View reviewed changes
Comment threadserver/src/config.py
Comment threadserver/src/services/runtime_resolver.py
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 9d0b9cd to cd9f468CompareMarch 4, 2026 07:27
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from cd9f468 to a64513cCompareMarch 4, 2026 07:29
@fengcone
Merge branch 'main' into feature/public-secure-container
4222dbe
# Conflicts:
#	kubernetes/Makefile
#	server/README.md
#	server/README_zh.md
#	server/src/main.py
@fengcone
chore(server): add logger instance to main module
696d6ba
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 7cf8651 to 696d6baCompareMarch 4, 2026 07:46
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 6bad9c4 to cd6c8cbCompareMarch 4, 2026 10:01
@jwx0925

jwx0925 commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

add this feature to README.md, like this:

  • Strong Isolation: Supports different security runtimes like gVisor, Kata Containers, or Firecracker microVM to provide enhanced security and isolation between sandbox workloads and the host. See doc ....

@jwx0925

jwx0925 commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Mar 4, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:0db17ac692

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadserver/src/services/k8s/provider_factory.py
Comment threadserver/src/config.py
Pangjiping
Pangjiping previously approved these changes Mar 5, 2026
View reviewed changes

@PangjipingPangjiping left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PangjipingPangjiping added documentation Improvements or additions to documentation feature New feature or request component/server labels Mar 5, 2026
@PangjipingPangjiping mentioned this pull request Mar 5, 2026
Closed
Spground
Spground approved these changes Mar 5, 2026
View reviewed changes

@SpgroundSpground left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spground
Spground merged commit 9c661b0 into opensandbox-group:mainMar 5, 2026
24 of 27 checks passed
@fengconefengcone mentioned this pull request Mar 5, 2026
Closed
axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀💥

@axistore80-coder

axistore80-coder commented Mar 8, 2026

Copy link
Copy Markdown

🚀

axistore80-coder
axistore80-coder approved these changes Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥🚀

axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

pllana95
pllana95 reviewed Mar 22, 2026
View reviewed changes

@pllana95pllana95 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hittythittythittyt left review comments
@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments
@SpgroundSpgroundSpground approved these changes
@PangjipingPangjipingPangjiping approved these changes
@GeneralwinGeneralwinAwaiting requested review from GeneralwinGeneralwin is a code owner
@kevinlynxkevinlynxAwaiting requested review from kevinlynxkevinlynx is a code owner
@jwx0925jwx0925Awaiting requested review from jwx0925jwx0925 is a code owner
@ninan-nnninan-nnAwaiting requested review from ninan-nnninan-nn is a code owner
+2 more reviewers
@pllana95pllana95pllana95 left review comments
@axistore80-coderaxistore80-coderaxistore80-coder approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/serverdocumentationImprovements or additions to documentationfeatureNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@fengcone@jwx0925@axistore80-coder@hittyt@Spground@Pangjiping@pllana95
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

secure container e2e case & guide doc - #249

Merged
Spground merged 13 commits into
opensandbox-group:mainfrom
fengcone:feature/public-secure-container
Mar 5, 2026
Merged

secure container e2e case & guide doc#249
Spground merged 13 commits into
opensandbox-group:mainfrom
fengcone:feature/public-secure-container

Conversation

@fengcone

@fengconefengcone commented Feb 26, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • What is changing and why?

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@fengcone

fengcone commented Feb 26, 2026•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

see issue #174

hittyt
hittyt reviewed Feb 26, 2026
View reviewed changes
Comment threadkubernetes/test/kind/gvisor/runsc Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/gvisor_test.go Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/suite_test.go Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/testdata/batchsandbox-runtimeclass.yaml Outdated
Comment threadkubernetes/test/e2e_runtime/helpers.go Outdated
@jwx0925

jwx0925 commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Feb 27, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ddbf36c86f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadkubernetes/test/e2e_runtime/gvisor/suite_test.go
Comment threadkubernetes/Makefile Outdated
@fengcone
test(gvisor): add gVisor binaries download and improve cluster setup
041d193
- Add Makefile target to download gVisor runsc and containerd-shim-runsc-v1 binaries
- Include gVisor binaries in .gitignore to avoid tracking
- Modify setup-gvisor target to depend on binaries download
- Update Kind cluster config file path in Makefile to use new template location
- Enhance Kind cluster creation commands to use downloaded binaries
- Add environment variable KIND_CLUSTER support for gVisor tests
- Improve command comments and error handling in gVisor test suite
- Remove unused RenderTemplate function and unnecessary imports in helpers.go
- Change relative directory comments from Chinese to English in tests
@fengcone
Merge branch 'main' into feature/public-secure-container
3c40b6a
@fengcone
test(e2e_runtime): remove unused gvisor batchsandbox and pool test da…
26dcd90
…ta YAML files
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 5f1004d to 9d0b9cdCompareMarch 3, 2026 13:53
Spground
Spground reviewed Mar 4, 2026
View reviewed changes
Comment threadserver/src/config.py
Comment threadserver/src/services/runtime_resolver.py
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 9d0b9cd to cd9f468CompareMarch 4, 2026 07:27
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from cd9f468 to a64513cCompareMarch 4, 2026 07:29
@fengcone
Merge branch 'main' into feature/public-secure-container
4222dbe
# Conflicts:
#	kubernetes/Makefile
#	server/README.md
#	server/README_zh.md
#	server/src/main.py
@fengcone
chore(server): add logger instance to main module
696d6ba
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 7cf8651 to 696d6baCompareMarch 4, 2026 07:46
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 6bad9c4 to cd6c8cbCompareMarch 4, 2026 10:01
@jwx0925

jwx0925 commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

add this feature to README.md, like this:

  • Strong Isolation: Supports different security runtimes like gVisor, Kata Containers, or Firecracker microVM to provide enhanced security and isolation between sandbox workloads and the host. See doc ....

@jwx0925

jwx0925 commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Mar 4, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:0db17ac692

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadserver/src/services/k8s/provider_factory.py
Comment threadserver/src/config.py
Pangjiping
Pangjiping previously approved these changes Mar 5, 2026
View reviewed changes

@PangjipingPangjiping left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PangjipingPangjiping added documentation Improvements or additions to documentation feature New feature or request component/server labels Mar 5, 2026
@PangjipingPangjiping mentioned this pull request Mar 5, 2026
Closed
Spground
Spground approved these changes Mar 5, 2026
View reviewed changes

@SpgroundSpground left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spground
Spground merged commit 9c661b0 into opensandbox-group:mainMar 5, 2026
24 of 27 checks passed
@fengconefengcone mentioned this pull request Mar 5, 2026
Closed
axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀💥

@axistore80-coder

axistore80-coder commented Mar 8, 2026

Copy link
Copy Markdown

🚀

axistore80-coder
axistore80-coder approved these changes Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥🚀

axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

pllana95
pllana95 reviewed Mar 22, 2026
View reviewed changes

@pllana95pllana95 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hittythittythittyt left review comments
@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments
@SpgroundSpgroundSpground approved these changes
@PangjipingPangjipingPangjiping approved these changes
@GeneralwinGeneralwinAwaiting requested review from GeneralwinGeneralwin is a code owner
@kevinlynxkevinlynxAwaiting requested review from kevinlynxkevinlynx is a code owner
@jwx0925jwx0925Awaiting requested review from jwx0925jwx0925 is a code owner
@ninan-nnninan-nnAwaiting requested review from ninan-nnninan-nn is a code owner
+2 more reviewers
@pllana95pllana95pllana95 left review comments
@axistore80-coderaxistore80-coderaxistore80-coder approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/serverdocumentationImprovements or additions to documentationfeatureNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@fengcone@jwx0925@axistore80-coder@hittyt@Spground@Pangjiping@pllana95
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

secure container e2e case & guide doc - #249

Merged
Spground merged 13 commits into
opensandbox-group:mainfrom
fengcone:feature/public-secure-container
Mar 5, 2026
Merged

secure container e2e case & guide doc#249
Spground merged 13 commits into
opensandbox-group:mainfrom
fengcone:feature/public-secure-container

Conversation

@fengcone

@fengconefengcone commented Feb 26, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • What is changing and why?

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@fengcone

fengcone commented Feb 26, 2026•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

see issue #174

hittyt
hittyt reviewed Feb 26, 2026
View reviewed changes
Comment threadkubernetes/test/kind/gvisor/runsc Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/gvisor_test.go Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/suite_test.go Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/testdata/batchsandbox-runtimeclass.yaml Outdated
Comment threadkubernetes/test/e2e_runtime/helpers.go Outdated
@jwx0925

jwx0925 commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Feb 27, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ddbf36c86f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadkubernetes/test/e2e_runtime/gvisor/suite_test.go
Comment threadkubernetes/Makefile Outdated
@fengcone
test(gvisor): add gVisor binaries download and improve cluster setup
041d193
- Add Makefile target to download gVisor runsc and containerd-shim-runsc-v1 binaries
- Include gVisor binaries in .gitignore to avoid tracking
- Modify setup-gvisor target to depend on binaries download
- Update Kind cluster config file path in Makefile to use new template location
- Enhance Kind cluster creation commands to use downloaded binaries
- Add environment variable KIND_CLUSTER support for gVisor tests
- Improve command comments and error handling in gVisor test suite
- Remove unused RenderTemplate function and unnecessary imports in helpers.go
- Change relative directory comments from Chinese to English in tests
@fengcone
Merge branch 'main' into feature/public-secure-container
3c40b6a
@fengcone
test(e2e_runtime): remove unused gvisor batchsandbox and pool test da…
26dcd90
…ta YAML files
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 5f1004d to 9d0b9cdCompareMarch 3, 2026 13:53
Spground
Spground reviewed Mar 4, 2026
View reviewed changes
Comment threadserver/src/config.py
Comment threadserver/src/services/runtime_resolver.py
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 9d0b9cd to cd9f468CompareMarch 4, 2026 07:27
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from cd9f468 to a64513cCompareMarch 4, 2026 07:29
@fengcone
Merge branch 'main' into feature/public-secure-container
4222dbe
# Conflicts:
#	kubernetes/Makefile
#	server/README.md
#	server/README_zh.md
#	server/src/main.py
@fengcone
chore(server): add logger instance to main module
696d6ba
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 7cf8651 to 696d6baCompareMarch 4, 2026 07:46
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 6bad9c4 to cd6c8cbCompareMarch 4, 2026 10:01
@jwx0925

jwx0925 commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

add this feature to README.md, like this:

  • Strong Isolation: Supports different security runtimes like gVisor, Kata Containers, or Firecracker microVM to provide enhanced security and isolation between sandbox workloads and the host. See doc ....

@jwx0925

jwx0925 commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Mar 4, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:0db17ac692

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadserver/src/services/k8s/provider_factory.py
Comment threadserver/src/config.py
Pangjiping
Pangjiping previously approved these changes Mar 5, 2026
View reviewed changes

@PangjipingPangjiping left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PangjipingPangjiping added documentation Improvements or additions to documentation feature New feature or request component/server labels Mar 5, 2026
@PangjipingPangjiping mentioned this pull request Mar 5, 2026
Closed
Spground
Spground approved these changes Mar 5, 2026
View reviewed changes

@SpgroundSpground left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spground
Spground merged commit 9c661b0 into opensandbox-group:mainMar 5, 2026
24 of 27 checks passed
@fengconefengcone mentioned this pull request Mar 5, 2026
Closed
axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀💥

@axistore80-coder

axistore80-coder commented Mar 8, 2026

Copy link
Copy Markdown

🚀

axistore80-coder
axistore80-coder approved these changes Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥🚀

axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

pllana95
pllana95 reviewed Mar 22, 2026
View reviewed changes

@pllana95pllana95 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hittythittythittyt left review comments
@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments
@SpgroundSpgroundSpground approved these changes
@PangjipingPangjipingPangjiping approved these changes
@GeneralwinGeneralwinAwaiting requested review from GeneralwinGeneralwin is a code owner
@kevinlynxkevinlynxAwaiting requested review from kevinlynxkevinlynx is a code owner
@jwx0925jwx0925Awaiting requested review from jwx0925jwx0925 is a code owner
@ninan-nnninan-nnAwaiting requested review from ninan-nnninan-nn is a code owner
+2 more reviewers
@pllana95pllana95pllana95 left review comments
@axistore80-coderaxistore80-coderaxistore80-coder approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/serverdocumentationImprovements or additions to documentationfeatureNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@fengcone@jwx0925@axistore80-coder@hittyt@Spground@Pangjiping@pllana95
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

secure container e2e case & guide doc - #249

Merged
Spground merged 13 commits into
opensandbox-group:mainfrom
fengcone:feature/public-secure-container
Mar 5, 2026
Merged

secure container e2e case & guide doc#249
Spground merged 13 commits into
opensandbox-group:mainfrom
fengcone:feature/public-secure-container

Conversation

@fengcone

@fengconefengcone commented Feb 26, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • What is changing and why?

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@fengcone

fengcone commented Feb 26, 2026•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

see issue #174

hittyt
hittyt reviewed Feb 26, 2026
View reviewed changes
Comment threadkubernetes/test/kind/gvisor/runsc Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/gvisor_test.go Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/suite_test.go Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/testdata/batchsandbox-runtimeclass.yaml Outdated
Comment threadkubernetes/test/e2e_runtime/helpers.go Outdated
@jwx0925

jwx0925 commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Feb 27, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ddbf36c86f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadkubernetes/test/e2e_runtime/gvisor/suite_test.go
Comment threadkubernetes/Makefile Outdated
@fengcone
test(gvisor): add gVisor binaries download and improve cluster setup
041d193
- Add Makefile target to download gVisor runsc and containerd-shim-runsc-v1 binaries
- Include gVisor binaries in .gitignore to avoid tracking
- Modify setup-gvisor target to depend on binaries download
- Update Kind cluster config file path in Makefile to use new template location
- Enhance Kind cluster creation commands to use downloaded binaries
- Add environment variable KIND_CLUSTER support for gVisor tests
- Improve command comments and error handling in gVisor test suite
- Remove unused RenderTemplate function and unnecessary imports in helpers.go
- Change relative directory comments from Chinese to English in tests
@fengcone
Merge branch 'main' into feature/public-secure-container
3c40b6a
@fengcone
test(e2e_runtime): remove unused gvisor batchsandbox and pool test da…
26dcd90
…ta YAML files
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 5f1004d to 9d0b9cdCompareMarch 3, 2026 13:53
Spground
Spground reviewed Mar 4, 2026
View reviewed changes
Comment threadserver/src/config.py
Comment threadserver/src/services/runtime_resolver.py
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 9d0b9cd to cd9f468CompareMarch 4, 2026 07:27
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from cd9f468 to a64513cCompareMarch 4, 2026 07:29
@fengcone
Merge branch 'main' into feature/public-secure-container
4222dbe
# Conflicts:
#	kubernetes/Makefile
#	server/README.md
#	server/README_zh.md
#	server/src/main.py
@fengcone
chore(server): add logger instance to main module
696d6ba
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 7cf8651 to 696d6baCompareMarch 4, 2026 07:46
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 6bad9c4 to cd6c8cbCompareMarch 4, 2026 10:01
@jwx0925

jwx0925 commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

add this feature to README.md, like this:

  • Strong Isolation: Supports different security runtimes like gVisor, Kata Containers, or Firecracker microVM to provide enhanced security and isolation between sandbox workloads and the host. See doc ....

@jwx0925

jwx0925 commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Mar 4, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:0db17ac692

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadserver/src/services/k8s/provider_factory.py
Comment threadserver/src/config.py
Pangjiping
Pangjiping previously approved these changes Mar 5, 2026
View reviewed changes

@PangjipingPangjiping left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PangjipingPangjiping added documentation Improvements or additions to documentation feature New feature or request component/server labels Mar 5, 2026
@PangjipingPangjiping mentioned this pull request Mar 5, 2026
Closed
Spground
Spground approved these changes Mar 5, 2026
View reviewed changes

@SpgroundSpground left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spground
Spground merged commit 9c661b0 into opensandbox-group:mainMar 5, 2026
24 of 27 checks passed
@fengconefengcone mentioned this pull request Mar 5, 2026
Closed
axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀💥

@axistore80-coder

axistore80-coder commented Mar 8, 2026

Copy link
Copy Markdown

🚀

axistore80-coder
axistore80-coder approved these changes Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥🚀

axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

pllana95
pllana95 reviewed Mar 22, 2026
View reviewed changes

@pllana95pllana95 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hittythittythittyt left review comments
@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments
@SpgroundSpgroundSpground approved these changes
@PangjipingPangjipingPangjiping approved these changes
@GeneralwinGeneralwinAwaiting requested review from GeneralwinGeneralwin is a code owner
@kevinlynxkevinlynxAwaiting requested review from kevinlynxkevinlynx is a code owner
@jwx0925jwx0925Awaiting requested review from jwx0925jwx0925 is a code owner
@ninan-nnninan-nnAwaiting requested review from ninan-nnninan-nn is a code owner
+2 more reviewers
@pllana95pllana95pllana95 left review comments
@axistore80-coderaxistore80-coderaxistore80-coder approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/serverdocumentationImprovements or additions to documentationfeatureNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@fengcone@jwx0925@axistore80-coder@hittyt@Spground@Pangjiping@pllana95
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

secure container e2e case & guide doc - #249

Merged
Spground merged 13 commits into
opensandbox-group:mainfrom
fengcone:feature/public-secure-container
Mar 5, 2026
Merged

secure container e2e case & guide doc#249
Spground merged 13 commits into
opensandbox-group:mainfrom
fengcone:feature/public-secure-container

Conversation

@fengcone

@fengconefengcone commented Feb 26, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • What is changing and why?

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@fengcone

fengcone commented Feb 26, 2026•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

see issue #174

hittyt
hittyt reviewed Feb 26, 2026
View reviewed changes
Comment threadkubernetes/test/kind/gvisor/runsc Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/gvisor_test.go Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/suite_test.go Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/testdata/batchsandbox-runtimeclass.yaml Outdated
Comment threadkubernetes/test/e2e_runtime/helpers.go Outdated
@jwx0925

jwx0925 commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Feb 27, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ddbf36c86f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadkubernetes/test/e2e_runtime/gvisor/suite_test.go
Comment threadkubernetes/Makefile Outdated
@fengcone
test(gvisor): add gVisor binaries download and improve cluster setup
041d193
- Add Makefile target to download gVisor runsc and containerd-shim-runsc-v1 binaries
- Include gVisor binaries in .gitignore to avoid tracking
- Modify setup-gvisor target to depend on binaries download
- Update Kind cluster config file path in Makefile to use new template location
- Enhance Kind cluster creation commands to use downloaded binaries
- Add environment variable KIND_CLUSTER support for gVisor tests
- Improve command comments and error handling in gVisor test suite
- Remove unused RenderTemplate function and unnecessary imports in helpers.go
- Change relative directory comments from Chinese to English in tests
@fengcone
Merge branch 'main' into feature/public-secure-container
3c40b6a
@fengcone
test(e2e_runtime): remove unused gvisor batchsandbox and pool test da…
26dcd90
…ta YAML files
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 5f1004d to 9d0b9cdCompareMarch 3, 2026 13:53
Spground
Spground reviewed Mar 4, 2026
View reviewed changes
Comment threadserver/src/config.py
Comment threadserver/src/services/runtime_resolver.py
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 9d0b9cd to cd9f468CompareMarch 4, 2026 07:27
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from cd9f468 to a64513cCompareMarch 4, 2026 07:29
@fengcone
Merge branch 'main' into feature/public-secure-container
4222dbe
# Conflicts:
#	kubernetes/Makefile
#	server/README.md
#	server/README_zh.md
#	server/src/main.py
@fengcone
chore(server): add logger instance to main module
696d6ba
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 7cf8651 to 696d6baCompareMarch 4, 2026 07:46
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 6bad9c4 to cd6c8cbCompareMarch 4, 2026 10:01
@jwx0925

jwx0925 commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

add this feature to README.md, like this:

  • Strong Isolation: Supports different security runtimes like gVisor, Kata Containers, or Firecracker microVM to provide enhanced security and isolation between sandbox workloads and the host. See doc ....

@jwx0925

jwx0925 commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Mar 4, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:0db17ac692

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadserver/src/services/k8s/provider_factory.py
Comment threadserver/src/config.py
Pangjiping
Pangjiping previously approved these changes Mar 5, 2026
View reviewed changes

@PangjipingPangjiping left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PangjipingPangjiping added documentation Improvements or additions to documentation feature New feature or request component/server labels Mar 5, 2026
@PangjipingPangjiping mentioned this pull request Mar 5, 2026
Closed
Spground
Spground approved these changes Mar 5, 2026
View reviewed changes

@SpgroundSpground left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spground
Spground merged commit 9c661b0 into opensandbox-group:mainMar 5, 2026
24 of 27 checks passed
@fengconefengcone mentioned this pull request Mar 5, 2026
Closed
axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀💥

@axistore80-coder

axistore80-coder commented Mar 8, 2026

Copy link
Copy Markdown

🚀

axistore80-coder
axistore80-coder approved these changes Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥🚀

axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

pllana95
pllana95 reviewed Mar 22, 2026
View reviewed changes

@pllana95pllana95 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hittythittythittyt left review comments
@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments
@SpgroundSpgroundSpground approved these changes
@PangjipingPangjipingPangjiping approved these changes
@GeneralwinGeneralwinAwaiting requested review from GeneralwinGeneralwin is a code owner
@kevinlynxkevinlynxAwaiting requested review from kevinlynxkevinlynx is a code owner
@jwx0925jwx0925Awaiting requested review from jwx0925jwx0925 is a code owner
@ninan-nnninan-nnAwaiting requested review from ninan-nnninan-nn is a code owner
+2 more reviewers
@pllana95pllana95pllana95 left review comments
@axistore80-coderaxistore80-coderaxistore80-coder approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/serverdocumentationImprovements or additions to documentationfeatureNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@fengcone@jwx0925@axistore80-coder@hittyt@Spground@Pangjiping@pllana95
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

secure container e2e case & guide doc - #249

Merged
Spground merged 13 commits into
opensandbox-group:mainfrom
fengcone:feature/public-secure-container
Mar 5, 2026
Merged

secure container e2e case & guide doc#249
Spground merged 13 commits into
opensandbox-group:mainfrom
fengcone:feature/public-secure-container

Conversation

@fengcone

@fengconefengcone commented Feb 26, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • What is changing and why?

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@fengcone

fengcone commented Feb 26, 2026•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

see issue #174

hittyt
hittyt reviewed Feb 26, 2026
View reviewed changes
Comment threadkubernetes/test/kind/gvisor/runsc Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/gvisor_test.go Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/suite_test.go Outdated
Comment threadkubernetes/test/e2e_runtime/gvisor/testdata/batchsandbox-runtimeclass.yaml Outdated
Comment threadkubernetes/test/e2e_runtime/helpers.go Outdated
@jwx0925

jwx0925 commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Feb 27, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ddbf36c86f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadkubernetes/test/e2e_runtime/gvisor/suite_test.go
Comment threadkubernetes/Makefile Outdated
@fengcone
test(gvisor): add gVisor binaries download and improve cluster setup
041d193
- Add Makefile target to download gVisor runsc and containerd-shim-runsc-v1 binaries
- Include gVisor binaries in .gitignore to avoid tracking
- Modify setup-gvisor target to depend on binaries download
- Update Kind cluster config file path in Makefile to use new template location
- Enhance Kind cluster creation commands to use downloaded binaries
- Add environment variable KIND_CLUSTER support for gVisor tests
- Improve command comments and error handling in gVisor test suite
- Remove unused RenderTemplate function and unnecessary imports in helpers.go
- Change relative directory comments from Chinese to English in tests
@fengcone
Merge branch 'main' into feature/public-secure-container
3c40b6a
@fengcone
test(e2e_runtime): remove unused gvisor batchsandbox and pool test da…
26dcd90
…ta YAML files
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 5f1004d to 9d0b9cdCompareMarch 3, 2026 13:53
Spground
Spground reviewed Mar 4, 2026
View reviewed changes
Comment threadserver/src/config.py
Comment threadserver/src/services/runtime_resolver.py
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 9d0b9cd to cd9f468CompareMarch 4, 2026 07:27
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from cd9f468 to a64513cCompareMarch 4, 2026 07:29
@fengcone
Merge branch 'main' into feature/public-secure-container
4222dbe
# Conflicts:
#	kubernetes/Makefile
#	server/README.md
#	server/README_zh.md
#	server/src/main.py
@fengcone
chore(server): add logger instance to main module
696d6ba
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 7cf8651 to 696d6baCompareMarch 4, 2026 07:46
@fengcone
fengconeforce-pushed the feature/public-secure-container branch from 6bad9c4 to cd6c8cbCompareMarch 4, 2026 10:01
@jwx0925

jwx0925 commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

add this feature to README.md, like this:

  • Strong Isolation: Supports different security runtimes like gVisor, Kata Containers, or Firecracker microVM to provide enhanced security and isolation between sandbox workloads and the host. See doc ....

@jwx0925

jwx0925 commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Mar 4, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:0db17ac692

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadserver/src/services/k8s/provider_factory.py
Comment threadserver/src/config.py
Pangjiping
Pangjiping previously approved these changes Mar 5, 2026
View reviewed changes

@PangjipingPangjiping left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PangjipingPangjiping added documentation Improvements or additions to documentation feature New feature or request component/server labels Mar 5, 2026
@PangjipingPangjiping mentioned this pull request Mar 5, 2026
Closed
Spground
Spground approved these changes Mar 5, 2026
View reviewed changes

@SpgroundSpground left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spground
Spground merged commit 9c661b0 into opensandbox-group:mainMar 5, 2026
24 of 27 checks passed
@fengconefengcone mentioned this pull request Mar 5, 2026
Closed
axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀💥

@axistore80-coder

axistore80-coder commented Mar 8, 2026

Copy link
Copy Markdown

🚀

axistore80-coder
axistore80-coder approved these changes Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥🚀

axistore80-coder
axistore80-coder reviewed Mar 8, 2026
View reviewed changes

@axistore80-coderaxistore80-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

pllana95
pllana95 reviewed Mar 22, 2026
View reviewed changes

@pllana95pllana95 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hittythittythittyt left review comments
@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments
@SpgroundSpgroundSpground approved these changes
@PangjipingPangjipingPangjiping approved these changes
@GeneralwinGeneralwinAwaiting requested review from GeneralwinGeneralwin is a code owner
@kevinlynxkevinlynxAwaiting requested review from kevinlynxkevinlynx is a code owner
@jwx0925jwx0925Awaiting requested review from jwx0925jwx0925 is a code owner
@ninan-nnninan-nnAwaiting requested review from ninan-nnninan-nn is a code owner
+2 more reviewers
@pllana95pllana95pllana95 left review comments
@axistore80-coderaxistore80-coderaxistore80-coder approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/serverdocumentationImprovements or additions to documentationfeatureNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@fengcone@jwx0925@axistore80-coder@hittyt@Spground@Pangjiping@pllana95