Skip to content

feat(server): Add pvc support in k8s runtime - #424

Merged
hittyt merged 1 commit into
opensandbox-group:mainfrom
Spground:feature/public-pvc-k8s-runtime
Mar 12, 2026
Merged

feat(server): Add pvc support in k8s runtime#424
hittyt merged 1 commit into
opensandbox-group:mainfrom
Spground:feature/public-pvc-k8s-runtime

Conversation

@Spground

@SpgroundSpground commented Mar 11, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • What is changing and why?

Add pvc volume in k8s runtime, users can use existing PVC to persist data in sandbox.

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification
image

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@chatgpt-codex-connector

chatgpt-codex-connectorBot commented Mar 11, 2026

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@SpgroundSpground added feature New feature or request component/server labels Mar 11, 2026
@Spground
Spgroundforce-pushed the feature/public-pvc-k8s-runtime branch from d4f025f to 5e291b8CompareMarch 11, 2026 12:40
hittyt
hittyt requested changes Mar 12, 2026
View reviewed changes

@hittythittyt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added support for Kubernetes PVC and HostPath volumes in K8s runtime, but several architectural and security improvements are needed, specifically regarding volume validation and code duplication.

Comment threadserver/src/services/k8s/kubernetes_service.py
Comment threadserver/src/services/k8s/agent_sandbox_provider.py
Comment threadserver/src/services/k8s/batchsandbox_provider.py
Comment threadserver/src/services/k8s/batchsandbox_provider.py Outdated
Comment threadserver/src/services/k8s/batchsandbox_provider.py Outdated
hittyt
hittyt reviewed Mar 12, 2026
View reviewed changes
Comment threadexamples/kubernetes-pvc-volume-mount/README.md Outdated
@Spground
Spgroundforce-pushed the feature/public-pvc-k8s-runtime branch from 5e291b8 to ed18cbbCompareMarch 12, 2026 09:41
@jwx0925

jwx0925 commented Mar 12, 2026

Copy link
Copy Markdown
Collaborator

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Mar 12, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ed18cbb959

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadserver/src/services/k8s/kubernetes_service.py
Comment threadserver/src/services/k8s/volume_helper.py
@Spground
Spgroundforce-pushed the feature/public-pvc-k8s-runtime branch from ed18cbb to 040a62eCompareMarch 12, 2026 10:44
hittyt
hittyt approved these changes Mar 12, 2026
View reviewed changes

@hittythittyt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hittyt
hittyt merged commit 112a9f0 into opensandbox-group:mainMar 12, 2026
10 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments
@hittythittythittyt approved these changes
@PangjipingPangjipingAwaiting requested review from PangjipingPangjiping is a code owner
@jwx0925jwx0925Awaiting requested review from jwx0925jwx0925 is a code owner
@GeneralwinGeneralwinAwaiting requested review from GeneralwinGeneralwin is a code owner
@ninan-nnninan-nnAwaiting requested review from ninan-nnninan-nn is a code owner

Assignees

@hittythittyt

@GeneralwinGeneralwin

@PangjipingPangjiping

Labels

component/serverfeatureNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Spground@jwx0925@hittyt@Generalwin@Pangjiping