Skip to content

oss fs for c#/kotlin - #563

Merged
hittyt merged 1 commit into
opensandbox-group:mainfrom
ninan-nn:feature/release_sdks_20260325
Mar 25, 2026
Merged

oss fs for c#/kotlin#563
hittyt merged 1 commit into
opensandbox-group:mainfrom
ninan-nn:feature/release_sdks_20260325

Conversation

@ninan-nn

@ninan-nnninan-nn commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

Add OSSFS volume backend support to the C# and Kotlin sandbox SDKs, and align the JavaScript SDK docs/comments now that OSSFS support has landed there.

Closes#476.

Changes:

  • sdks/sandbox/csharp: add OSSFS model, expose Volume.ossfs, and add serialization coverage for sandbox create payloads
  • sdks/sandbox/kotlin: add domain OSSFS model/builder, extend Volume validation to host/pvc/ossfs, wire OSSFS into API conversion, and add model + adapter tests
  • sdks/sandbox/javascript: update README/README_zh and public option comments so docs match the current ossfs support

Testing

  • Unit tests
    • Added/updated C# model serialization tests
    • Added/updated Kotlin model and adapter serialization tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@ninan-nnninan-nn self-assigned this Mar 25, 2026
@ninan-nn
ninan-nn requested a review from hittytMarch 25, 2026 02:31
@ninan-nnninan-nn removed their assignment Mar 25, 2026
@hittyt

Copy link
Copy Markdown
Collaborator

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@hittythittyt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hittyt
hittyt merged commit 490e1d1 into opensandbox-group:mainMar 25, 2026
11 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDK parity gaps: endpoint headers and OSSFS support are inconsistent across languages

3 participants

@ninan-nn@hittyt@Pangjiping