Uh oh!
There was an error while loading. Please reload this page.
Adds a new CoderTranslator for Java SchemaCoders. - #39594
Conversation
… a timer caused by drain. We then pass the residual restriction (if present) to ProcessElement.
This reverts commit 357fd26.
…er experiment instead of version compatibility number.
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
acrites
commented
Aug 3, 2026
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
acrites
commented
Aug 3, 2026
assign set of reviewers |
Assigning reviewers: R: @ahmedabu98 for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| @Override | ||
| public boolean isKnownCoder(Coder<?> coder, PipelineOptions options) { | ||
| if (coder.getClass() == SchemaCoder.class | ||
| && !ExperimentalOptions.hasExperiment(options, "use_known_schema_coder")) { |
There was a problem hiding this comment.
Since we have pipeline options now, we can check runner capability to translate to use SchemaCoder only when runner supported it. Then we don't need to worry about breaking changes on different runners for now.
There was a problem hiding this comment.
I don't think we want to start translating to a different portable pipeline for different runners, though... seems like the issue in #33859 (comment) should just be fixed.
There was a problem hiding this comment.
I've found that if I add Schemas to the list of coders to be ignored here it causes the previously failing post-commit (beam_PostCommit_Java_ValidatesRunner_ULR) to pass. This makes it so that Python treats the new schema urn as unknown and just passes it along as bytes.
With that change, should I go back to the previous implementation where we use the new schema coder type unless specifying compatibility 2.76 or earlier? i.e. start using this new coder type with 2.77 and later.
Reminder, please take a look at this pr: @ahmedabu98 |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @chamikaramj for label java. Available commands:
|
acrites
commented
Aug 21, 2026
I believe I've fixed the Python runner issues that previously caused this PR to get rolled back. I ran |
Abacn
commented
Aug 21, 2026
Thanks, this LGTM as
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #39594 +/- ##
============================================
+ Coverage 57.09% 57.17% +0.07%
Complexity 3639 3639 ============================================
Files 1191 1194 +3 Lines 192556 193273 +717 Branches 3816 3814 -2 ============================================
+ Hits 109946 110495 +549 - Misses 79042 79212 +170 + Partials 3568 3566 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The new translator splits out the Schema proto from the toRowFn and fromRowFn's so that runners can check the Schema proto for compatibility updates such as reordering fields. Previously, the coder was simply translated as a custom java coder, which runners couldn't reason about.
Since this is a potentially backwards incompatible change, this new coder format is guarded by the UpdateCompatibilityVersion StreamingOption being 2.76 (or earlier).
This fixes a few issues related to Schemas and pipeline updates: addresses #36496, #30276, #29245.
This PR is essentially a roll forward of the rollback #38514 with the breaking behavior in python fixed. I ran
:runners:portability:java:ulrLoopbackValidatesRunnerlocally with these changes and the tests now all pass.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.