From 937bd4fda518b9c9f867bdd43f30adc5bb358bf9 Mon Sep 17 00:00:00 2001 From: Yi Hu Date: Wed, 18 Jan 2023 12:56:38 -0500 Subject: [PATCH] Set maxConnections optional in incoming schema for JdbcSchemaIOProvider --- .../org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java b/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java index 5076f4a10298..77ec4082f6f4 100644 --- a/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java +++ b/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java @@ -175,9 +175,11 @@ protected JdbcIO.DataSourceConfiguration getDataSourceConfiguration() { dataSourceConfiguration = dataSourceConfiguration.withConnectionInitSqls(initSqls); } - @Nullable Integer maxConnections = config.getInt32("maxConnections"); - if (maxConnections != null) { - dataSourceConfiguration = dataSourceConfiguration.withMaxConnections(maxConnections); + if (config.getSchema().hasField("maxConnections")) { + @Nullable Integer maxConnections = config.getInt32("maxConnections"); + if (maxConnections != null) { + dataSourceConfiguration = dataSourceConfiguration.withMaxConnections(maxConnections); + } } return dataSourceConfiguration;