From 146c22a74ef35aca53843cb2480b36b5dc49c69c Mon Sep 17 00:00:00 2001 From: Ryan Blue Date: Fri, 1 Nov 2019 11:20:37 -0700 Subject: [PATCH 1/3] Move Java 8 check to deploy settings. --- build.gradle | 4 ---- deploy.gradle | 4 ++++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/build.gradle b/build.gradle index 69a49d9f1202..58360308ba0b 100644 --- a/build.gradle +++ b/build.gradle @@ -40,10 +40,6 @@ plugins { id 'com.palantir.consistent-versions' version '1.9.2' } -if (JavaVersion.current() != JavaVersion.VERSION_1_8) { - throw new GradleException("This build must be run with Java 8") -} - allprojects { group = "org.apache.iceberg" version = getProjectVersion() diff --git a/deploy.gradle b/deploy.gradle index 29e5a1f21231..2b3999b192d9 100644 --- a/deploy.gradle +++ b/deploy.gradle @@ -17,6 +17,10 @@ * under the License. */ +if (project.hasProperty('release') && JavaVersion.current() != JavaVersion.VERSION_1_8) { + throw new GradleException("Releases must be built with Java 8") +} + subprojects { apply plugin: 'maven' // make pom files for deployment apply plugin: 'maven-publish' From ad3578bde4b4e1d1f8cb963971d38b38f5eb61d0 Mon Sep 17 00:00:00 2001 From: Fokko Driesprong Date: Sun, 3 Nov 2019 11:45:48 +0100 Subject: [PATCH 2/3] Add JDK11 to Travis --- .travis.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.travis.yml b/.travis.yml index 01f12ff3d47f..2f9bd635f175 100644 --- a/.travis.yml +++ b/.travis.yml @@ -24,6 +24,18 @@ matrix: include: - language: java name: java + jdk: openjdk8 + before_cache: + - rm -f $HOME/.gradle/caches/modules-2/modules-2.lock + - rm -fr $HOME/.gradle/caches/*/plugin-resolution/ + cache: + directories: + - $HOME/.gradle/caches/ + - $HOME/.gradle/wrapper/ + + - language: java + name: java + jdk: openjdk11 before_cache: - rm -f $HOME/.gradle/caches/modules-2/modules-2.lock - rm -fr $HOME/.gradle/caches/*/plugin-resolution/ From ee6c0d1cb173a75ce780588e67029854ec337c49 Mon Sep 17 00:00:00 2001 From: Fokko Driesprong Date: Sun, 3 Nov 2019 12:19:15 +0100 Subject: [PATCH 3/3] Add if-else --- .../apache/iceberg/hive/HiveMetastoreTest.java | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/hive/src/test/java/org/apache/iceberg/hive/HiveMetastoreTest.java b/hive/src/test/java/org/apache/iceberg/hive/HiveMetastoreTest.java index 8d08aff88f21..7b363dec9a3e 100644 --- a/hive/src/test/java/org/apache/iceberg/hive/HiveMetastoreTest.java +++ b/hive/src/test/java/org/apache/iceberg/hive/HiveMetastoreTest.java @@ -49,13 +49,19 @@ public static void startMetastore() throws Exception { @AfterClass public static void stopMetastore() { - catalog.close(); - HiveMetastoreTest.catalog = null; + if(catalog != null) { + catalog.close(); + HiveMetastoreTest.catalog = null; + } - metastoreClient.close(); - HiveMetastoreTest.metastoreClient = null; + if(metastoreClient != null) { + metastoreClient.close(); + HiveMetastoreTest.metastoreClient = null; + } - metastore.stop(); - HiveMetastoreTest.metastore = null; + if(metastore != null) { + metastore.stop(); + HiveMetastoreTest.metastore = null; + } } }