Skip to content

PARQUET-367: "parquet-cat -j" doesn't show all records. - #281

Closed
sircodesalotOfTheRound wants to merge 1 commit into
apache:masterfrom
sircodesalotOfTheRound:fix-parquet-cat
Closed

PARQUET-367: "parquet-cat -j" doesn't show all records.#281
sircodesalotOfTheRound wants to merge 1 commit into
apache:masterfrom
sircodesalotOfTheRound:fix-parquet-cat

Conversation

@sircodesalotOfTheRound

Copy link
Copy Markdown
Contributor

Added JsonRecordFormatter which formats SimpleRecords into an structure that can be used with ObjectMapper to create a valid json structure. Unit test included.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to do this, we should put it on the side of the caller of execute(...).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why I added this actually... might have been a remnant from debugging. Will remove in final patch.

@julienledem

Copy link
Copy Markdown
Member

Thanks for the contribution!

Added JsonRecordFormatter which formats SimpleRecords into an structure that can be used with ObjectMapper to create a valid json structure. Unit test included.
@rdblue

rdblue commented Apr 21, 2016

Copy link
Copy Markdown
Contributor

@julienledem, did you want to commit this?

@asfgit asfgit closed this in da69d4b May 5, 2016
piyushnarang pushed a commit to piyushnarang/parquet-mr that referenced this pull request Jun 15, 2016
Added JsonRecordFormatter which formats SimpleRecords into an structure that can be used with ObjectMapper to create a valid json structure. Unit test included.

Author: Reuben Kuhnert <reuben.kuhnert@cloudera.com>

Closes apache#281 from sircodesalotOfTheRound/fix-parquet-cat and squashes the following commits:

67207ef [Reuben Kuhnert] PARQUET-367: "parquet-cat -j" doesn't show all records.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants