From a26011efba194ad2260be843f005afe21b55c315 Mon Sep 17 00:00:00 2001
From: Josiah VanderZee <jvanderzee@apache.org>
Date: Wed, 5 Aug 2026 09:28:28 -0500
Subject: [PATCH] Fix bad return in `validate_hostname`

The function has a `bool` return type, but returned `-1` to indicate an error
on UTF-8 conversion failure. This patch corrects the return statement to return `false`.
---
 src/tscore/X509HostnameValidator.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/tscore/X509HostnameValidator.cc b/src/tscore/X509HostnameValidator.cc
index 0efbcac99df..5d98b73f055 100644
--- a/src/tscore/X509HostnameValidator.cc
+++ b/src/tscore/X509HostnameValidator.cc
@@ -281,7 +281,7 @@ validate_hostname(X509 *x, std::string_view hostname, bool is_ip, char **peernam
     astrlen = ASN1_STRING_to_UTF8(&astr, str);
 
     if (astrlen < 0) {
-      return -1;
+      return false;
     }
     retval = equal(astr, astrlen, hostname_data, hostname_len);
     if (retval && peername) {