From 23a3e231b221e7c44d551b481d54d8123d17145a Mon Sep 17 00:00:00 2001 From: EMRG Evolution Date: Thu, 27 Aug 2026 08:46:43 +0800 Subject: [PATCH] emrg: fix flaky DialogHost rename prefill assertion (waitFor the useEffect-filled input) --- emrg/gui/renderer/src/components/DialogHost.test.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/emrg/gui/renderer/src/components/DialogHost.test.tsx b/emrg/gui/renderer/src/components/DialogHost.test.tsx index 85af9c05..809ee791 100644 --- a/emrg/gui/renderer/src/components/DialogHost.test.tsx +++ b/emrg/gui/renderer/src/components/DialogHost.test.tsx @@ -178,7 +178,9 @@ describe("DialogHost (Batch 5 slice 4)", () => { ref2.current?.openRename(); await waitFor(() => expect(screen.getByTestId("rename-dialog")).toBeInTheDocument()); const input = screen.getByTestId("rename-input") as HTMLInputElement; - expect(input.value).toBe("旧标题"); + // RenameDialog fills the input in a useEffect after mount — waitFor (flake + // fix: CI raced the effect and observed '' instead of the prefill). + await waitFor(() => expect(input.value).toBe("旧标题")); fireEvent.change(input, { target: { value: "新标题" } }); fireEvent.click(screen.getByTestId("rename-ok")); await waitFor(() => expect(calls2.renameSession.length).toBe(1));