Commit 13b34a3

Browse files
authored
test: remove 44 render-only and framework-testing tests (#998)
* test: remove 44 render-only and framework-testing tests Delete TUI component test files that only verify prop passthrough or framework behavior (Ink rendering, setInterval lifecycle) without testing any application logic: - Cursor.test.tsx (5 tests): setInterval/clearInterval assertions - Header.test.tsx (4 tests): title/subtitle string presence - HelpText.test.tsx (2 tests): static string rendering - AwsTargetConfigUI.test.tsx (7 tests): help text string lookups - ConfirmReview.test.tsx (6 tests): field label rendering - LogLink.test.tsx (4 tests): prop passthrough - ScreenHeader.test.tsx (3 tests): prop passthrough - FatalError.test.tsx (5 tests): prop passthrough Trim Panel.test.tsx (6→3) and Screen.test.tsx (8→3), keeping only tests that verify real logic: border structure, responsive width adaptation, keyboard exit handling, and exitEnabled guard. Remove tautological expect(true).toBe(true) tests from assets.snapshot.test.ts; use describe.skipIf for empty asset dirs. Kept all tests in StepIndicator, ScreenLayout, TwoColumn, NextSteps, LogPanel, PathInput, and useFetchAccessFlow — audit flagged some as framework tests but they verify real conditional/interaction logic. * fix: restore AwsTargetConfigUI tests — pure function, not render test getAwsConfigHelpText is a switch over AwsConfigPhase that maps states to help strings. The undefined return for loading/terminal phases is a contract consumed by DeployScreen.tsx via ?? HELP_TEXT.EXIT. These tests guard that fallback, not framework rendering behavior.
1 parent dd9270d commit 13b34a3

10 files changed

Lines changed: 12 additions & 426 deletions

File tree

‎src/assets/__tests__/assets.snapshot.test.ts‎

Lines changed: 10 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -87,36 +87,22 @@ describe('Assets Directory Snapshots', () => {
8787
});
8888
});
8989

90-
describe('Static assets',()=>{
90+
describe.skipIf(assetFiles.filter(f=>f.startsWith('static/')).length===0)('Static assets',()=>{
9191
conststaticFiles=assetFiles.filter(f=>f.startsWith('static/'));
9292

93-
if(staticFiles.length>0){
94-
it.each(staticFiles)('static/%s should match snapshot',file=>{
95-
constcontent=readFileContent(path.join(ASSETS_DIR,file));
96-
expect(content).toMatchSnapshot();
97-
});
98-
}else{
99-
it('static directory is empty or does not exist',()=>{
100-
// Static assets may not exist
101-
expect(true).toBe(true);
102-
});
103-
}
93+
it.each(staticFiles)('static/%s should match snapshot',file=>{
94+
constcontent=readFileContent(path.join(ASSETS_DIR,file));
95+
expect(content).toMatchSnapshot();
96+
});
10497
});
10598

106-
describe('TypeScript assets',()=>{
99+
describe.skipIf(assetFiles.filter(f=>f.startsWith('typescript/')).length===0)('TypeScript assets',()=>{
107100
consttsFiles=assetFiles.filter(f=>f.startsWith('typescript/'));
108101

109-
if(tsFiles.length>0){
110-
it.each(tsFiles)('typescript/%s should match snapshot',file=>{
111-
constcontent=readFileContent(path.join(ASSETS_DIR,file));
112-
expect(content).toMatchSnapshot();
113-
});
114-
}else{
115-
it('typescript directory is empty or contains only placeholder files',()=>{
116-
// TypeScript assets may not exist yet
117-
expect(true).toBe(true);
118-
});
119-
}
102+
it.each(tsFiles)('typescript/%s should match snapshot',file=>{
103+
constcontent=readFileContent(path.join(ASSETS_DIR,file));
104+
expect(content).toMatchSnapshot();
105+
});
120106
});
121107

122108
describe('Root-level assets',()=>{

‎src/cli/tui/components/__tests__/ConfirmReview.test.tsx‎

Lines changed: 0 additions & 89 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Cursor.test.tsx‎

Lines changed: 0 additions & 40 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/FatalError.test.tsx‎

Lines changed: 0 additions & 45 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Header.test.tsx‎

Lines changed: 0 additions & 34 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/HelpText.test.tsx‎

Lines changed: 0 additions & 20 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/LogLink.test.tsx‎

Lines changed: 0 additions & 30 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Panel.test.tsx‎

Lines changed: 2 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -25,57 +25,20 @@ describe('Panel', () => {
2525
);
2626
constframe=lastFrame()!;
2727
expect(frame).toContain('Panel body');
28-
// Verify border structure: top-left corner on first line, bottom-right on last
2928
constlines=frame.split('\n');
3029
expect(lines[0]).toContain('╭');
3130
expect(lines[lines.length-1]).toContain('╯');
3231
});
3332

34-
it('renders title as first line inside border when provided',()=>{
33+
it('renders title before body content',()=>{
3534
const{ lastFrame }=render(
3635
<Paneltitle="Settings">
3736
<Text>body</Text>
3837
</Panel>
3938
);
4039
constframe=lastFrame()!;
4140
expect(frame).toContain('Settings');
42-
expect(frame).toContain('body');
43-
// Title should appear before body in the output
44-
consttitleIdx=frame.indexOf('Settings');
45-
constbodyIdx=frame.indexOf('body');
46-
expect(titleIdx).toBeLessThan(bodyIdx);
47-
});
48-
49-
it('does not include title text when title is omitted',()=>{
50-
const{ lastFrame }=render(
51-
<Panel>
52-
<Text>body only</Text>
53-
</Panel>
54-
);
55-
constframe=lastFrame()!;
56-
expect(frame).toContain('body only');
57-
// The frame should only have border + body, no extra text before body
58-
constlines=frame.split('\n').filter(l=>l.trim().length>0);
59-
// First meaningful content line after the top border should be the body
60-
expect(lines.length).toBeGreaterThanOrEqual(3);// top border, body, bottom border
61-
});
62-
63-
it('renders with fullWidth when fullWidth prop is true',()=>{
64-
// With fullWidth=false (default), Panel uses contentWidth from context
65-
// With fullWidth=true, Panel uses 100%
66-
const{lastFrame: narrowFrame}=render(
67-
<Panel>
68-
<Text>narrow</Text>
69-
</Panel>
70-
);
71-
const{lastFrame: wideFrame}=render(
72-
<PanelfullWidth>
73-
<Text>wide</Text>
74-
</Panel>
75-
);
76-
// Both should render their content
77-
expect(narrowFrame()).toContain('narrow');
78-
expect(wideFrame()).toContain('wide');
41+
expect(frame.indexOf('Settings')).toBeLessThan(frame.indexOf('body'));
7942
});
8043

8144
it('adapts to different content widths from context',()=>{
@@ -93,23 +56,8 @@ describe('Panel', () => {
9356
</Panel>
9457
);
9558

96-
// Both render successfully — the narrow panel's top border should be shorter
9759
constnarrowTopLine=narrow()!.split('\n')[0]!;
9860
constwideTopLine=wide()!.split('\n')[0]!;
9961
expect(narrowTopLine.length).toBeLessThan(wideTopLine.length);
10062
});
101-
102-
it('renders with borderColor prop without breaking layout',()=>{
103-
const{ lastFrame }=render(
104-
<PanelborderColor="green">
105-
<Text>colored border</Text>
106-
</Panel>
107-
);
108-
constframe=lastFrame()!;
109-
expect(frame).toContain('colored border');
110-
// Border structure should still be intact
111-
constlines=frame.split('\n');
112-
expect(lines[0]).toContain('╭');
113-
expect(lines[lines.length-1]).toContain('╯');
114-
});
11563
});

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Commit 13b34a3

Browse files
authored
test: remove 44 render-only and framework-testing tests (#998)
* test: remove 44 render-only and framework-testing tests Delete TUI component test files that only verify prop passthrough or framework behavior (Ink rendering, setInterval lifecycle) without testing any application logic: - Cursor.test.tsx (5 tests): setInterval/clearInterval assertions - Header.test.tsx (4 tests): title/subtitle string presence - HelpText.test.tsx (2 tests): static string rendering - AwsTargetConfigUI.test.tsx (7 tests): help text string lookups - ConfirmReview.test.tsx (6 tests): field label rendering - LogLink.test.tsx (4 tests): prop passthrough - ScreenHeader.test.tsx (3 tests): prop passthrough - FatalError.test.tsx (5 tests): prop passthrough Trim Panel.test.tsx (6→3) and Screen.test.tsx (8→3), keeping only tests that verify real logic: border structure, responsive width adaptation, keyboard exit handling, and exitEnabled guard. Remove tautological expect(true).toBe(true) tests from assets.snapshot.test.ts; use describe.skipIf for empty asset dirs. Kept all tests in StepIndicator, ScreenLayout, TwoColumn, NextSteps, LogPanel, PathInput, and useFetchAccessFlow — audit flagged some as framework tests but they verify real conditional/interaction logic. * fix: restore AwsTargetConfigUI tests — pure function, not render test getAwsConfigHelpText is a switch over AwsConfigPhase that maps states to help strings. The undefined return for loading/terminal phases is a contract consumed by DeployScreen.tsx via ?? HELP_TEXT.EXIT. These tests guard that fallback, not framework rendering behavior.
1 parent dd9270d commit 13b34a3

10 files changed

Lines changed: 12 additions & 426 deletions

File tree

‎src/assets/__tests__/assets.snapshot.test.ts‎

Lines changed: 10 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -87,36 +87,22 @@ describe('Assets Directory Snapshots', () => {
8787
});
8888
});
8989

90-
describe('Static assets',()=>{
90+
describe.skipIf(assetFiles.filter(f=>f.startsWith('static/')).length===0)('Static assets',()=>{
9191
conststaticFiles=assetFiles.filter(f=>f.startsWith('static/'));
9292

93-
if(staticFiles.length>0){
94-
it.each(staticFiles)('static/%s should match snapshot',file=>{
95-
constcontent=readFileContent(path.join(ASSETS_DIR,file));
96-
expect(content).toMatchSnapshot();
97-
});
98-
}else{
99-
it('static directory is empty or does not exist',()=>{
100-
// Static assets may not exist
101-
expect(true).toBe(true);
102-
});
103-
}
93+
it.each(staticFiles)('static/%s should match snapshot',file=>{
94+
constcontent=readFileContent(path.join(ASSETS_DIR,file));
95+
expect(content).toMatchSnapshot();
96+
});
10497
});
10598

106-
describe('TypeScript assets',()=>{
99+
describe.skipIf(assetFiles.filter(f=>f.startsWith('typescript/')).length===0)('TypeScript assets',()=>{
107100
consttsFiles=assetFiles.filter(f=>f.startsWith('typescript/'));
108101

109-
if(tsFiles.length>0){
110-
it.each(tsFiles)('typescript/%s should match snapshot',file=>{
111-
constcontent=readFileContent(path.join(ASSETS_DIR,file));
112-
expect(content).toMatchSnapshot();
113-
});
114-
}else{
115-
it('typescript directory is empty or contains only placeholder files',()=>{
116-
// TypeScript assets may not exist yet
117-
expect(true).toBe(true);
118-
});
119-
}
102+
it.each(tsFiles)('typescript/%s should match snapshot',file=>{
103+
constcontent=readFileContent(path.join(ASSETS_DIR,file));
104+
expect(content).toMatchSnapshot();
105+
});
120106
});
121107

122108
describe('Root-level assets',()=>{

‎src/cli/tui/components/__tests__/ConfirmReview.test.tsx‎

Lines changed: 0 additions & 89 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Cursor.test.tsx‎

Lines changed: 0 additions & 40 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/FatalError.test.tsx‎

Lines changed: 0 additions & 45 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Header.test.tsx‎

Lines changed: 0 additions & 34 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/HelpText.test.tsx‎

Lines changed: 0 additions & 20 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/LogLink.test.tsx‎

Lines changed: 0 additions & 30 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Panel.test.tsx‎

Lines changed: 2 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -25,57 +25,20 @@ describe('Panel', () => {
2525
);
2626
constframe=lastFrame()!;
2727
expect(frame).toContain('Panel body');
28-
// Verify border structure: top-left corner on first line, bottom-right on last
2928
constlines=frame.split('\n');
3029
expect(lines[0]).toContain('╭');
3130
expect(lines[lines.length-1]).toContain('╯');
3231
});
3332

34-
it('renders title as first line inside border when provided',()=>{
33+
it('renders title before body content',()=>{
3534
const{ lastFrame }=render(
3635
<Paneltitle="Settings">
3736
<Text>body</Text>
3837
</Panel>
3938
);
4039
constframe=lastFrame()!;
4140
expect(frame).toContain('Settings');
42-
expect(frame).toContain('body');
43-
// Title should appear before body in the output
44-
consttitleIdx=frame.indexOf('Settings');
45-
constbodyIdx=frame.indexOf('body');
46-
expect(titleIdx).toBeLessThan(bodyIdx);
47-
});
48-
49-
it('does not include title text when title is omitted',()=>{
50-
const{ lastFrame }=render(
51-
<Panel>
52-
<Text>body only</Text>
53-
</Panel>
54-
);
55-
constframe=lastFrame()!;
56-
expect(frame).toContain('body only');
57-
// The frame should only have border + body, no extra text before body
58-
constlines=frame.split('\n').filter(l=>l.trim().length>0);
59-
// First meaningful content line after the top border should be the body
60-
expect(lines.length).toBeGreaterThanOrEqual(3);// top border, body, bottom border
61-
});
62-
63-
it('renders with fullWidth when fullWidth prop is true',()=>{
64-
// With fullWidth=false (default), Panel uses contentWidth from context
65-
// With fullWidth=true, Panel uses 100%
66-
const{lastFrame: narrowFrame}=render(
67-
<Panel>
68-
<Text>narrow</Text>
69-
</Panel>
70-
);
71-
const{lastFrame: wideFrame}=render(
72-
<PanelfullWidth>
73-
<Text>wide</Text>
74-
</Panel>
75-
);
76-
// Both should render their content
77-
expect(narrowFrame()).toContain('narrow');
78-
expect(wideFrame()).toContain('wide');
41+
expect(frame.indexOf('Settings')).toBeLessThan(frame.indexOf('body'));
7942
});
8043

8144
it('adapts to different content widths from context',()=>{
@@ -93,23 +56,8 @@ describe('Panel', () => {
9356
</Panel>
9457
);
9558

96-
// Both render successfully — the narrow panel's top border should be shorter
9759
constnarrowTopLine=narrow()!.split('\n')[0]!;
9860
constwideTopLine=wide()!.split('\n')[0]!;
9961
expect(narrowTopLine.length).toBeLessThan(wideTopLine.length);
10062
});
101-
102-
it('renders with borderColor prop without breaking layout',()=>{
103-
const{ lastFrame }=render(
104-
<PanelborderColor="green">
105-
<Text>colored border</Text>
106-
</Panel>
107-
);
108-
constframe=lastFrame()!;
109-
expect(frame).toContain('colored border');
110-
// Border structure should still be intact
111-
constlines=frame.split('\n');
112-
expect(lines[0]).toContain('╭');
113-
expect(lines[lines.length-1]).toContain('╯');
114-
});
11563
});

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 13b34a3

Browse files
authored
test: remove 44 render-only and framework-testing tests (#998)
* test: remove 44 render-only and framework-testing tests Delete TUI component test files that only verify prop passthrough or framework behavior (Ink rendering, setInterval lifecycle) without testing any application logic: - Cursor.test.tsx (5 tests): setInterval/clearInterval assertions - Header.test.tsx (4 tests): title/subtitle string presence - HelpText.test.tsx (2 tests): static string rendering - AwsTargetConfigUI.test.tsx (7 tests): help text string lookups - ConfirmReview.test.tsx (6 tests): field label rendering - LogLink.test.tsx (4 tests): prop passthrough - ScreenHeader.test.tsx (3 tests): prop passthrough - FatalError.test.tsx (5 tests): prop passthrough Trim Panel.test.tsx (6→3) and Screen.test.tsx (8→3), keeping only tests that verify real logic: border structure, responsive width adaptation, keyboard exit handling, and exitEnabled guard. Remove tautological expect(true).toBe(true) tests from assets.snapshot.test.ts; use describe.skipIf for empty asset dirs. Kept all tests in StepIndicator, ScreenLayout, TwoColumn, NextSteps, LogPanel, PathInput, and useFetchAccessFlow — audit flagged some as framework tests but they verify real conditional/interaction logic. * fix: restore AwsTargetConfigUI tests — pure function, not render test getAwsConfigHelpText is a switch over AwsConfigPhase that maps states to help strings. The undefined return for loading/terminal phases is a contract consumed by DeployScreen.tsx via ?? HELP_TEXT.EXIT. These tests guard that fallback, not framework rendering behavior.
1 parent dd9270d commit 13b34a3

10 files changed

Lines changed: 12 additions & 426 deletions

File tree

‎src/assets/__tests__/assets.snapshot.test.ts‎

Lines changed: 10 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -87,36 +87,22 @@ describe('Assets Directory Snapshots', () => {
8787
});
8888
});
8989

90-
describe('Static assets',()=>{
90+
describe.skipIf(assetFiles.filter(f=>f.startsWith('static/')).length===0)('Static assets',()=>{
9191
conststaticFiles=assetFiles.filter(f=>f.startsWith('static/'));
9292

93-
if(staticFiles.length>0){
94-
it.each(staticFiles)('static/%s should match snapshot',file=>{
95-
constcontent=readFileContent(path.join(ASSETS_DIR,file));
96-
expect(content).toMatchSnapshot();
97-
});
98-
}else{
99-
it('static directory is empty or does not exist',()=>{
100-
// Static assets may not exist
101-
expect(true).toBe(true);
102-
});
103-
}
93+
it.each(staticFiles)('static/%s should match snapshot',file=>{
94+
constcontent=readFileContent(path.join(ASSETS_DIR,file));
95+
expect(content).toMatchSnapshot();
96+
});
10497
});
10598

106-
describe('TypeScript assets',()=>{
99+
describe.skipIf(assetFiles.filter(f=>f.startsWith('typescript/')).length===0)('TypeScript assets',()=>{
107100
consttsFiles=assetFiles.filter(f=>f.startsWith('typescript/'));
108101

109-
if(tsFiles.length>0){
110-
it.each(tsFiles)('typescript/%s should match snapshot',file=>{
111-
constcontent=readFileContent(path.join(ASSETS_DIR,file));
112-
expect(content).toMatchSnapshot();
113-
});
114-
}else{
115-
it('typescript directory is empty or contains only placeholder files',()=>{
116-
// TypeScript assets may not exist yet
117-
expect(true).toBe(true);
118-
});
119-
}
102+
it.each(tsFiles)('typescript/%s should match snapshot',file=>{
103+
constcontent=readFileContent(path.join(ASSETS_DIR,file));
104+
expect(content).toMatchSnapshot();
105+
});
120106
});
121107

122108
describe('Root-level assets',()=>{

‎src/cli/tui/components/__tests__/ConfirmReview.test.tsx‎

Lines changed: 0 additions & 89 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Cursor.test.tsx‎

Lines changed: 0 additions & 40 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/FatalError.test.tsx‎

Lines changed: 0 additions & 45 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Header.test.tsx‎

Lines changed: 0 additions & 34 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/HelpText.test.tsx‎

Lines changed: 0 additions & 20 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/LogLink.test.tsx‎

Lines changed: 0 additions & 30 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Panel.test.tsx‎

Lines changed: 2 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -25,57 +25,20 @@ describe('Panel', () => {
2525
);
2626
constframe=lastFrame()!;
2727
expect(frame).toContain('Panel body');
28-
// Verify border structure: top-left corner on first line, bottom-right on last
2928
constlines=frame.split('\n');
3029
expect(lines[0]).toContain('╭');
3130
expect(lines[lines.length-1]).toContain('╯');
3231
});
3332

34-
it('renders title as first line inside border when provided',()=>{
33+
it('renders title before body content',()=>{
3534
const{ lastFrame }=render(
3635
<Paneltitle="Settings">
3736
<Text>body</Text>
3837
</Panel>
3938
);
4039
constframe=lastFrame()!;
4140
expect(frame).toContain('Settings');
42-
expect(frame).toContain('body');
43-
// Title should appear before body in the output
44-
consttitleIdx=frame.indexOf('Settings');
45-
constbodyIdx=frame.indexOf('body');
46-
expect(titleIdx).toBeLessThan(bodyIdx);
47-
});
48-
49-
it('does not include title text when title is omitted',()=>{
50-
const{ lastFrame }=render(
51-
<Panel>
52-
<Text>body only</Text>
53-
</Panel>
54-
);
55-
constframe=lastFrame()!;
56-
expect(frame).toContain('body only');
57-
// The frame should only have border + body, no extra text before body
58-
constlines=frame.split('\n').filter(l=>l.trim().length>0);
59-
// First meaningful content line after the top border should be the body
60-
expect(lines.length).toBeGreaterThanOrEqual(3);// top border, body, bottom border
61-
});
62-
63-
it('renders with fullWidth when fullWidth prop is true',()=>{
64-
// With fullWidth=false (default), Panel uses contentWidth from context
65-
// With fullWidth=true, Panel uses 100%
66-
const{lastFrame: narrowFrame}=render(
67-
<Panel>
68-
<Text>narrow</Text>
69-
</Panel>
70-
);
71-
const{lastFrame: wideFrame}=render(
72-
<PanelfullWidth>
73-
<Text>wide</Text>
74-
</Panel>
75-
);
76-
// Both should render their content
77-
expect(narrowFrame()).toContain('narrow');
78-
expect(wideFrame()).toContain('wide');
41+
expect(frame.indexOf('Settings')).toBeLessThan(frame.indexOf('body'));
7942
});
8043

8144
it('adapts to different content widths from context',()=>{
@@ -93,23 +56,8 @@ describe('Panel', () => {
9356
</Panel>
9457
);
9558

96-
// Both render successfully — the narrow panel's top border should be shorter
9759
constnarrowTopLine=narrow()!.split('\n')[0]!;
9860
constwideTopLine=wide()!.split('\n')[0]!;
9961
expect(narrowTopLine.length).toBeLessThan(wideTopLine.length);
10062
});
101-
102-
it('renders with borderColor prop without breaking layout',()=>{
103-
const{ lastFrame }=render(
104-
<PanelborderColor="green">
105-
<Text>colored border</Text>
106-
</Panel>
107-
);
108-
constframe=lastFrame()!;
109-
expect(frame).toContain('colored border');
110-
// Border structure should still be intact
111-
constlines=frame.split('\n');
112-
expect(lines[0]).toContain('╭');
113-
expect(lines[lines.length-1]).toContain('╯');
114-
});
11563
});

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 13b34a3

Browse files
authored
test: remove 44 render-only and framework-testing tests (#998)
* test: remove 44 render-only and framework-testing tests Delete TUI component test files that only verify prop passthrough or framework behavior (Ink rendering, setInterval lifecycle) without testing any application logic: - Cursor.test.tsx (5 tests): setInterval/clearInterval assertions - Header.test.tsx (4 tests): title/subtitle string presence - HelpText.test.tsx (2 tests): static string rendering - AwsTargetConfigUI.test.tsx (7 tests): help text string lookups - ConfirmReview.test.tsx (6 tests): field label rendering - LogLink.test.tsx (4 tests): prop passthrough - ScreenHeader.test.tsx (3 tests): prop passthrough - FatalError.test.tsx (5 tests): prop passthrough Trim Panel.test.tsx (6→3) and Screen.test.tsx (8→3), keeping only tests that verify real logic: border structure, responsive width adaptation, keyboard exit handling, and exitEnabled guard. Remove tautological expect(true).toBe(true) tests from assets.snapshot.test.ts; use describe.skipIf for empty asset dirs. Kept all tests in StepIndicator, ScreenLayout, TwoColumn, NextSteps, LogPanel, PathInput, and useFetchAccessFlow — audit flagged some as framework tests but they verify real conditional/interaction logic. * fix: restore AwsTargetConfigUI tests — pure function, not render test getAwsConfigHelpText is a switch over AwsConfigPhase that maps states to help strings. The undefined return for loading/terminal phases is a contract consumed by DeployScreen.tsx via ?? HELP_TEXT.EXIT. These tests guard that fallback, not framework rendering behavior.
1 parent dd9270d commit 13b34a3

10 files changed

Lines changed: 12 additions & 426 deletions

File tree

‎src/assets/__tests__/assets.snapshot.test.ts‎

Lines changed: 10 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -87,36 +87,22 @@ describe('Assets Directory Snapshots', () => {
8787
});
8888
});
8989

90-
describe('Static assets',()=>{
90+
describe.skipIf(assetFiles.filter(f=>f.startsWith('static/')).length===0)('Static assets',()=>{
9191
conststaticFiles=assetFiles.filter(f=>f.startsWith('static/'));
9292

93-
if(staticFiles.length>0){
94-
it.each(staticFiles)('static/%s should match snapshot',file=>{
95-
constcontent=readFileContent(path.join(ASSETS_DIR,file));
96-
expect(content).toMatchSnapshot();
97-
});
98-
}else{
99-
it('static directory is empty or does not exist',()=>{
100-
// Static assets may not exist
101-
expect(true).toBe(true);
102-
});
103-
}
93+
it.each(staticFiles)('static/%s should match snapshot',file=>{
94+
constcontent=readFileContent(path.join(ASSETS_DIR,file));
95+
expect(content).toMatchSnapshot();
96+
});
10497
});
10598

106-
describe('TypeScript assets',()=>{
99+
describe.skipIf(assetFiles.filter(f=>f.startsWith('typescript/')).length===0)('TypeScript assets',()=>{
107100
consttsFiles=assetFiles.filter(f=>f.startsWith('typescript/'));
108101

109-
if(tsFiles.length>0){
110-
it.each(tsFiles)('typescript/%s should match snapshot',file=>{
111-
constcontent=readFileContent(path.join(ASSETS_DIR,file));
112-
expect(content).toMatchSnapshot();
113-
});
114-
}else{
115-
it('typescript directory is empty or contains only placeholder files',()=>{
116-
// TypeScript assets may not exist yet
117-
expect(true).toBe(true);
118-
});
119-
}
102+
it.each(tsFiles)('typescript/%s should match snapshot',file=>{
103+
constcontent=readFileContent(path.join(ASSETS_DIR,file));
104+
expect(content).toMatchSnapshot();
105+
});
120106
});
121107

122108
describe('Root-level assets',()=>{

‎src/cli/tui/components/__tests__/ConfirmReview.test.tsx‎

Lines changed: 0 additions & 89 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Cursor.test.tsx‎

Lines changed: 0 additions & 40 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/FatalError.test.tsx‎

Lines changed: 0 additions & 45 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Header.test.tsx‎

Lines changed: 0 additions & 34 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/HelpText.test.tsx‎

Lines changed: 0 additions & 20 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/LogLink.test.tsx‎

Lines changed: 0 additions & 30 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Panel.test.tsx‎

Lines changed: 2 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -25,57 +25,20 @@ describe('Panel', () => {
2525
);
2626
constframe=lastFrame()!;
2727
expect(frame).toContain('Panel body');
28-
// Verify border structure: top-left corner on first line, bottom-right on last
2928
constlines=frame.split('\n');
3029
expect(lines[0]).toContain('╭');
3130
expect(lines[lines.length-1]).toContain('╯');
3231
});
3332

34-
it('renders title as first line inside border when provided',()=>{
33+
it('renders title before body content',()=>{
3534
const{ lastFrame }=render(
3635
<Paneltitle="Settings">
3736
<Text>body</Text>
3837
</Panel>
3938
);
4039
constframe=lastFrame()!;
4140
expect(frame).toContain('Settings');
42-
expect(frame).toContain('body');
43-
// Title should appear before body in the output
44-
consttitleIdx=frame.indexOf('Settings');
45-
constbodyIdx=frame.indexOf('body');
46-
expect(titleIdx).toBeLessThan(bodyIdx);
47-
});
48-
49-
it('does not include title text when title is omitted',()=>{
50-
const{ lastFrame }=render(
51-
<Panel>
52-
<Text>body only</Text>
53-
</Panel>
54-
);
55-
constframe=lastFrame()!;
56-
expect(frame).toContain('body only');
57-
// The frame should only have border + body, no extra text before body
58-
constlines=frame.split('\n').filter(l=>l.trim().length>0);
59-
// First meaningful content line after the top border should be the body
60-
expect(lines.length).toBeGreaterThanOrEqual(3);// top border, body, bottom border
61-
});
62-
63-
it('renders with fullWidth when fullWidth prop is true',()=>{
64-
// With fullWidth=false (default), Panel uses contentWidth from context
65-
// With fullWidth=true, Panel uses 100%
66-
const{lastFrame: narrowFrame}=render(
67-
<Panel>
68-
<Text>narrow</Text>
69-
</Panel>
70-
);
71-
const{lastFrame: wideFrame}=render(
72-
<PanelfullWidth>
73-
<Text>wide</Text>
74-
</Panel>
75-
);
76-
// Both should render their content
77-
expect(narrowFrame()).toContain('narrow');
78-
expect(wideFrame()).toContain('wide');
41+
expect(frame.indexOf('Settings')).toBeLessThan(frame.indexOf('body'));
7942
});
8043

8144
it('adapts to different content widths from context',()=>{
@@ -93,23 +56,8 @@ describe('Panel', () => {
9356
</Panel>
9457
);
9558

96-
// Both render successfully — the narrow panel's top border should be shorter
9759
constnarrowTopLine=narrow()!.split('\n')[0]!;
9860
constwideTopLine=wide()!.split('\n')[0]!;
9961
expect(narrowTopLine.length).toBeLessThan(wideTopLine.length);
10062
});
101-
102-
it('renders with borderColor prop without breaking layout',()=>{
103-
const{ lastFrame }=render(
104-
<PanelborderColor="green">
105-
<Text>colored border</Text>
106-
</Panel>
107-
);
108-
constframe=lastFrame()!;
109-
expect(frame).toContain('colored border');
110-
// Border structure should still be intact
111-
constlines=frame.split('\n');
112-
expect(lines[0]).toContain('╭');
113-
expect(lines[lines.length-1]).toContain('╯');
114-
});
11563
});

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Commit 13b34a3

Browse files
authored
test: remove 44 render-only and framework-testing tests (#998)
* test: remove 44 render-only and framework-testing tests Delete TUI component test files that only verify prop passthrough or framework behavior (Ink rendering, setInterval lifecycle) without testing any application logic: - Cursor.test.tsx (5 tests): setInterval/clearInterval assertions - Header.test.tsx (4 tests): title/subtitle string presence - HelpText.test.tsx (2 tests): static string rendering - AwsTargetConfigUI.test.tsx (7 tests): help text string lookups - ConfirmReview.test.tsx (6 tests): field label rendering - LogLink.test.tsx (4 tests): prop passthrough - ScreenHeader.test.tsx (3 tests): prop passthrough - FatalError.test.tsx (5 tests): prop passthrough Trim Panel.test.tsx (6→3) and Screen.test.tsx (8→3), keeping only tests that verify real logic: border structure, responsive width adaptation, keyboard exit handling, and exitEnabled guard. Remove tautological expect(true).toBe(true) tests from assets.snapshot.test.ts; use describe.skipIf for empty asset dirs. Kept all tests in StepIndicator, ScreenLayout, TwoColumn, NextSteps, LogPanel, PathInput, and useFetchAccessFlow — audit flagged some as framework tests but they verify real conditional/interaction logic. * fix: restore AwsTargetConfigUI tests — pure function, not render test getAwsConfigHelpText is a switch over AwsConfigPhase that maps states to help strings. The undefined return for loading/terminal phases is a contract consumed by DeployScreen.tsx via ?? HELP_TEXT.EXIT. These tests guard that fallback, not framework rendering behavior.
1 parent dd9270d commit 13b34a3

10 files changed

Lines changed: 12 additions & 426 deletions

File tree

‎src/assets/__tests__/assets.snapshot.test.ts‎

Lines changed: 10 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -87,36 +87,22 @@ describe('Assets Directory Snapshots', () => {
8787
});
8888
});
8989

90-
describe('Static assets',()=>{
90+
describe.skipIf(assetFiles.filter(f=>f.startsWith('static/')).length===0)('Static assets',()=>{
9191
conststaticFiles=assetFiles.filter(f=>f.startsWith('static/'));
9292

93-
if(staticFiles.length>0){
94-
it.each(staticFiles)('static/%s should match snapshot',file=>{
95-
constcontent=readFileContent(path.join(ASSETS_DIR,file));
96-
expect(content).toMatchSnapshot();
97-
});
98-
}else{
99-
it('static directory is empty or does not exist',()=>{
100-
// Static assets may not exist
101-
expect(true).toBe(true);
102-
});
103-
}
93+
it.each(staticFiles)('static/%s should match snapshot',file=>{
94+
constcontent=readFileContent(path.join(ASSETS_DIR,file));
95+
expect(content).toMatchSnapshot();
96+
});
10497
});
10598

106-
describe('TypeScript assets',()=>{
99+
describe.skipIf(assetFiles.filter(f=>f.startsWith('typescript/')).length===0)('TypeScript assets',()=>{
107100
consttsFiles=assetFiles.filter(f=>f.startsWith('typescript/'));
108101

109-
if(tsFiles.length>0){
110-
it.each(tsFiles)('typescript/%s should match snapshot',file=>{
111-
constcontent=readFileContent(path.join(ASSETS_DIR,file));
112-
expect(content).toMatchSnapshot();
113-
});
114-
}else{
115-
it('typescript directory is empty or contains only placeholder files',()=>{
116-
// TypeScript assets may not exist yet
117-
expect(true).toBe(true);
118-
});
119-
}
102+
it.each(tsFiles)('typescript/%s should match snapshot',file=>{
103+
constcontent=readFileContent(path.join(ASSETS_DIR,file));
104+
expect(content).toMatchSnapshot();
105+
});
120106
});
121107

122108
describe('Root-level assets',()=>{

‎src/cli/tui/components/__tests__/ConfirmReview.test.tsx‎

Lines changed: 0 additions & 89 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Cursor.test.tsx‎

Lines changed: 0 additions & 40 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/FatalError.test.tsx‎

Lines changed: 0 additions & 45 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Header.test.tsx‎

Lines changed: 0 additions & 34 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/HelpText.test.tsx‎

Lines changed: 0 additions & 20 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/LogLink.test.tsx‎

Lines changed: 0 additions & 30 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Panel.test.tsx‎

Lines changed: 2 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -25,57 +25,20 @@ describe('Panel', () => {
2525
);
2626
constframe=lastFrame()!;
2727
expect(frame).toContain('Panel body');
28-
// Verify border structure: top-left corner on first line, bottom-right on last
2928
constlines=frame.split('\n');
3029
expect(lines[0]).toContain('╭');
3130
expect(lines[lines.length-1]).toContain('╯');
3231
});
3332

34-
it('renders title as first line inside border when provided',()=>{
33+
it('renders title before body content',()=>{
3534
const{ lastFrame }=render(
3635
<Paneltitle="Settings">
3736
<Text>body</Text>
3837
</Panel>
3938
);
4039
constframe=lastFrame()!;
4140
expect(frame).toContain('Settings');
42-
expect(frame).toContain('body');
43-
// Title should appear before body in the output
44-
consttitleIdx=frame.indexOf('Settings');
45-
constbodyIdx=frame.indexOf('body');
46-
expect(titleIdx).toBeLessThan(bodyIdx);
47-
});
48-
49-
it('does not include title text when title is omitted',()=>{
50-
const{ lastFrame }=render(
51-
<Panel>
52-
<Text>body only</Text>
53-
</Panel>
54-
);
55-
constframe=lastFrame()!;
56-
expect(frame).toContain('body only');
57-
// The frame should only have border + body, no extra text before body
58-
constlines=frame.split('\n').filter(l=>l.trim().length>0);
59-
// First meaningful content line after the top border should be the body
60-
expect(lines.length).toBeGreaterThanOrEqual(3);// top border, body, bottom border
61-
});
62-
63-
it('renders with fullWidth when fullWidth prop is true',()=>{
64-
// With fullWidth=false (default), Panel uses contentWidth from context
65-
// With fullWidth=true, Panel uses 100%
66-
const{lastFrame: narrowFrame}=render(
67-
<Panel>
68-
<Text>narrow</Text>
69-
</Panel>
70-
);
71-
const{lastFrame: wideFrame}=render(
72-
<PanelfullWidth>
73-
<Text>wide</Text>
74-
</Panel>
75-
);
76-
// Both should render their content
77-
expect(narrowFrame()).toContain('narrow');
78-
expect(wideFrame()).toContain('wide');
41+
expect(frame.indexOf('Settings')).toBeLessThan(frame.indexOf('body'));
7942
});
8043

8144
it('adapts to different content widths from context',()=>{
@@ -93,23 +56,8 @@ describe('Panel', () => {
9356
</Panel>
9457
);
9558

96-
// Both render successfully — the narrow panel's top border should be shorter
9759
constnarrowTopLine=narrow()!.split('\n')[0]!;
9860
constwideTopLine=wide()!.split('\n')[0]!;
9961
expect(narrowTopLine.length).toBeLessThan(wideTopLine.length);
10062
});
101-
102-
it('renders with borderColor prop without breaking layout',()=>{
103-
const{ lastFrame }=render(
104-
<PanelborderColor="green">
105-
<Text>colored border</Text>
106-
</Panel>
107-
);
108-
constframe=lastFrame()!;
109-
expect(frame).toContain('colored border');
110-
// Border structure should still be intact
111-
constlines=frame.split('\n');
112-
expect(lines[0]).toContain('╭');
113-
expect(lines[lines.length-1]).toContain('╯');
114-
});
11563
});

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 13b34a3

Browse files
authored
test: remove 44 render-only and framework-testing tests (#998)
* test: remove 44 render-only and framework-testing tests Delete TUI component test files that only verify prop passthrough or framework behavior (Ink rendering, setInterval lifecycle) without testing any application logic: - Cursor.test.tsx (5 tests): setInterval/clearInterval assertions - Header.test.tsx (4 tests): title/subtitle string presence - HelpText.test.tsx (2 tests): static string rendering - AwsTargetConfigUI.test.tsx (7 tests): help text string lookups - ConfirmReview.test.tsx (6 tests): field label rendering - LogLink.test.tsx (4 tests): prop passthrough - ScreenHeader.test.tsx (3 tests): prop passthrough - FatalError.test.tsx (5 tests): prop passthrough Trim Panel.test.tsx (6→3) and Screen.test.tsx (8→3), keeping only tests that verify real logic: border structure, responsive width adaptation, keyboard exit handling, and exitEnabled guard. Remove tautological expect(true).toBe(true) tests from assets.snapshot.test.ts; use describe.skipIf for empty asset dirs. Kept all tests in StepIndicator, ScreenLayout, TwoColumn, NextSteps, LogPanel, PathInput, and useFetchAccessFlow — audit flagged some as framework tests but they verify real conditional/interaction logic. * fix: restore AwsTargetConfigUI tests — pure function, not render test getAwsConfigHelpText is a switch over AwsConfigPhase that maps states to help strings. The undefined return for loading/terminal phases is a contract consumed by DeployScreen.tsx via ?? HELP_TEXT.EXIT. These tests guard that fallback, not framework rendering behavior.
1 parent dd9270d commit 13b34a3

10 files changed

Lines changed: 12 additions & 426 deletions

File tree

‎src/assets/__tests__/assets.snapshot.test.ts‎

Lines changed: 10 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -87,36 +87,22 @@ describe('Assets Directory Snapshots', () => {
8787
});
8888
});
8989

90-
describe('Static assets',()=>{
90+
describe.skipIf(assetFiles.filter(f=>f.startsWith('static/')).length===0)('Static assets',()=>{
9191
conststaticFiles=assetFiles.filter(f=>f.startsWith('static/'));
9292

93-
if(staticFiles.length>0){
94-
it.each(staticFiles)('static/%s should match snapshot',file=>{
95-
constcontent=readFileContent(path.join(ASSETS_DIR,file));
96-
expect(content).toMatchSnapshot();
97-
});
98-
}else{
99-
it('static directory is empty or does not exist',()=>{
100-
// Static assets may not exist
101-
expect(true).toBe(true);
102-
});
103-
}
93+
it.each(staticFiles)('static/%s should match snapshot',file=>{
94+
constcontent=readFileContent(path.join(ASSETS_DIR,file));
95+
expect(content).toMatchSnapshot();
96+
});
10497
});
10598

106-
describe('TypeScript assets',()=>{
99+
describe.skipIf(assetFiles.filter(f=>f.startsWith('typescript/')).length===0)('TypeScript assets',()=>{
107100
consttsFiles=assetFiles.filter(f=>f.startsWith('typescript/'));
108101

109-
if(tsFiles.length>0){
110-
it.each(tsFiles)('typescript/%s should match snapshot',file=>{
111-
constcontent=readFileContent(path.join(ASSETS_DIR,file));
112-
expect(content).toMatchSnapshot();
113-
});
114-
}else{
115-
it('typescript directory is empty or contains only placeholder files',()=>{
116-
// TypeScript assets may not exist yet
117-
expect(true).toBe(true);
118-
});
119-
}
102+
it.each(tsFiles)('typescript/%s should match snapshot',file=>{
103+
constcontent=readFileContent(path.join(ASSETS_DIR,file));
104+
expect(content).toMatchSnapshot();
105+
});
120106
});
121107

122108
describe('Root-level assets',()=>{

‎src/cli/tui/components/__tests__/ConfirmReview.test.tsx‎

Lines changed: 0 additions & 89 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Cursor.test.tsx‎

Lines changed: 0 additions & 40 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/FatalError.test.tsx‎

Lines changed: 0 additions & 45 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Header.test.tsx‎

Lines changed: 0 additions & 34 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/HelpText.test.tsx‎

Lines changed: 0 additions & 20 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/LogLink.test.tsx‎

Lines changed: 0 additions & 30 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Panel.test.tsx‎

Lines changed: 2 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -25,57 +25,20 @@ describe('Panel', () => {
2525
);
2626
constframe=lastFrame()!;
2727
expect(frame).toContain('Panel body');
28-
// Verify border structure: top-left corner on first line, bottom-right on last
2928
constlines=frame.split('\n');
3029
expect(lines[0]).toContain('╭');
3130
expect(lines[lines.length-1]).toContain('╯');
3231
});
3332

34-
it('renders title as first line inside border when provided',()=>{
33+
it('renders title before body content',()=>{
3534
const{ lastFrame }=render(
3635
<Paneltitle="Settings">
3736
<Text>body</Text>
3837
</Panel>
3938
);
4039
constframe=lastFrame()!;
4140
expect(frame).toContain('Settings');
42-
expect(frame).toContain('body');
43-
// Title should appear before body in the output
44-
consttitleIdx=frame.indexOf('Settings');
45-
constbodyIdx=frame.indexOf('body');
46-
expect(titleIdx).toBeLessThan(bodyIdx);
47-
});
48-
49-
it('does not include title text when title is omitted',()=>{
50-
const{ lastFrame }=render(
51-
<Panel>
52-
<Text>body only</Text>
53-
</Panel>
54-
);
55-
constframe=lastFrame()!;
56-
expect(frame).toContain('body only');
57-
// The frame should only have border + body, no extra text before body
58-
constlines=frame.split('\n').filter(l=>l.trim().length>0);
59-
// First meaningful content line after the top border should be the body
60-
expect(lines.length).toBeGreaterThanOrEqual(3);// top border, body, bottom border
61-
});
62-
63-
it('renders with fullWidth when fullWidth prop is true',()=>{
64-
// With fullWidth=false (default), Panel uses contentWidth from context
65-
// With fullWidth=true, Panel uses 100%
66-
const{lastFrame: narrowFrame}=render(
67-
<Panel>
68-
<Text>narrow</Text>
69-
</Panel>
70-
);
71-
const{lastFrame: wideFrame}=render(
72-
<PanelfullWidth>
73-
<Text>wide</Text>
74-
</Panel>
75-
);
76-
// Both should render their content
77-
expect(narrowFrame()).toContain('narrow');
78-
expect(wideFrame()).toContain('wide');
41+
expect(frame.indexOf('Settings')).toBeLessThan(frame.indexOf('body'));
7942
});
8043

8144
it('adapts to different content widths from context',()=>{
@@ -93,23 +56,8 @@ describe('Panel', () => {
9356
</Panel>
9457
);
9558

96-
// Both render successfully — the narrow panel's top border should be shorter
9759
constnarrowTopLine=narrow()!.split('\n')[0]!;
9860
constwideTopLine=wide()!.split('\n')[0]!;
9961
expect(narrowTopLine.length).toBeLessThan(wideTopLine.length);
10062
});
101-
102-
it('renders with borderColor prop without breaking layout',()=>{
103-
const{ lastFrame }=render(
104-
<PanelborderColor="green">
105-
<Text>colored border</Text>
106-
</Panel>
107-
);
108-
constframe=lastFrame()!;
109-
expect(frame).toContain('colored border');
110-
// Border structure should still be intact
111-
constlines=frame.split('\n');
112-
expect(lines[0]).toContain('╭');
113-
expect(lines[lines.length-1]).toContain('╯');
114-
});
11563
});

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 13b34a3

Browse files
authored
test: remove 44 render-only and framework-testing tests (#998)
* test: remove 44 render-only and framework-testing tests Delete TUI component test files that only verify prop passthrough or framework behavior (Ink rendering, setInterval lifecycle) without testing any application logic: - Cursor.test.tsx (5 tests): setInterval/clearInterval assertions - Header.test.tsx (4 tests): title/subtitle string presence - HelpText.test.tsx (2 tests): static string rendering - AwsTargetConfigUI.test.tsx (7 tests): help text string lookups - ConfirmReview.test.tsx (6 tests): field label rendering - LogLink.test.tsx (4 tests): prop passthrough - ScreenHeader.test.tsx (3 tests): prop passthrough - FatalError.test.tsx (5 tests): prop passthrough Trim Panel.test.tsx (6→3) and Screen.test.tsx (8→3), keeping only tests that verify real logic: border structure, responsive width adaptation, keyboard exit handling, and exitEnabled guard. Remove tautological expect(true).toBe(true) tests from assets.snapshot.test.ts; use describe.skipIf for empty asset dirs. Kept all tests in StepIndicator, ScreenLayout, TwoColumn, NextSteps, LogPanel, PathInput, and useFetchAccessFlow — audit flagged some as framework tests but they verify real conditional/interaction logic. * fix: restore AwsTargetConfigUI tests — pure function, not render test getAwsConfigHelpText is a switch over AwsConfigPhase that maps states to help strings. The undefined return for loading/terminal phases is a contract consumed by DeployScreen.tsx via ?? HELP_TEXT.EXIT. These tests guard that fallback, not framework rendering behavior.
1 parent dd9270d commit 13b34a3

10 files changed

Lines changed: 12 additions & 426 deletions

File tree

‎src/assets/__tests__/assets.snapshot.test.ts‎

Lines changed: 10 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -87,36 +87,22 @@ describe('Assets Directory Snapshots', () => {
8787
});
8888
});
8989

90-
describe('Static assets',()=>{
90+
describe.skipIf(assetFiles.filter(f=>f.startsWith('static/')).length===0)('Static assets',()=>{
9191
conststaticFiles=assetFiles.filter(f=>f.startsWith('static/'));
9292

93-
if(staticFiles.length>0){
94-
it.each(staticFiles)('static/%s should match snapshot',file=>{
95-
constcontent=readFileContent(path.join(ASSETS_DIR,file));
96-
expect(content).toMatchSnapshot();
97-
});
98-
}else{
99-
it('static directory is empty or does not exist',()=>{
100-
// Static assets may not exist
101-
expect(true).toBe(true);
102-
});
103-
}
93+
it.each(staticFiles)('static/%s should match snapshot',file=>{
94+
constcontent=readFileContent(path.join(ASSETS_DIR,file));
95+
expect(content).toMatchSnapshot();
96+
});
10497
});
10598

106-
describe('TypeScript assets',()=>{
99+
describe.skipIf(assetFiles.filter(f=>f.startsWith('typescript/')).length===0)('TypeScript assets',()=>{
107100
consttsFiles=assetFiles.filter(f=>f.startsWith('typescript/'));
108101

109-
if(tsFiles.length>0){
110-
it.each(tsFiles)('typescript/%s should match snapshot',file=>{
111-
constcontent=readFileContent(path.join(ASSETS_DIR,file));
112-
expect(content).toMatchSnapshot();
113-
});
114-
}else{
115-
it('typescript directory is empty or contains only placeholder files',()=>{
116-
// TypeScript assets may not exist yet
117-
expect(true).toBe(true);
118-
});
119-
}
102+
it.each(tsFiles)('typescript/%s should match snapshot',file=>{
103+
constcontent=readFileContent(path.join(ASSETS_DIR,file));
104+
expect(content).toMatchSnapshot();
105+
});
120106
});
121107

122108
describe('Root-level assets',()=>{

‎src/cli/tui/components/__tests__/ConfirmReview.test.tsx‎

Lines changed: 0 additions & 89 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Cursor.test.tsx‎

Lines changed: 0 additions & 40 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/FatalError.test.tsx‎

Lines changed: 0 additions & 45 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Header.test.tsx‎

Lines changed: 0 additions & 34 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/HelpText.test.tsx‎

Lines changed: 0 additions & 20 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/LogLink.test.tsx‎

Lines changed: 0 additions & 30 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Panel.test.tsx‎

Lines changed: 2 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -25,57 +25,20 @@ describe('Panel', () => {
2525
);
2626
constframe=lastFrame()!;
2727
expect(frame).toContain('Panel body');
28-
// Verify border structure: top-left corner on first line, bottom-right on last
2928
constlines=frame.split('\n');
3029
expect(lines[0]).toContain('╭');
3130
expect(lines[lines.length-1]).toContain('╯');
3231
});
3332

34-
it('renders title as first line inside border when provided',()=>{
33+
it('renders title before body content',()=>{
3534
const{ lastFrame }=render(
3635
<Paneltitle="Settings">
3736
<Text>body</Text>
3837
</Panel>
3938
);
4039
constframe=lastFrame()!;
4140
expect(frame).toContain('Settings');
42-
expect(frame).toContain('body');
43-
// Title should appear before body in the output
44-
consttitleIdx=frame.indexOf('Settings');
45-
constbodyIdx=frame.indexOf('body');
46-
expect(titleIdx).toBeLessThan(bodyIdx);
47-
});
48-
49-
it('does not include title text when title is omitted',()=>{
50-
const{ lastFrame }=render(
51-
<Panel>
52-
<Text>body only</Text>
53-
</Panel>
54-
);
55-
constframe=lastFrame()!;
56-
expect(frame).toContain('body only');
57-
// The frame should only have border + body, no extra text before body
58-
constlines=frame.split('\n').filter(l=>l.trim().length>0);
59-
// First meaningful content line after the top border should be the body
60-
expect(lines.length).toBeGreaterThanOrEqual(3);// top border, body, bottom border
61-
});
62-
63-
it('renders with fullWidth when fullWidth prop is true',()=>{
64-
// With fullWidth=false (default), Panel uses contentWidth from context
65-
// With fullWidth=true, Panel uses 100%
66-
const{lastFrame: narrowFrame}=render(
67-
<Panel>
68-
<Text>narrow</Text>
69-
</Panel>
70-
);
71-
const{lastFrame: wideFrame}=render(
72-
<PanelfullWidth>
73-
<Text>wide</Text>
74-
</Panel>
75-
);
76-
// Both should render their content
77-
expect(narrowFrame()).toContain('narrow');
78-
expect(wideFrame()).toContain('wide');
41+
expect(frame.indexOf('Settings')).toBeLessThan(frame.indexOf('body'));
7942
});
8043

8144
it('adapts to different content widths from context',()=>{
@@ -93,23 +56,8 @@ describe('Panel', () => {
9356
</Panel>
9457
);
9558

96-
// Both render successfully — the narrow panel's top border should be shorter
9759
constnarrowTopLine=narrow()!.split('\n')[0]!;
9860
constwideTopLine=wide()!.split('\n')[0]!;
9961
expect(narrowTopLine.length).toBeLessThan(wideTopLine.length);
10062
});
101-
102-
it('renders with borderColor prop without breaking layout',()=>{
103-
const{ lastFrame }=render(
104-
<PanelborderColor="green">
105-
<Text>colored border</Text>
106-
</Panel>
107-
);
108-
constframe=lastFrame()!;
109-
expect(frame).toContain('colored border');
110-
// Border structure should still be intact
111-
constlines=frame.split('\n');
112-
expect(lines[0]).toContain('╭');
113-
expect(lines[lines.length-1]).toContain('╯');
114-
});
11563
});

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Commit 13b34a3

Browse files
authored
test: remove 44 render-only and framework-testing tests (#998)
* test: remove 44 render-only and framework-testing tests Delete TUI component test files that only verify prop passthrough or framework behavior (Ink rendering, setInterval lifecycle) without testing any application logic: - Cursor.test.tsx (5 tests): setInterval/clearInterval assertions - Header.test.tsx (4 tests): title/subtitle string presence - HelpText.test.tsx (2 tests): static string rendering - AwsTargetConfigUI.test.tsx (7 tests): help text string lookups - ConfirmReview.test.tsx (6 tests): field label rendering - LogLink.test.tsx (4 tests): prop passthrough - ScreenHeader.test.tsx (3 tests): prop passthrough - FatalError.test.tsx (5 tests): prop passthrough Trim Panel.test.tsx (6→3) and Screen.test.tsx (8→3), keeping only tests that verify real logic: border structure, responsive width adaptation, keyboard exit handling, and exitEnabled guard. Remove tautological expect(true).toBe(true) tests from assets.snapshot.test.ts; use describe.skipIf for empty asset dirs. Kept all tests in StepIndicator, ScreenLayout, TwoColumn, NextSteps, LogPanel, PathInput, and useFetchAccessFlow — audit flagged some as framework tests but they verify real conditional/interaction logic. * fix: restore AwsTargetConfigUI tests — pure function, not render test getAwsConfigHelpText is a switch over AwsConfigPhase that maps states to help strings. The undefined return for loading/terminal phases is a contract consumed by DeployScreen.tsx via ?? HELP_TEXT.EXIT. These tests guard that fallback, not framework rendering behavior.
1 parent dd9270d commit 13b34a3

10 files changed

Lines changed: 12 additions & 426 deletions

File tree

‎src/assets/__tests__/assets.snapshot.test.ts‎

Lines changed: 10 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -87,36 +87,22 @@ describe('Assets Directory Snapshots', () => {
8787
});
8888
});
8989

90-
describe('Static assets',()=>{
90+
describe.skipIf(assetFiles.filter(f=>f.startsWith('static/')).length===0)('Static assets',()=>{
9191
conststaticFiles=assetFiles.filter(f=>f.startsWith('static/'));
9292

93-
if(staticFiles.length>0){
94-
it.each(staticFiles)('static/%s should match snapshot',file=>{
95-
constcontent=readFileContent(path.join(ASSETS_DIR,file));
96-
expect(content).toMatchSnapshot();
97-
});
98-
}else{
99-
it('static directory is empty or does not exist',()=>{
100-
// Static assets may not exist
101-
expect(true).toBe(true);
102-
});
103-
}
93+
it.each(staticFiles)('static/%s should match snapshot',file=>{
94+
constcontent=readFileContent(path.join(ASSETS_DIR,file));
95+
expect(content).toMatchSnapshot();
96+
});
10497
});
10598

106-
describe('TypeScript assets',()=>{
99+
describe.skipIf(assetFiles.filter(f=>f.startsWith('typescript/')).length===0)('TypeScript assets',()=>{
107100
consttsFiles=assetFiles.filter(f=>f.startsWith('typescript/'));
108101

109-
if(tsFiles.length>0){
110-
it.each(tsFiles)('typescript/%s should match snapshot',file=>{
111-
constcontent=readFileContent(path.join(ASSETS_DIR,file));
112-
expect(content).toMatchSnapshot();
113-
});
114-
}else{
115-
it('typescript directory is empty or contains only placeholder files',()=>{
116-
// TypeScript assets may not exist yet
117-
expect(true).toBe(true);
118-
});
119-
}
102+
it.each(tsFiles)('typescript/%s should match snapshot',file=>{
103+
constcontent=readFileContent(path.join(ASSETS_DIR,file));
104+
expect(content).toMatchSnapshot();
105+
});
120106
});
121107

122108
describe('Root-level assets',()=>{

‎src/cli/tui/components/__tests__/ConfirmReview.test.tsx‎

Lines changed: 0 additions & 89 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Cursor.test.tsx‎

Lines changed: 0 additions & 40 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/FatalError.test.tsx‎

Lines changed: 0 additions & 45 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Header.test.tsx‎

Lines changed: 0 additions & 34 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/HelpText.test.tsx‎

Lines changed: 0 additions & 20 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/LogLink.test.tsx‎

Lines changed: 0 additions & 30 deletions
This file was deleted.

‎src/cli/tui/components/__tests__/Panel.test.tsx‎

Lines changed: 2 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -25,57 +25,20 @@ describe('Panel', () => {
2525
);
2626
constframe=lastFrame()!;
2727
expect(frame).toContain('Panel body');
28-
// Verify border structure: top-left corner on first line, bottom-right on last
2928
constlines=frame.split('\n');
3029
expect(lines[0]).toContain('╭');
3130
expect(lines[lines.length-1]).toContain('╯');
3231
});
3332

34-
it('renders title as first line inside border when provided',()=>{
33+
it('renders title before body content',()=>{
3534
const{ lastFrame }=render(
3635
<Paneltitle="Settings">
3736
<Text>body</Text>
3837
</Panel>
3938
);
4039
constframe=lastFrame()!;
4140
expect(frame).toContain('Settings');
42-
expect(frame).toContain('body');
43-
// Title should appear before body in the output
44-
consttitleIdx=frame.indexOf('Settings');
45-
constbodyIdx=frame.indexOf('body');
46-
expect(titleIdx).toBeLessThan(bodyIdx);
47-
});
48-
49-
it('does not include title text when title is omitted',()=>{
50-
const{ lastFrame }=render(
51-
<Panel>
52-
<Text>body only</Text>
53-
</Panel>
54-
);
55-
constframe=lastFrame()!;
56-
expect(frame).toContain('body only');
57-
// The frame should only have border + body, no extra text before body
58-
constlines=frame.split('\n').filter(l=>l.trim().length>0);
59-
// First meaningful content line after the top border should be the body
60-
expect(lines.length).toBeGreaterThanOrEqual(3);// top border, body, bottom border
61-
});
62-
63-
it('renders with fullWidth when fullWidth prop is true',()=>{
64-
// With fullWidth=false (default), Panel uses contentWidth from context
65-
// With fullWidth=true, Panel uses 100%
66-
const{lastFrame: narrowFrame}=render(
67-
<Panel>
68-
<Text>narrow</Text>
69-
</Panel>
70-
);
71-
const{lastFrame: wideFrame}=render(
72-
<PanelfullWidth>
73-
<Text>wide</Text>
74-
</Panel>
75-
);
76-
// Both should render their content
77-
expect(narrowFrame()).toContain('narrow');
78-
expect(wideFrame()).toContain('wide');
41+
expect(frame.indexOf('Settings')).toBeLessThan(frame.indexOf('body'));
7942
});
8043

8144
it('adapts to different content widths from context',()=>{
@@ -93,23 +56,8 @@ describe('Panel', () => {
9356
</Panel>
9457
);
9558

96-
// Both render successfully — the narrow panel's top border should be shorter
9759
constnarrowTopLine=narrow()!.split('\n')[0]!;
9860
constwideTopLine=wide()!.split('\n')[0]!;
9961
expect(narrowTopLine.length).toBeLessThan(wideTopLine.length);
10062
});
101-
102-
it('renders with borderColor prop without breaking layout',()=>{
103-
const{ lastFrame }=render(
104-
<PanelborderColor="green">
105-
<Text>colored border</Text>
106-
</Panel>
107-
);
108-
constframe=lastFrame()!;
109-
expect(frame).toContain('colored border');
110-
// Border structure should still be intact
111-
constlines=frame.split('\n');
112-
expect(lines[0]).toContain('╭');
113-
expect(lines[lines.length-1]).toContain('╯');
114-
});
11563
});

0 commit comments

Comments
 (0)