feat(builtin): add basic ESM support

Author: Fabian Wiles

.npmrc

@@ -1,2 +1,3 @@
 tag-version-prefix=""
 message="chore(release): %s"
+registry=https://registry.npmjs.org

internal/linker/index.js

@@ -12,7 +12,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.main=exports.reduceModules=void0;
 constfs=require("fs");
 constpath=require("path");
-const{runfiles: _defaultRunfiles,_BAZEL_OUT_REGEX}=require('../runfiles/index.js');
+const{runfiles: _defaultRunfiles,_BAZEL_OUT_REGEX}=require('../runfiles/index.cjs');
 constVERBOSE_LOGS=!!process.env['VERBOSE_LOGS'];
 functionlog_verbose(...m){
 if(VERBOSE_LOGS)

internal/linker/test/integration/BUILD.bazel

@@ -40,8 +40,8 @@ sh_binary(
 # "runfiles" module mappings from `:some_program` in `:run_program` under the
 ":some_program",
 "//internal/linker:index.js",
-"//internal/runfiles:index.js",
-"//internal/runfiles:runfile_helper_main.js",
+"//internal/runfiles:index.cjs",
+"//internal/runfiles:runfile_helper_main.cjs",
 "//internal/linker/test/integration/static_linked_pkg",
 "//internal/linker/test/integration/static_linked_scoped_pkg",
 "//internal/linker/test/integration/absolute_import:index.js",

internal/node/BUILD.bazel

@@ -18,9 +18,9 @@ load("@build_bazel_rules_nodejs//:index.bzl", "generated_file_test")
 package(default_visibility= ["//visibility:public"])
 
 exports_files([
-"node_patches.js",
-"require_patch.js",
-"loader.js",
+"node_patches.cjs",
+"require_patch.cjs",
+"loader.cjs",
 ])
 
 bzl_library(
@@ -40,7 +40,7 @@ exports_files([
 "node.bzl", # Exported to be consumed for generating stardoc.
 "node_repositories.bzl", # Exported to be consumed for generating stardoc.
 "launcher.sh",
-"loader.js",
+"loader.cjs",
 ])
 
 filegroup(
@@ -60,7 +60,7 @@ filegroup(
 # bazel run //internal/node:checked_in_node_patches.update
 generated_file_test(
 name="checked_in_node_patches",
-src="node_patches.js",
+src="node_patches.cjs",
 generated="//packages/node-patches:bundle",
 # For some reason rollup produces different, non-matching output with --config=no-runfiles
 tags= ["fix-windows"],

internal/node/loader.js internal/node/loader.cjsinternal/node/loader.js renamed to internal/node/loader.cjs

@@ -593,25 +593,25 @@ Predefined genrule variables are not supported in this context.
 allow_single_file=True,
  ),
 "_loader_template": attr.label(
-default=Label("//internal/node:loader.js"),
+default=Label("//internal/node:loader.cjs"),
 allow_single_file=True,
  ),
 "toolchain": attr.label(),
 "_node_args": attr.label(default="@rules_nodejs//nodejs:default_args"),
 "_node_patches_script": attr.label(
-default=Label("//internal/node:node_patches.js"),
+default=Label("//internal/node:node_patches.cjs"),
 allow_single_file=True,
  ),
 "_require_patch_template": attr.label(
-default=Label("//internal/node:require_patch.js"),
+default=Label("//internal/node:require_patch.cjs"),
 allow_single_file=True,
  ),
 "_runfile_helpers_bundle": attr.label(
-default=Label("//internal/runfiles:index.js"),
+default=Label("//internal/runfiles:index.cjs"),
 allow_single_file=True,
  ),
 "_runfile_helpers_main": attr.label(
-default=Label("//internal/runfiles:runfile_helper_main.js"),
+default=Label("//internal/runfiles:runfile_helper_main.cjs"),
 allow_single_file=True,
  ),
 "_source_map_support_files": attr.label_list(

internal/node/node.bzl

@@ -0,0 +1,17 @@
+load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
+
+nodejs_binary(
+name="has_deps",
+data= [
+"has-deps.mjs",
+"@fine_grained_deps_yarn//typescript",
+ ],
+entry_point=":has-deps.mjs",
+)
+
+
+nodejs_binary(
+name="no_deps",
+data= ["no-deps.mjs"],
+entry_point=":no-deps.mjs",
+)

internal/node/node_patches.js internal/node/node_patches.cjsinternal/node/node_patches.js renamed to internal/node/node_patches.cjs

@@ -0,0 +1,3 @@
+importtsfrom'typescript';
+
+console.log('a node script with a dep on typescript',ts.version);