From e48af47c5a674904cd03b270d7cc759a6dfbb657 Mon Sep 17 00:00:00 2001 From: panteliselef Date: Mon, 25 Nov 2024 20:37:26 +0200 Subject: [PATCH 1/3] fix(clerk-js): Persist "this" when revoking a session, from UserProfile --- .changeset/mean-apples-approve.md | 5 +++++ .../src/ui/components/UserProfile/ActiveDevicesSection.tsx | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 .changeset/mean-apples-approve.md diff --git a/.changeset/mean-apples-approve.md b/.changeset/mean-apples-approve.md new file mode 100644 index 00000000000..776b846ba5c --- /dev/null +++ b/.changeset/mean-apples-approve.md @@ -0,0 +1,5 @@ +--- +'@clerk/clerk-js': patch +--- + +Bug fix: Being able to revoke a session from UserProfile. diff --git a/packages/clerk-js/src/ui/components/UserProfile/ActiveDevicesSection.tsx b/packages/clerk-js/src/ui/components/UserProfile/ActiveDevicesSection.tsx index 5d0f2381635..0ab9f28d81c 100644 --- a/packages/clerk-js/src/ui/components/UserProfile/ActiveDevicesSection.tsx +++ b/packages/clerk-js/src/ui/components/UserProfile/ActiveDevicesSection.tsx @@ -15,6 +15,8 @@ export const ActiveDevicesSection = () => { const { data: sessions, isLoading } = useFetch(user?.getSessions, 'user-sessions'); + console.log('alll', sessions); + return ( { const DeviceItem = ({ session }: { session: SessionWithActivitiesResource }) => { const isCurrent = useSession().session?.id === session.id; const status = useLoadingStatus(); - const [revokeSession] = useReverification(session.revoke); + const [revokeSession] = useReverification(session.revoke.bind(session)); const revoke = async () => { if (isCurrent || !session) { From e306bc162efc0245cbddac97416b9369d30ea471 Mon Sep 17 00:00:00 2001 From: panteliselef Date: Mon, 25 Nov 2024 20:43:49 +0200 Subject: [PATCH 2/3] remove log --- .../src/ui/components/UserProfile/ActiveDevicesSection.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/clerk-js/src/ui/components/UserProfile/ActiveDevicesSection.tsx b/packages/clerk-js/src/ui/components/UserProfile/ActiveDevicesSection.tsx index 0ab9f28d81c..d13aa8a5b31 100644 --- a/packages/clerk-js/src/ui/components/UserProfile/ActiveDevicesSection.tsx +++ b/packages/clerk-js/src/ui/components/UserProfile/ActiveDevicesSection.tsx @@ -15,8 +15,6 @@ export const ActiveDevicesSection = () => { const { data: sessions, isLoading } = useFetch(user?.getSessions, 'user-sessions'); - console.log('alll', sessions); - return ( Date: Mon, 25 Nov 2024 22:06:21 +0200 Subject: [PATCH 3/3] fix tests --- .../ui/components/UserProfile/__tests__/SecurityPage.test.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/clerk-js/src/ui/components/UserProfile/__tests__/SecurityPage.test.tsx b/packages/clerk-js/src/ui/components/UserProfile/__tests__/SecurityPage.test.tsx index f4c8ed948ba..384ef6f22b5 100644 --- a/packages/clerk-js/src/ui/components/UserProfile/__tests__/SecurityPage.test.tsx +++ b/packages/clerk-js/src/ui/components/UserProfile/__tests__/SecurityPage.test.tsx @@ -113,6 +113,7 @@ describe('SecurityPage', () => { isMobile: false, }, actor: null, + revoke: jest.fn().mockResolvedValue({}), } as any as SessionWithActivitiesResource, { pathRoot: '/me/sessions', @@ -131,6 +132,7 @@ describe('SecurityPage', () => { isMobile: false, }, actor: null, + revoke: jest.fn().mockResolvedValue({}), } as any as SessionWithActivitiesResource, ]), );