From c3b5bda0014900aed5ca822f418fa823e0c4d8fa Mon Sep 17 00:00:00 2001 From: Jacek Date: Mon, 10 Mar 2025 21:07:17 -0500 Subject: [PATCH 1/3] chore/backend-remove-ts-ignores --- packages/backend/src/api/request.ts | 3 +-- .../backend/src/util/decorateObjectWithResources.ts | 10 ++++++---- packages/backend/tsup.config.ts | 1 - 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/backend/src/api/request.ts b/packages/backend/src/api/request.ts index b52b81edc13..884e362ba66 100644 --- a/packages/backend/src/api/request.ts +++ b/packages/backend/src/api/request.ts @@ -193,8 +193,7 @@ type LegacyRequestFunction = (requestOptions: ClerkBackendApiRequestOptions) // TODO(dimkl): Will be probably be dropped in next major version function withLegacyRequestReturn(cb: any): LegacyRequestFunction { return async (...args) => { - // @ts-ignore - const { data, errors, totalCount, status, statusText, clerkTraceId } = await cb(...args); + const { data, errors, totalCount, status, statusText, clerkTraceId } = await cb(...args); if (errors) { // instead of passing `data: errors`, we have set the `error.errors` because // the errors returned from callback is already parsed and passing them as `data` diff --git a/packages/backend/src/util/decorateObjectWithResources.ts b/packages/backend/src/util/decorateObjectWithResources.ts index 924c2e6e00d..4e90ff94ccd 100644 --- a/packages/backend/src/util/decorateObjectWithResources.ts +++ b/packages/backend/src/util/decorateObjectWithResources.ts @@ -55,10 +55,12 @@ export function stripPrivateDataFromObject>(auth function prunePrivateMetadata(resource?: { private_metadata: any } | { privateMetadata: any } | null) { // Delete sensitive private metadata from resource before rendering in SSR if (resource) { - // @ts-ignore - delete resource['privateMetadata']; - // @ts-ignore - delete resource['private_metadata']; + if ('privateMetadata' in resource) { + delete resource['privateMetadata']; + } + if ('private_metadata' in resource) { + delete resource['private_metadata']; + } } return resource; diff --git a/packages/backend/tsup.config.ts b/packages/backend/tsup.config.ts index e5ea7c95987..06a9cf3c27c 100644 --- a/packages/backend/tsup.config.ts +++ b/packages/backend/tsup.config.ts @@ -2,7 +2,6 @@ import type { Options } from 'tsup'; import { defineConfig } from 'tsup'; import { runAfterLast } from '../../scripts/utils'; -// @ts-ignore import { name, version } from './package.json'; export default defineConfig(overrideOptions => { From 4e17bb97bc88ebb446b84721ea8e7ad50af32fa2 Mon Sep 17 00:00:00 2001 From: Jacek Date: Tue, 11 Mar 2025 10:19:38 -0500 Subject: [PATCH 2/3] changeset --- .changeset/quick-countries-learn.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/quick-countries-learn.md diff --git a/.changeset/quick-countries-learn.md b/.changeset/quick-countries-learn.md new file mode 100644 index 00000000000..25555d8f31f --- /dev/null +++ b/.changeset/quick-countries-learn.md @@ -0,0 +1,5 @@ +--- +'@clerk/backend': patch +--- + +Refactoring code to remove @ts-ignore directives From 9ed99881e9f1c8bb9dab79b9b3f720a25a3f9d75 Mon Sep 17 00:00:00 2001 From: Jacek Date: Wed, 12 Mar 2025 07:45:24 -0500 Subject: [PATCH 3/3] lockfile --- pnpm-lock.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 93f3dbd6052..cd5c0b2352f 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -2804,7 +2804,7 @@ packages: '@expo/bunyan@4.0.1': resolution: {integrity: sha512-+Lla7nYSiHZirgK+U/uYzsLv/X+HaJienbD5AKX1UQZHYfWaP+9uuQluRB4GrEVWF0GZ7vEVp/jzaOT9k/SQlg==} - engines: {'0': node >=0.10.0} + engines: {node: '>=0.10.0'} '@expo/cli@0.18.30': resolution: {integrity: sha512-V90TUJh9Ly8stYo8nwqIqNWCsYjE28GlVFWEhAFCUOp99foiQr8HSTpiiX5GIrprcPoWmlGoY+J5fQA29R4lFg==}