Uh oh!
There was an error while loading. Please reload this page.
5️⃣ <OrganizationProfile/> List, add, edit, remove Domains - #1560
Conversation
🦋 Changeset detectedLatest commit: 3dc622a The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
commented
Aug 9, 2023
!snapshot |
clerk-cookie
commented
Aug 9, 2023
Hey @panteliselef - the snapshot version command generated the following package versions:
Tip: use the snippet copy button below to quickly install the required packages. # @clerk/backend
npm i @clerk/backend@0.28.0-snapshot.0b0cc93# @clerk/chrome-extension
npm i @clerk/chrome-extension@0.3.27-snapshot.0b0cc93# @clerk/clerk-js
npm i @clerk/clerk-js@4.56.0-snapshot.0b0cc93# eslint-config-custom
npm i eslint-config-custom@0.3.0# @clerk/clerk-expo
npm i @clerk/clerk-expo@0.18.18-snapshot.0b0cc93# @clerk/fastify
npm i @clerk/fastify@0.6.4-snapshot.0b0cc93# gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.4.5-snapshot.0b0cc93# @clerk/localizations
npm i @clerk/localizations@1.24.2-snapshot.0b0cc93# @clerk/nextjs
npm i @clerk/nextjs@4.23.3-snapshot.0b0cc93# @clerk/clerk-react
npm i @clerk/clerk-react@4.24.0-snapshot.0b0cc93# @clerk/remix
npm i @clerk/remix@2.10.0-snapshot.0b0cc93# @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.12.3-snapshot.0b0cc93# @clerk/shared
npm i @clerk/shared@0.22.0-snapshot.0b0cc93# @clerk/themes
npm i @clerk/themes@1.7.5# @clerk/types
npm i @clerk/types@3.50.0-snapshot.0b0cc93 |
3640ba7 to
43d3432CompareUh oh!
There was an error while loading. Please reload this page.
| return []; | ||
| } | ||
| return domains.data.filter(d => { |
There was a problem hiding this comment.
❓ Why do we need to filter the domainList? Shouldn't FAPI take care of that?
There was a problem hiding this comment.
Yes, FAPI should be in charge of that.
At that moment filtering not available tho. A following PR aims to fix that.
| ); | ||
| }; | ||
| const OrganizationDomainsSection = () => { |
There was a problem hiding this comment.
🔧 Consider moving this to a separate file.
…t it + New `/add-domain/` route + New `/verify-domain/:id` route + New `/verified-domain/:id` route
+ Move RemoveResourcePage under common
clerk-cookie
commented
Aug 10, 2024
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.Tests will be added in a following PR
🚨This PR adds
<2 KBin the organizationprofile.js chunk 🚨This is not by accident
Video
screen-recording-2023-08-10-at-30745-pm_eT1QcrdM.mp4