Uh oh!
There was an error while loading. Please reload this page.
fix(clerk-js): Ensure new session is touched when setActive is called from non-standard browser - #1623
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: ceb8bf9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
marked this pull request as ready for review
August 22, 2023 20:25
panteliselef
requested review from
SokratisVidros and nikosdouvlis
as code ownersAugust 22, 2023 20:25
panteliselef
marked this pull request as draft
August 22, 2023 20:25
brkalowforce-pushed
the
brk.fix/expo-set-active-update-token
branch
from
August 22, 2023 22:40
b110286 to
c4b749bComparebrkalow
marked this pull request as ready for review
August 23, 2023 20:24
brkalow
commented
Aug 23, 2023
MemberAuthor
!snapshot |
clerk-cookie
commented
Aug 23, 2023
Collaborator
Hey @brkalow - the snapshot version command generated the following package versions:
Tip: use the snippet copy button below to quickly install the required packages. # @clerk/backend
npm i @clerk/backend@0.28.0-snapshot.87d921b# @clerk/chrome-extension
npm i @clerk/chrome-extension@0.3.27-snapshot.87d921b# @clerk/clerk-js
npm i @clerk/clerk-js@4.56.0-snapshot.87d921b# eslint-config-custom
npm i eslint-config-custom@0.3.0# @clerk/clerk-expo
npm i @clerk/clerk-expo@0.18.18-snapshot.87d921b# @clerk/fastify
npm i @clerk/fastify@0.6.4-snapshot.87d921b# gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.4.5-snapshot.87d921b# @clerk/localizations
npm i @clerk/localizations@1.25.0-snapshot.87d921b# @clerk/nextjs
npm i @clerk/nextjs@4.23.3-snapshot.87d921b# @clerk/clerk-react
npm i @clerk/clerk-react@4.24.0-snapshot.87d921b# @clerk/remix
npm i @clerk/remix@2.10.0-snapshot.87d921b# @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.12.3-snapshot.87d921b# @clerk/shared
npm i @clerk/shared@0.22.0-snapshot.87d921b# @clerk/themes
npm i @clerk/themes@1.7.5# @clerk/types
npm i @clerk/types@3.50.0-snapshot.87d921b |
jescalanforce-pushed
the
brk.fix/expo-set-active-update-token
branch
2 times, most recently
from
August 25, 2023 20:54
991ef45 to
57c1b67Comparejescalanforce-pushed
the
brk.fix/expo-set-active-update-token
branch
from
August 25, 2023 21:20
57c1b67 to
ceb8bf9Compare Merged
Uh oh!
There was an error while loading. Please reload this page.
clerk-cookie
commented
Aug 30, 2024
Collaborator
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
'npm testruns as expected.npm run buildruns as expected.Ensures we call
this.#touchLastActiveSession()insetActive()when we are in a non-standard browser environment. Practically, this currently applies to react native / expo environments.As part of adding tests, I also added a small test helper that mocks a "native" runtime environment:
mockNativeRuntime(). This can wrap any number ofit()ordescribe()blocks and will ensure that they run as if they are in a non-browser environment.fixes JS-653