') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); feat(clerk-js,types): Add appearance keys for pagination and table head by octoper · Pull Request #1803 · clerk/javascript · GitHub
Skip to content

feat(clerk-js,types): Add appearance keys for pagination and table head - #1803

Merged
octoper merged 6 commits into
mainfrom
vaggelis/js-754-add-external-class-to-organizationprofile-members-table
Oct 17, 2023
Merged

feat(clerk-js,types): Add appearance keys for pagination and table head#1803
octoper merged 6 commits into
mainfrom
vaggelis/js-754-add-external-class-to-organizationprofile-members-table

Conversation

@octoper

@octoperoctoper commented Sep 29, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Add missing appearance keys for Pagination text and buttons and Table head.

Before

Before

After

After

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@changeset-bot

changeset-botBot commented Sep 29, 2023•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8dc7d81

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
NameType
@clerk/clerk-jsMinor
@clerk/themesPatch
@clerk/typesMinor
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/backendPatch
@clerk/fastifyPatch
gatsby-plugin-clerkPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/clerk-sdk-nodePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper
octoperforce-pushed the vaggelis/js-754-add-external-class-to-organizationprofile-members-table branch 2 times, most recently from 37f04af to 68094abCompareSeptember 30, 2023 09:41
@nikosdouvlis
nikosdouvlis marked this pull request as ready for review October 2, 2023 11:31
@nikosdouvlis
nikosdouvlis requested a review from a team as a code ownerOctober 2, 2023 11:31
@octoper
octoperforce-pushed the vaggelis/js-754-add-external-class-to-organizationprofile-members-table branch from 9600b54 to 5a41fefCompareOctober 2, 2023 11:41
nikosdouvlis
nikosdouvlis reviewed Oct 4, 2023
View reviewed changes
Comment threadpackages/clerk-js/src/ui/elements/Pagination.tsx Outdated
/>{' '}
<Text
as='span'
colorScheme='inherit'

@nikosdouvlisnikosdouvlisOct 4, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@octoper I see we made some minor UI changes here, could you please add a screenshot in the PR description if needed? Even if the changes are minor, this always helps and we can use it for future reference as well.

@desiprisgdesiprisgOct 4, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's add a before and after showcasing why we need to use inherit here.

@octoperoctoperOct 4, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason I used colorScheme='inherit' here is just to have the colour to the parent element so I can use the element descriptor only theme.

@panteliselefpanteliselefOct 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@octoper I'm very skeptic about the result of the before/active. This is something i recently touched as well, but endup not making the change.

I don't think using the primary colour here makes sense, and the result is not that elegant.

@octoperoctoperOct 12, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panteliselef Yeah it's not that elegant but I thought that this should match the other parts of our components that have text, because if this is not changed every other part will have the primary colour and this will be black.

@octoper
octoperforce-pushed the vaggelis/js-754-add-external-class-to-organizationprofile-members-table branch 2 times, most recently from fe6598b to e7f1993CompareOctober 6, 2023 11:45
nikosdouvlis
nikosdouvlis approved these changes Oct 10, 2023
View reviewed changes

@nikosdouvlisnikosdouvlis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good :) Approving to unblock, let's discuss about the type issue offline

@octoper
octoperforce-pushed the vaggelis/js-754-add-external-class-to-organizationprofile-members-table branch from e7f1993 to 448a860CompareOctober 11, 2023 07:45
@octoper
octoperforce-pushed the vaggelis/js-754-add-external-class-to-organizationprofile-members-table branch from 2b841ea to 19c6aa3CompareOctober 12, 2023 08:47
@octoper
octoperforce-pushed the vaggelis/js-754-add-external-class-to-organizationprofile-members-table branch from 820e858 to 5b51cc8CompareOctober 12, 2023 20:04
@octoper
octoper added this pull request to the merge queue Oct 17, 2023
Merged via the queue into main with commit 35be870Oct 17, 2023
@octoper
octoper deleted the vaggelis/js-754-add-external-class-to-organizationprofile-members-table branch October 17, 2023 09:11
@clerk-cookieclerk-cookie mentioned this pull request Oct 17, 2023
Merged
@clerk-cookie

clerk-cookie commented Oct 17, 2024

Copy link
Copy Markdown
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerkclerk locked as resolved and limited conversation to collaborators Oct 17, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nikosdouvlisnikosdouvlisnikosdouvlis approved these changes
+3 more reviewers
@dimkldimkldimkl approved these changes
@panteliselefpanteliselefpanteliselef approved these changes
@desiprisgdesiprisgdesiprisg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

clerk-jsthemestypes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@octoper@clerk-cookie@nikosdouvlis@dimkl@panteliselef@desiprisg