Uh oh!
There was an error while loading. Please reload this page.
feature: Exclude archived repositories from list queries TAROT-3758 - #30
Conversation
Add isArchived: false to organization and user repository queries.
There was a problem hiding this comment.
Code Review
This pull request attempts to filter out archived repositories by adding the isArchived: false argument to both the ListOrganizationRepositoriesQuery and ListUserRepositoriesQuery GraphQL queries. However, the repositories field on both the Organization and User types in the GitHub GraphQL schema does not support this argument, which will result in GraphQL validation errors. To resolve this, you should either fetch the isArchived field and filter the results on the client side, or use the search query with archived:false.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| first: $size | ||
| after: $page | ||
| orderBy: { field: PUSHED_AT, direction: DESC } | ||
| isArchived: false |
There was a problem hiding this comment.
The repositories field on the Organization type in the GitHub GraphQL schema does not accept an isArchived argument. Adding isArchived: false here will cause a GraphQL validation error. To filter out archived repositories, you must either fetch the isArchived field and filter them on the client side, or use the search query with archived:false.
| after: $page | ||
| affiliations: [ OWNER ] | ||
| orderBy: { field: PUSHED_AT, direction: DESC } | ||
| isArchived: false |
There was a problem hiding this comment.
The repositories field on the User type in the GitHub GraphQL schema does not accept an isArchived argument. Adding isArchived: false here will cause a GraphQL validation error. To filter out archived repositories, you must either fetch the isArchived field and filter them on the client side, or use the search query with archived:false.
Up to standards ✅🟢 Issues |
There was a problem hiding this comment.
Pull Request Overview
The PR successfully implements the filtering logic to exclude archived repositories from organization and user-level GraphQL queries, aligning with the stated intent. Codacy analysis marks the PR as 'up to standards', although it notes that coverage requirements are missing for the new logic.
The primary concern is the lack of automated test coverage. Relying solely on manual verification for query logic introduces a risk of regression, especially as the repository structure or GraphQL schema evolves. It is recommended to implement automated integration tests to verify the exclusion logic before merging.
About this PR
- The PR lacks automated integration tests to verify that the GraphQL query filters correctly exclude archived repositories. Relying on manual verification is insufficient for core listing logic; please add unit or integration tests to confirm the behavior for both organization and user repository queries.
Test suggestions
- Verify ListOrganizationRepositoriesQuery excludes repositories where isArchived is true.
- Verify ListUserRepositoriesQuery excludes repositories where isArchived is true.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify ListOrganizationRepositoriesQuery excludes repositories where isArchived is true.
2. Verify ListUserRepositoriesQuery excludes repositories where isArchived is true.
TIP Improve review quality by adding custom instructionsTIP How was this review? Give us feedback
lolgab
commented
Jul 10, 2026
isArchived exists and does what we want. |
Summary
isArchived: falsetoListOrganizationRepositoriesQueryandListUserRepositoriesQueryto filter out archived repos from results.Test plan