Uh oh!
There was an error while loading. Please reload this page.
feat(config): add securityOpt passthrough to container create - #169
Conversation
Wire securityOpt from devcontainer.json through to docker run as --security-opt flags. The dockerless code path was missing this field. Add unit tests for the security opt arg assembly and an E2E test validating securityOpt on docker containers.
✅ Deploy Preview for devsydev canceled.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR extends devcontainer support to honor Docker security options ( ChangesDocker Security Options Support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
Uh oh!
There was an error while loading. Please reload this page.
Summary
securityOptvalues fromdevcontainer.jsonthrough todocker runas--security-optflagsSecurityOptfield in the dockerless container creation path (getDockerlessRunOptions)seccomp=unconfinedandapparmor=unconfinedapplied to containerSummary by CodeRabbit
Release Notes
New Features
Tests