fix(devcontainer): include feature containerEnv in metadata label and warn on parse failure

[skevetter]

Summary

• FeatureConfigToImageMetadata now includes ContainerEnv in the NonComposeBase struct, matching the behavior already present in DevContainerConfigToImageMetadata. Previously feature-level container environment variables were silently dropped from the image metadata label.
• Downgrades metadata parse failure log level from Errorf to Warnf in both GetImageMetadataFromContainer and GetImageMetadata, since both functions already gracefully degrade by returning an empty config rather than propagating the error.
• Adds a unit test verifying graceful degradation on corrupt metadata JSON.

Summary by CodeRabbit

Release Notes

• New Features

  • Container environment variables are now captured and included in metadata for non-Docker Compose configurations.

• Bug Fixes

  • Image metadata parsing failures now generate warnings instead of errors, improving system resilience when handling malformed metadata.

[netlify]

✅ Deploy Preview for devsydev canceled.

Name	Link
🔨 Latest commit	f69bc78
🔍 Latest deploy log	https://app.netlify.com/projects/devsydev/deploys/69fa56363d6b2c0008bc42cc

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 68f742e1-25b9-4f53-9474-89c0a863f69b

📥 Commits

Reviewing files that changed from the base of the PR and between 00dfefd and f69bc78.

📒 Files selected for processing (2)

• pkg/devcontainer/metadata/metadata.go
• pkg/devcontainer/metadata/metadata_test.go

---

📝 Walkthrough

Walkthrough

The PR adds a ContainerEnv field to the NonComposeBase struct and includes it when building image metadata from features. Error logging for metadata parsing failures is softened from error to warning level. Tests are updated to verify ContainerEnv is now included in metadata.

Changes

ContainerEnv Metadata Capture

Layer / File(s)	Summary
Data Shape pkg/devcontainer/metadata/metadata.go	NonComposeBase struct gains ContainerEnv field and is initialized with the feature's ContainerEnv value in FeatureConfigToImageMetadata.
Error Handling pkg/devcontainer/metadata/metadata.go	Error logs in GetImageMetadataFromContainer and GetImageMetadata are downgraded to warnings when metadata parsing fails; control flow remains unchanged.
Tests pkg/devcontainer/metadata/metadata_test.go	TestFeatureConfigToImageMetadata_ExcludesContainerEnv renamed to TestFeatureConfigToImageMetadata_IncludesContainerEnv and now asserts ContainerEnv is populated (FOO=bar, BAZ=qux). New test TestGetImageMetadataFromContainer_WarnsOnParseFailure verifies corrupt metadata labels produce warnings without errors.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• devsy-org/devsy#178: Directly related; both PRs add ContainerEnv to serialized metadata and adjust metadata parsing error logging to warnings.
• devsy-org/devsy#205: Related through image-based configuration paths; this PR adds ContainerEnv to NonComposeBase while the retrieved PR builds DevContainerConfig from image non-compose base.

Suggested labels

size/m

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the two main changes: including feature containerEnv in metadata and downgrading parse failures to warnings.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}