fix(delivery): clean up agent delivery volumes on workspace deletion

[skevetter]

Summary

• Add best-effort volume cleanup to workspace Delete() path via cleanupDeliveryVolume()
• Uses defer to ensure cleanup runs even when the container is already absent
• deleteForRecreate() inherits cleanup through its existing Delete() call
• 6 unit tests covering all deletion paths and error safety

Summary by CodeRabbit

Release Notes

• New Features
  • New configuration option to specify a helper container image for local Docker delivery.
  • Added automatic fallback mechanism: if helper container approach fails, the system seamlessly switches to direct file copy method.
  • Improved cleanup: agent delivery volumes are now properly cleaned up during container deletion operations.

[netlify]

✅ Deploy Preview for devsydev canceled.

Name	Link
🔨 Latest commit	9133d8d
🔍 Latest deploy log	https://app.netlify.com/projects/devsydev/deploys/6a03a14256011d0008c8b87d

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c8e74602-ef7c-4282-acb4-d90dfba1a090

📥 Commits

Reviewing files that changed from the base of the PR and between 9d5a5b8 and 9133d8d.

📒 Files selected for processing (8)

• pkg/agent/delivery/factory.go
• pkg/agent/delivery/factory_test.go
• pkg/agent/delivery/local_docker.go
• pkg/agent/delivery/local_docker_test.go
• pkg/devcontainer/delete.go
• pkg/devcontainer/delete_test.go
• pkg/devcontainer/setup.go
• pkg/provider/provider.go

---

📝 Walkthrough

Walkthrough

This PR adds configurable helper image support to the Docker-based agent delivery system. A new HelperImage field flows from provider configuration through the factory into LocalDockerDelivery, which now buffers binary data and attempts population via a helper container before falling back to direct-copy mounting.

Changes

Helper Image Configuration and Delivery

Layer / File(s)	Summary
Configuration Model and Factory Wiring pkg/provider/provider.go, pkg/agent/delivery/factory.go, pkg/agent/delivery/factory_test.go	ProviderDockerDriverConfig and FactoryOptions gain HelperImage fields; NewAgentDelivery wires it into LocalDockerDelivery. Factory test updates DockerCommand to use constant instead of literal string.
LocalDockerDelivery Helper Image Implementation pkg/agent/delivery/local_docker.go	LocalDockerDelivery adds HelperImage field with helperImageName() selector defaulting to busybox:latest. populateVolume refactored to buffer binary once, try helper-based population, and fallback to direct-copy via new populateVolumeDirectCopy and volumeMountpoint helpers that write binary and set executable permissions.
LocalDockerDelivery Tests pkg/agent/delivery/local_docker_test.go	Tests verify helperImageName() defaults, configured override, HelperImage propagation through factory, and fallback to direct-copy path with binary executable validation.
Setup Integration and Devcontainer Cleanup pkg/devcontainer/setup.go, pkg/devcontainer/delete.go	newAgentDelivery() integrates HelperImage from WorkspaceConfig; Delete() defers volume cleanup and adds cleanupDeliveryVolume() helper for best-effort cleanup.
Devcontainer Delete Tests pkg/devcontainer/delete_test.go	Comprehensive test suite with mockDriver and newTestRunner helper, covering nil container, find errors, running/stopped lifecycle, delete errors, and cleanup assertions.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• devsy-org/devsy#265: Extends AgentDelivery implementation by adding configurable HelperImage field and helper logic to LocalDockerDelivery, threading it through FactoryOptions and NewAgentDelivery.

Suggested labels

size/xl

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}