Uh oh!
There was an error while loading. Please reload this page.
fix(ci): pin Windows desktop builds to windows-2022 for node-gyp compat - #319
Conversation
windows-latest now includes VS 18, which node-gyp doesn't recognize, causing node-pty rebuild failures. Pin to windows-2022 (VS 17) to restore compatibility with the existing GYP_MSVS_VERSION=2022 config.
✅ Deploy Preview for devsydev canceled.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release workflow's ChangesWindows Runner Version Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
Summary
windows-latesttowindows-2022inrelease.ymlwindows-latestnow includes VS 18, which node-gyp doesn't recognize, causingelectron-rebuild/node-ptybuild failuresdesktop-ci.ymlalready useswindows-2022— no change neededwindows-latest(no node-gyp dependency)Summary by CodeRabbit