fix(agent): agent socket exceeds macos sun_path limit

[skevetter]

Signed-off-by: Samuel K skevetter@pm.me

Summary by CodeRabbit

• Bug Fixes

  • On macOS, the app now stores its runtime files in a stable home-directory location instead of a temporary location.
  • Improved SSH agent path validation to catch paths at the maximum allowed length and avoid failures at the boundary.

• Tests

  • Added coverage for socket path length edge cases.

[netlify]

✅ Deploy Preview for devsydev canceled.

Name	Link
🔨 Latest commit	9129a91
🔍 Latest deploy log	https://app.netlify.com/projects/devsydev/deploys/6a47d5bd89d1f10008a6664a

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8bf93c78-c68a-4428-af63-dc8c5138c15e

📥 Commits

Reviewing files that changed from the base of the PR and between dd860f3 and 9129a91.

📒 Files selected for processing (3)

• pkg/config/pathmanager_darwin.go
• pkg/ssh/server/agent.go
• pkg/ssh/server/agent_test.go

---

📝 Walkthrough

Walkthrough

This PR modifies Darwin's RuntimeDir() to derive its path from the user's home directory instead of the OS temp directory, and adjusts the socket path length check in the SSH agent from > to >=, removing a warning log, plus adds a boundary test.

Changes

Darwin Runtime Dir and Agent Socket Path Checks

Layer / File(s)	Summary
Darwin runtime directory resolution pkg/config/pathmanager_darwin.go	RuntimeDir() now resolves os.UserHomeDir() and builds ~/.<RepoName>/run, wrapping home-dir errors and calling ensureDir, replacing the prior temp-dir/UID-based path.
Agent socket path length boundary fix and test pkg/ssh/server/agent.go, pkg/ssh/server/agent_test.go	checkAgentSocketPathLen comparison changed from > to >=, comment clarified, log.Warnf call removed; a new TestCheckAgentSocketPathLen_Boundary test validates behavior at max-1, max, and max+1 lengths.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• devsy-org/devsy#74: Modifies the same darwinPathManager.RuntimeDir() function's directory selection/creation logic.
• devsy-org/devsy#441: Also touches checkAgentSocketPathLen/maxAgentSocketPath logic in the same file.

Suggested labels:size/m

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: fixing macOS agent socket paths that hit the sun_path length limit.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[netlify]

✅ Deploy Preview for images-devsy-sh canceled.

Name	Link
🔨 Latest commit	9129a91
🔍 Latest deploy log	https://app.netlify.com/projects/images-devsy-sh/deploys/6a47d5bd4f01860008df16f2