Uh oh!
There was an error while loading. Please reload this page.
feat(desktop): add shadcn-svelte config and Toggle/ToggleGroup components - #674
Merged
Conversation
…ents Add components.json and tsconfig path aliases so the shadcn-svelte CLI can resolve $lib and add future components consistently. Include the Toggle and ToggleGroup UI primitives (wrapping the existing bits-ui dependency), matching the repo's generated-component conventions. No behavior change to existing screens.
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughAdded shadcn-svelte and TypeScript path configuration, a reusable toggle component with variants and exports, and a toggle-group root/item pair using shared Svelte context and bits-ui primitives. ChangesToggle UI components
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Consumer
participant ToggleGroupRoot
participant SvelteContext
participant ToggleGroupItem
participant BitsToggleGroupPrimitive
Consumer->>ToggleGroupRoot: provide variant, size, and value
ToggleGroupRoot->>SvelteContext: set variant and size
ToggleGroupRoot->>BitsToggleGroupPrimitive: render root with bound ref and value
ToggleGroupItem->>SvelteContext: read variant and size
ToggleGroupItem->>BitsToggleGroupPrimitive: render item with computed classes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Foundation for using shadcn-svelte components consistently across the desktop app.
desktop/components.json(shadcn-svelte config: zinc base color,$libaliases,app.csslocation).$lib/$sharedpath aliases todesktop/tsconfig.jsonso the shadcn-svelte CLI can resolve imports and add future components. Verifiednpx shadcn-svelte@latest add <component>now resolves config and aliases cleanly.ToggleandToggleGroupUI primitives, wrapping the existingbits-uidependency and matching the repo's generated-component conventions.No behavior change to any existing screen — these are additive. The first consumer of
ToggleGroup(the create-workspace source selector) follows in a subsequent PR.Part of the UX work for #671.
Summary by CodeRabbit