Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jul 18, 2025. It is now read-only.
[WIP] APP-214 Enable 'docker app validate' for experimental mode only - #625
Merged
rumpl merged 2 commits intoNov 12, 2019
Merged
Conversation
thaJeztah
commented
Sep 20, 2019
Contributor
looks like there's a merge-conflict, so might need a rebase. |
aiordacheforce-pushed
the
app-214_experimental_validate
branch
2 times, most recently
from
September 20, 2019 18:28
2ab8657 to
1687455Compare| isExperimentalMode := dockerCli.ClientInfo().HasExperimental | ||
| for _, ccmd := range listOfCommands { | ||
| value, ok := ccmd.Annotations["experimental"] |
Contributor
There was a problem hiding this comment.
What do you think of:
switchccmd.Annotations["experimental"]{
case"true":
ifisExperimentalMode {
cmd.AddCommand(ccmd)
}
default:
cmd.AddCommand(ccmd)
}silvin-lubecki
commented
Sep 23, 2019
Contributor
The tests are failing. |
silvin-lubecki
suggested changes
Sep 23, 2019
silvin-lubecki
left a comment
Contributor
There was a problem hiding this comment.
Shouldn't this PR use docker/cli PR-2095, targeting your own docker/cli fork, so we can review that everything is aligned? And mark this PR as Draft so we won't merge it until the docker/cli PR is merged?
aiordacheforce-pushed
the
app-214_experimental_validate
branch
from
September 23, 2019 11:57
1687455 to
abd8a98Comparendeloof
commented
Oct 3, 2019
Contributor
What's the status of this one ? Shall we better close ? |
aiordache
commented
Oct 3, 2019
via email
ContributorAuthor
I am not sure about this :(
I'll rebase the PR on cli and wait for it to be accepted and merged, we are
waiting for some feedback from Sebastiaan on it. Then, probably we can
update the vendor in the PR for docker app....? …On Thu, Oct 3, 2019 at 10:37 AM Nicolas De loof ***@***.***> wrote:
What's the status of this one ? Shall we better close ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#625>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGFXL3FIWZKJCADMHV4VDTQMW4MLANCNFSM4IYZWFQA>
.
|
aiordacheforce-pushed
the
app-214_experimental_validate
branch
from
October 3, 2019 10:33
abd8a98 to
12bac15Compareaiordacheforce-pushed
the
app-214_experimental_validate
branch
5 times, most recently
from
November 8, 2019 16:55
0abfed5 to
807c3caCompareaiordacheforce-pushed
the
app-214_experimental_validate
branch
from
November 12, 2019 09:06
807c3ca to
9635037CompareCodecov Report
@@ Coverage Diff @@## master #625 +/- ##
==========================================
- Coverage 69.3% 69.28% -0.02%
==========================================
Files 63 63 Lines 3388 3396 +8 ==========================================
+ Hits 2348 2353 +5 - Misses 731 733 +2 - Partials 309 310 +1
Continue to review full report at Codecov.
|
| [[override]] | ||
| name = "github.com/Microsoft/hcsshim" | ||
| revision = "2226e083fc390003ae5aa8325c3c92789afa0e7a" | ||
added 2 commits
November 12, 2019 13:38
Signed-off-by: Anca Iordache <anca.iordache@docker.com>
Signed-off-by: Anca Iordache <anca.iordache@docker.com>
aiordacheforce-pushed
the
app-214_experimental_validate
branch
from
November 12, 2019 12:49
9635037 to
ed930a8Comparerumpl
approved these changes
Nov 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anca Iordache anca.iordache@docker.com
Fixes APP-214
Requires PR-2095
- What I did
Enabled validate command only for experimental mode
- How I did it
Added validate command to the list of commands only if experimental flag is on.
- How to verify it
- Description for the changelog
Add validate to the list of docker app commands only in experimental mode.
- A picture of a cute animal (not mandatory but encouraged)
